Re: [PATCH RFC 1/3] drm/msm/adreno: Add support for ACD

2024-11-07 Thread neil . armstrong
On 07/11/2024 13:46, Akhil P Oommen wrote: On 11/7/2024 2:25 PM, neil.armstr...@linaro.org wrote: On 06/11/2024 02:44, Akhil P Oommen wrote: On 11/4/2024 9:14 PM, neil.armstr...@linaro.org wrote: On 11/10/2024 22:29, Akhil P Oommen wrote: ACD a.k.a Adaptive Clock Distribution is a feature whi

Re: [PATCH RFC 1/3] drm/msm/adreno: Add support for ACD

2024-11-07 Thread neil . armstrong
On 06/11/2024 02:44, Akhil P Oommen wrote: On 11/4/2024 9:14 PM, neil.armstr...@linaro.org wrote: On 11/10/2024 22:29, Akhil P Oommen wrote: ACD a.k.a Adaptive Clock Distribution is a feature which helps to reduce the power consumption. In some chipsets, it is also a requirement to support high

Re: [PATCH 1/7] dt-bindings: display: panel: Rename rg35xx-plus-panel back to WL-355608-A8

2024-11-06 Thread Neil Armstrong
On 06/11/2024 05:56, Hironori KIKUCHI wrote: Ok, Thank you guys. Could you help me how to name the new panel YLM-LBV0345001H-V2 for the recent RG35XX Plus please? - Use `anbernic,rg35xx-plus-panel-v2` - Use `anbernic,rg35xx-plus-panel-new` - Use `anbernic,ylm-lbv0345001h-v2` - Share `anbernic,r

Re: [PATCH 1/3] drm/bridge/synopsys: Add MIPI DSI2 host controller bridge

2024-11-06 Thread neil . armstrong
Hi, On 06/11/2024 13:33, Heiko Stuebner wrote: From: Heiko Stuebner Add a Synopsys Designware MIPI DSI host DRM bridge driver for their DSI2 host controller, based on the Rockchip version from the driver rockchip/dw-mipi-dsi2.c in their vendor-kernel with phy & bridge APIs. While the driver i

Re: [PATCH RFC 1/3] drm/msm/adreno: Add support for ACD

2024-11-04 Thread neil . armstrong
On 11/10/2024 22:29, Akhil P Oommen wrote: ACD a.k.a Adaptive Clock Distribution is a feature which helps to reduce the power consumption. In some chipsets, it is also a requirement to support higher GPU frequencies. This patch adds support for GPU ACD by sending necessary data to GMU and AOSS. T

Re: [PATCH] drm/panel: novatek-nt35950: fix return value check in nt35950_probe()

2024-11-04 Thread neil . armstrong
return PTR_ERR(nt->dsi[1]); } num_dsis++; } Reviewed-by: Neil Armstrong

Re: [PATCH] drm/bridge: it6505: Fix inverted reset polarity

2024-11-04 Thread Neil Armstrong
T_LOW); + pdata->gpiod_reset = devm_gpiod_get(dev, "reset", GPIOD_OUT_HIGH); if (IS_ERR(pdata->gpiod_reset)) { dev_err(dev, "gpiod_reset gpio not found"); return PTR_ERR(pdata->gpiod_reset); Reviewed-by: Neil Armstrong

Re: [PATCH v2] drm/bridge: Fix assignment of the of_node of the parent to aux bridge

2024-10-31 Thread Neil Armstrong
On 30/10/2024 15:49, Sui Jingfeng wrote: Hi, On 2024/10/21 21:08, Neil Armstrong wrote: Hi, On Fri, 18 Oct 2024 15:49:34 +0300, Abel Vesa wrote: The assignment of the of_node to the aux bridge needs to mark the of_node as reused as well, otherwise resource providers like pinctrl will report

Re: [PATCH v2] drm/bridge: Fix assignment of the of_node of the parent to aux bridge

2024-10-31 Thread Neil Armstrong
On 30/10/2024 17:45, Sui Jingfeng wrote: Hi, On 2024/10/18 23:43, Dmitry Baryshkov wrote: On Fri, Oct 18, 2024 at 03:49:34PM +0300, Abel Vesa wrote: The assignment of the of_node to the aux bridge needs to mark the of_node as reused as well, otherwise resource providers like pinctrl will repor

Re: [PATCH] drm/panel: leadtek-ltk050h3146w: transition to mipi_dsi wrapped functions

2024-10-31 Thread neil . armstrong
On 30/10/2024 18:50, Doug Anderson wrote: Hi, On Wed, Oct 30, 2024 at 12:24 AM Tejas Vipin wrote: On 10/29/24 12:24 AM, Doug Anderson wrote: Hi, On Fri, Oct 25, 2024 at 9:00 PM Tejas Vipin wrote: @@ -418,79 +398,42 @@ static const struct ltk050h3146w_desc ltk050h3146w_data = {

Re: [PATCH] drm/panel: leadtek-ltk050h3146w: transition to mipi_dsi wrapped functions

2024-10-31 Thread Neil Armstrong
Hi, On Sat, 26 Oct 2024 09:29:28 +0530, Tejas Vipin wrote: > Changes the leadtek-ltk050h3146w panel to use multi style functions for > improved error handling. > > Thanks, Applied to https://gitlab.freedesktop.org/drm/misc/kernel.git (drm-misc-next) [1/1] drm/panel: leadtek-ltk050h3146w: tran

Re: [PATCH v4 0/5] Add new panel driver Samsung S6E88A0-AMS427AP24

2024-10-31 Thread Neil Armstrong
Hi, On Mon, 28 Oct 2024 00:42:01 +0100, Jakob Hauser wrote: > The patchset adds a new driver for Samsung AMS427AP24 panel with S6E88A0 > controller. Patches are based on current branch drm-misc-next. > > The discussion in v3 was not finished. I send v4 nonetheless as a new base to > continue the

Re: [PATCH 2/2] drm/panel: himax-hx83102: Add a check to prevent NULL pointer dereference

2024-10-31 Thread neil . armstrong
MODE_TYPE_DRIVER | DRM_MODE_TYPE_PREFERRED; drm_mode_set_name(mode); Reviewed-by: Neil Armstrong

Re: [PATCH] drm/panel: leadtek-ltk050h3146w: transition to mipi_dsi wrapped functions

2024-10-30 Thread neil . armstrong
a compile time constant. Not sure how I should handle this. I think the current version is fine: Reviewed-by: Neil Armstrong Reviewed-by: Douglas Anderson

Re: [PATCH] drm/bridge: tc358767: Improve DPI output pixel clock accuracy

2024-10-28 Thread Neil Armstrong
: Maxime Ripard Cc: Neil Armstrong Cc: Robert Foss Cc: Simona Vetter Cc: Thomas Zimmermann Cc: dri-devel@lists.freedesktop.org --- drivers/gpu/drm/bridge/tc358767.c | 28 ++-- 1 file changed, 26 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/bridge/tc358767.c

Re: [PATCH] drm/panel: synaptics-r63353: Fix regulator unbalance

2024-10-24 Thread Neil Armstrong
*rpanel = mipi_dsi_get_drvdata(dsi); - r63353_panel_unprepare(&rpanel->base); + drm_panel_unprepare(&rpanel->base); } static const struct r63353_desc sharp_ls068b3sx02_data = { With that: Reviewed-by: Neil Armstrong

Re: [PATCH v1] drm/bridge: tc358768: Fix DSI command tx

2024-10-23 Thread Neil Armstrong
ite(priv, TC358768_DSICMD_TX, 1); + tc358768_dsicmd_tx(priv); ret = tc358768_clear_error(priv); if (ret) Look good, I'll leave it here a few days if someone has comments Reviewed-by: Neil Armstrong

Re: [PATCH] drm/panel: s6e3ha8: add static modifier to supply list

2024-10-23 Thread Neil Armstrong
Hi, On Mon, 21 Oct 2024 16:52:36 +0300, Dzmitry Sankouski wrote: > Add 'static' modifier to panel supply list. > > Thanks, Applied to https://gitlab.freedesktop.org/drm/misc/kernel.git (drm-misc-next) [1/1] drm/panel: s6e3ha8: add static modifier to supply list https://gitlab.freedeskt

Re: [PATCH v2 5/5] drm/panel: samsung-s6e88a0-ams427ap24: Add flip option

2024-10-23 Thread Neil Armstrong
ret = s6e88a0_ams427ap24_register_backlight(ctx); if (ret < 0) return ret; With that changed: Reviewed-by: Neil Armstrong

Re: [PATCH v2 4/5] drm/panel: samsung-s6e88a0-ams427ap24: Add brightness control

2024-10-23 Thread Neil Armstrong
_DSI_MODE_VIDEO_NO_HFP; drm_panel_init(&ctx->panel, dev, &s6e88a0_ams427ap24_panel_funcs, DRM_MODE_CONNECTOR_DSI); ctx->panel.prepare_prev_first = true; + ret = s6e88a0_ams427ap24_register_backlight(ctx); + if (ret < 0) + return ret; + drm_panel_add(&ctx->panel); ret = mipi_dsi_attach(dsi); Wow this looks complex, anything this looks good overall, good work making it clean. Reviewed-by: Neil Armstrong

Re: [PATCH v2 3/5] drm/panel: samsung-s6e88a0-ams427ap24: Add initial driver

2024-10-23 Thread Neil Armstrong
Hi, On 22/10/2024 23:33, Jakob Hauser wrote: This initial part of the panel driver was mostly generated by the "linux-mdss-dsi-panel-driver-generator" tool [1], reading downstream Android kernel file "dsi_panel_S6E88A0_AMS427AP24_qhd_octa_video.dtsi" [2]. On top of the generic output of the too

Re: [PATCH 0/6] drm/bridge: add ycbcr_420_allowed support

2024-10-22 Thread neil . armstrong
On 21/10/2024 20:22, Dmitry Baryshkov wrote: On Mon, 21 Oct 2024 at 15:32, Neil Armstrong wrote: Hi, On 18/10/2024 23:49, Dmitry Baryshkov wrote: One of the features that drm_bridge_connector can't handle currently is setting of the ycbcr_420_allowed flag on the connector. Add the fl

Re: [PATCH] drm/panel: s6e3ha8: add static modifier to supply list

2024-10-21 Thread Neil Armstrong
_upstream_integration_panel_fix-32270575b583 Best regards, Reviewed-by: Neil Armstrong

Re: [PATCH] drm/bridge: tc358767: fix missing of_node_put() in for_each_endpoint_of_node()

2024-10-21 Thread Neil Armstrong
Hi, On Sun, 13 Oct 2024 20:11:29 +0200, Javier Carrasco wrote: > for_each_endpoint_of_node() requires a call to of_node_put() for every > early exit. A new error path was added to the loop without observing > this requirement. > > Add the missing call to of_node_put() in the error path. > > > [

Re: [PATCH v2] drm/bridge: Fix assignment of the of_node of the parent to aux bridge

2024-10-21 Thread Neil Armstrong
Hi, On Fri, 18 Oct 2024 15:49:34 +0300, Abel Vesa wrote: > The assignment of the of_node to the aux bridge needs to mark the > of_node as reused as well, otherwise resource providers like pinctrl will > report a gpio as already requested by a different device when both pinconf > and gpios property

Re: [PATCH] drm/bridge: ite-it66121: Drop hdmi_avi_infoframe_init() function call

2024-10-21 Thread Neil Armstrong
Hi, On Thu, 10 Oct 2024 17:26:43 +0800, Liu Ying wrote: > drm_hdmi_avi_infoframe_from_display_mode() called from > it66121_bridge_mode_set() already calls hdmi_avi_infoframe_init() to > initialize an HDMI AVI infoframe. So, drop the redundant > hdmi_avi_infoframe_init() function call from it66121

Re: [PATCH v3 0/2] Introduce bus-width property for input bus format

2024-10-21 Thread Neil Armstrong
Hi, On Thu, 17 Oct 2024 10:55:54 +0200, Wadim Egorov wrote: > This patch series introduces a bus-width property for the SI9022 HDMI > transmitter, allowing the input bus format to be configured based on the > number of RGB input pins. The default is set to 24-bit if unspecified. > > v3: > - Add

Re: [PATCH 1/2] dt-bindings: display: bridge: tc358768: switch to bus-width

2024-10-21 Thread Neil Armstrong
Hi, On Thu, 03 Oct 2024 15:39:03 +0200, Krzysztof Kozlowski wrote: > "data-lines" property is way too similar to "data-lanes". It is also > duplicating "bus-width" from video-interfaces.yaml schema. Deprecate > "data-lines" and use the common property. > > Thanks, Applied to https://gitlab.fr

Re: (subset) [PATCH -next 0/3] drm: Enable module autoloading

2024-10-21 Thread Neil Armstrong
Hi, On Mon, 02 Sep 2024 11:33:17 +, Liao Chen wrote: > This patch enables the autoloading feature of drm module. By registering > MDT, the kernel is allowed to automatically bind modules to devices that > match the specified compatible strings. > > > Liao Chen (3): > drm/bridge: it6505: En

Re: (subset) [PATCH 0/5] drm: misc: few simple cleanups

2024-10-21 Thread Neil Armstrong
Hi, On Sun, 08 Sep 2024 16:21:30 +0200, Krzysztof Kozlowski wrote: > No dependencies, trivial patches. > > Best regards, > Krzysztof > Thanks, Applied to https://gitlab.freedesktop.org/drm/misc/kernel.git (drm-misc-next) [1/5] drm/meson: drop unused staitc dw_hdmi_dwc_write_bits https:

Re: [PATCH 0/6] drm/bridge: add ycbcr_420_allowed support

2024-10-21 Thread Neil Armstrong
Hi, On 18/10/2024 23:49, Dmitry Baryshkov wrote: One of the features that drm_bridge_connector can't handle currently is setting of the ycbcr_420_allowed flag on the connector. Add the flag to the drm_bridge struct and propagate it to the drm_connector as AND of all flags in the bridge chain. A

Re: [PATCH v3 2/2] drm/bridge: sii902x: Set input bus format based on bus-width

2024-10-21 Thread neil . armstrong
us_width); + endpoint = of_graph_get_endpoint_by_regs(dev->of_node, 1, -1); if (endpoint) { struct device_node *remote = of_graph_get_remote_port_parent(endpoint); Reviewed-by: Neil Armstrong

Re: [PATCH 5/6] drm/msm/dp: migrate the ycbcr_420_allowed to drm_bridge

2024-10-21 Thread Neil Armstrong
uct drm_bridge *drm_bridge, struct drm_bridge_state *old_bridge_state); Reviewed-by: Neil Armstrong

Re: [PATCH 5/6] drm/msm/dp: migrate the ycbcr_420_allowed to drm_bridge

2024-10-21 Thread Neil Armstrong
uct drm_bridge *drm_bridge, struct drm_bridge_state *old_bridge_state); Reviewed-by: Neil Armstrong

Re: [PATCH 2/6] drm/atomic: add interlaced and ycbcr_420 flags to connector's state dump

2024-10-21 Thread Neil Armstrong
_requested_bpc=%d\n", state->max_requested_bpc); drm_printf(p, "\tcolorspace=%s\n", drm_get_colorspace_name(state->colorspace)); Reviewed-by: Neil Armstrong

Re: [PATCH 1/6] drm/display: bridge_connector: handle ycbcr_420_allowed

2024-10-21 Thread Neil Armstrong
odes. */ bool interlace_allowed; + /** +* @ycbcr_420_allowed: Indicate that the bridge can handle YCbCr 420 +* output. +*/ + bool ycbcr_420_allowed; /** * @pre_enable_prev_first: The bridge requires that the prev * bridge @pre_enable function is called before its @pre_enable, Reviewed-by: Neil Armstrong

Re: [PATCH 4/6] drm/bridge: aux: allow interlaced and YCbCr 420 output

2024-10-21 Thread Neil Armstrong
>driver_data; + /* passthrough data, allow everything */ + data->bridge.interlace_allowed = true; + data->bridge.ycbcr_420_allowed = true; + auxiliary_set_drvdata(auxdev, data); return devm_drm_bridge_add(data->dev, &data->bridge); Reviewed-by: Neil Armstrong

Re: [PATCH 3/6] drm/bridge: display-connector: allow YCbCr 420 for HDMI and DP

2024-10-21 Thread neil . armstrong
On 21/10/2024 11:06, Dmitry Baryshkov wrote: On Mon, 21 Oct 2024 at 10:29, Neil Armstrong wrote: On 18/10/2024 23:49, Dmitry Baryshkov wrote: Allow YCbCr 420 output for HDMI and DisplayPort connectors. Other bridges in the chain still might limit YCbCr 420 support on the corresponding

Re: [PATCH 6/6] drm/bridge: dw-hdmi: set bridge's ycbcr_420_allowed flag

2024-10-21 Thread Neil Armstrong
p;pdevinfo, 0, sizeof(pdevinfo)); pdevinfo.parent = dev; pdevinfo.id = PLATFORM_DEVID_AUTO; Reviewed-by: Neil Armstrong

Re: [PATCH 3/6] drm/bridge: display-connector: allow YCbCr 420 for HDMI and DP

2024-10-21 Thread Neil Armstrong
On 18/10/2024 23:49, Dmitry Baryshkov wrote: Allow YCbCr 420 output for HDMI and DisplayPort connectors. Other bridges in the chain still might limit YCbCr 420 support on the corresponding connector. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/bridge/display-connector.c | 4 1 f

Re: [PATCH v2] drm/bridge: Fix assignment of the of_node of the parent to aux bridge

2024-10-21 Thread Neil Armstrong
20241017-drm-aux-bridge-mark-of-node-reused-5c2ee740ff19 Best regards, Reviewed-by: Neil Armstrong

Re: [PATCH 2/6] drm/panel: Include

2024-10-16 Thread Neil Armstrong
On 11/10/2024 16:41, Thomas Zimmermann wrote: Include directly to get of_device_is_available(). Avoids the proxy include via Signed-off-by: Thomas Zimmermann Cc: Neil Armstrong Cc: Jessica Zhang --- drivers/gpu/drm/drm_panel.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers

Re: [PATCH 5/6] drm/panel: panel-samsung-s6e63m0: Include

2024-10-16 Thread Neil Armstrong
On 11/10/2024 16:41, Thomas Zimmermann wrote: Include directly to get device_property_read_u32(). Avoids the proxy include via Signed-off-by: Thomas Zimmermann Cc: Neil Armstrong Cc: Jessica Zhang --- drivers/gpu/drm/panel/panel-samsung-s6e63m0.c | 1 + 1 file changed, 1 insertion

Re: [PATCH 3/6] drm/panel: panel-orisetech-otm8009a: Include

2024-10-16 Thread Neil Armstrong
On 11/10/2024 16:41, Thomas Zimmermann wrote: Include directly to get struct of_device_id. Avoids the proxy include via Signed-off-by: Thomas Zimmermann Cc: Neil Armstrong Cc: Jessica Zhang --- drivers/gpu/drm/panel/panel-orisetech-otm8009a.c | 1 + 1 file changed, 1 insertion(+) diff

Re: [PATCH 4/6] drm/panel: panel-samsung-s6e3ha2: Include

2024-10-16 Thread Neil Armstrong
On 11/10/2024 16:41, Thomas Zimmermann wrote: Include directly to get struct of_device_id. Avoids the proxy include via Signed-off-by: Thomas Zimmermann Cc: Neil Armstrong Cc: Jessica Zhang --- drivers/gpu/drm/panel/panel-samsung-s6e63j0x03.c | 1 + 1 file changed, 1 insertion(+) diff

Re: [PATCH] [v2] drm/panel: s6e3ha8: select CONFIG_DRM_DISPLAY_DSC_HELPER

2024-10-16 Thread Neil Armstrong
Hi, On Tue, 15 Oct 2024 15:34:38 +, Arnd Bergmann wrote: > The new driver needs the dsc helper code to be available: > > x86_64-linux-ld: vmlinux.o: in function `s6e3ha8_amb577px01_wqhd_prepare': > panel-samsung-s6e3ha8.c:(.text+0x16b1e65): undefined reference to > `drm_dsc_pps_payload_pack'

Re: [PATCH 0/2] Add Samsung AMS581VF01 panel support

2024-10-16 Thread Neil Armstrong
Hi, On Mon, 14 Oct 2024 00:24:00 +0300, Danila Tikhonov wrote: > This patch series adds support for the Samsung AMS581VF01 panel, used in > the Google Pixel 4a (sm7150-google-sunfish). Unlike many other devices, > which may use different panels in various revisions, the Pixel 4a has only > one pos

Re: [PATCH] drm/mipi-dsi: fix kernel doc on mipi_dsi_compression_mode_multi

2024-10-10 Thread Neil Armstrong
Hi, On Thu, 10 Oct 2024 13:31:42 +0300, Dzmitry Sankouski wrote: > Replace dsi parameter on ctx in kernel doc of > mipi_dsi_compression_mode_multi function. > > Thanks, Applied to https://gitlab.freedesktop.org/drm/misc/kernel.git (drm-misc-next) [1/1] drm/mipi-dsi: fix kernel doc on mipi_dsi

Re: [PATCH] drm/mipi-dsi: fix kernel doc on mipi_dsi_compression_mode_multi

2024-10-10 Thread Neil Armstrong
eviewed-by: Neil Armstrong

Re: [PATCH v7 1/3] drm/mipi-dsi: add mipi_dsi_compression_mode_multi

2024-10-10 Thread Neil Armstrong
Hi, On 09/10/2024 17:09, Dzmitry Sankouski wrote: mipi_dsi_compression_mode_multi can help with error handling. Reviewed-by: Neil Armstrong Signed-off-by: Dzmitry Sankouski --- Changes in v7: - fix kernel doc The v6 patch was already merged to drm-misc-next, like the following ones, cold

Re: [PATCH v6 1/3] drm/mipi-dsi: add mipi_dsi_compression_mode_multi

2024-10-09 Thread Neil Armstrong
Hi, On 09/10/2024 14:18, kernel test robot wrote: Hi Dzmitry, kernel test robot noticed the following build warnings: [auto build test WARNING on 58ca61c1a866bfdaa5e19fb19a2416764f847d75] url: https://github.com/intel-lab-lkp/linux/commits/Dzmitry-Sankouski/drm-mipi-dsi-add-mipi_dsi_compr

Re: [PATCH v3 0/2] Add Samsung AMS639RQ08 panel support

2024-10-09 Thread Neil Armstrong
Hi, On Mon, 30 Sep 2024 23:24:46 +0300, Danila Tikhonov wrote: > This series adds Samsung AMS639RQ08 panel support used in: > - Xiaomi Mi 9 Lite / CC9 (sdm710-xiaomi-pyxis) > - Xiaomi Mi 9T / Redmi K20 (sm7150-xiaomi-davinci) > - Xiaomi Mi 9T Pro / Redmi K20 Pro (sm8150-xiaomi-raphael) > > Was te

Re: [PATCH] drm: panel: jd9365da-h3: Remove unused num_init_cmds structure member

2024-10-09 Thread Neil Armstrong
Hi, On Mon, 30 Sep 2024 13:05:03 -0400, Hugo Villeneuve wrote: > Now that the driver has been converted to use wrapped MIPI DCS functions, > the num_init_cmds structure member is no longer needed, so remove it. > > Thanks, Applied to https://gitlab.freedesktop.org/drm/misc/kernel.git (drm-misc

Re: [PATCH v6 0/3] Add Samsung S6E3HA8 panel driver

2024-10-09 Thread Neil Armstrong
Hi, On Sun, 06 Oct 2024 21:18:18 +0300, Dzmitry Sankouski wrote: > The s6e3ha8 is a 1440x2960 DPI AMOLED display panel from Samsung Mobile > Displays (SMD) > > Thanks, Applied to https://gitlab.freedesktop.org/drm/misc/kernel.git (drm-misc-next) [1/3] drm/mipi-dsi: add mipi_dsi_compression_

Re: [PATCH 0/2] drm/panel: ilitek-ili9881c: Support in-panel 180° rotation

2024-10-09 Thread Neil Armstrong
Hi, On Wed, 26 Jun 2024 16:40:37 +0200, Philipp Zabel wrote: > The Ilitek IL9881C controller can rotate the image by 180°. This > might be desirable on devices with their display mounted upside down, > that don't have rotation capability in the SoC display controller. > > Thanks, Applied to htt

Re: (subset) [PATCH v2 0/4] arm64: dts: imx8mm-kontron: Add HDMI and LVDS display support

2024-10-09 Thread Neil Armstrong
Hi, On Wed, 28 Aug 2024 09:46:52 +0200, Frieder Schrempf wrote: > From: Frieder Schrempf > > This add support for the display bridges (DSI->LVDS and DSI->HDMI) > on the BL i.MX8MM and the 7" LVDS panel in a separate overlay. > > Only one of the interfaces (HDMI or LVDS) is supported at the same

Re: [PATCH 0/2] drm/panel: ilitek-ili9881c: Support in-panel 180° rotation

2024-10-09 Thread Neil Armstrong
tions(-) --- base-commit: 1613e604df0cd359cf2a7fbd9be7a0bcfacfabd0 change-id: 20240626-drm-panel-ili9881c-rotation-54d53a885d7c Best regards, Reviewed-by: Neil Armstrong

Re: [PATCH v2 16/22] drm/msm/dpu: Configure CWB in writeback encoder

2024-10-09 Thread neil . armstrong
On 08/10/2024 14:25, Jessica Zhang wrote: On 10/8/2024 1:00 AM, Neil Armstrong wrote: Hi, On 01/10/2024 09:37, neil.armstr...@linaro.org wrote: Hi, On 30/09/2024 21:19, Jessica Zhang wrote: On 9/30/2024 7:17 AM, neil.armstr...@linaro.org wrote: On 25/09/2024 00:59, Jessica Zhang wrote

Re: [PATCH v2 16/22] drm/msm/dpu: Configure CWB in writeback encoder

2024-10-08 Thread Neil Armstrong
Hi, On 01/10/2024 09:37, neil.armstr...@linaro.org wrote: Hi, On 30/09/2024 21:19, Jessica Zhang wrote: On 9/30/2024 7:17 AM, neil.armstr...@linaro.org wrote: On 25/09/2024 00:59, Jessica Zhang wrote: When running igt-test on QRD8650, I get: # IGT_FRAME_DUMP_PATH=$PWD FRAME_PNG_FILE_N

Re: [PATCH v6 1/3] drm/mipi-dsi: add mipi_dsi_compression_mode_multi

2024-10-07 Thread Neil Armstrong
, const struct drm_dsc_picture_parameter_set *pps); Reviewed-by: Neil Armstrong

Re: [PATCH 1/2] dt-bindings: display: bridge: tc358768: switch to bus-width

2024-10-03 Thread Neil Armstrong
t32 enum: [ 16, 18, 24 ] +deprecated: true + + bus-width: +enum: [ 16, 18, 24 ] port@1: $ref: /schemas/graph.yaml#/properties/port Reviewed-by: Neil Armstrong

Re: [PATCH 2/2] drm/bridge: tc358768: switch to bus-width

2024-10-03 Thread Neil Armstrong
if (ep) { - ret = of_property_read_u32(ep, "data-lines", &priv->pd_lines); + ret = of_property_read_u32(ep, "bus-width", &priv->pd_lines); + if (ret) + ret = of_property_read_u32(ep, "data-lines", &priv->pd_lines); of_node_put(ep); } Reviewed-by: Neil Armstrong

Re: [PATCH v2 10/10] drm/meson: Allow build with COMPILE_TEST=y

2024-10-03 Thread Neil Armstrong
On 03/10/2024 13:18, Ville Syrjala wrote: From: Ville Syrjälä Allow meson to be built with COMPILE_TEST=y for greater coverage. Builds fine on x86/x86_64 at least. Cc: Neil Armstrong Cc: linux-amlo...@lists.infradead.org Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/meson/Kconfig | 2

Re: [RFC PATCH 1/1] drm/meson: Support drm_panic

2024-10-02 Thread Neil Armstrong
Hi, On 02/10/2024 13:02, Maxime Ripard wrote: + Jocelyn On Wed, Oct 02, 2024 at 09:59:57AM GMT, Neil Armstrong wrote: diff --git a/drivers/gpu/drm/meson/meson_plane.c b/drivers/gpu/drm/meson/meson_plane.c index b43ac61201f3..b2def784c00d 100644 --- a/drivers/gpu/drm/meson/meson_plane.c +++ b

Re: [RFC PATCH 1/1] drm/meson: Support drm_panic

2024-10-02 Thread Neil Armstrong
Hi ! On 01/10/2024 23:04, Yao Zi wrote: This patch implements drm_plane_helper_funcs.get_scanout_buffer for primary plane, enabling meson-drm to work with drm_panic. This implementation tries to use current framebuffer as scanout buffer. In case of AFBC enabled, we disable the decoder path and

Re: [PATCH v2 16/22] drm/msm/dpu: Configure CWB in writeback encoder

2024-10-01 Thread neil . armstrong
Hi, On 30/09/2024 21:19, Jessica Zhang wrote: On 9/30/2024 7:17 AM, neil.armstr...@linaro.org wrote: On 25/09/2024 00:59, Jessica Zhang wrote: Cache the CWB block mask in the DPU virtual encoder and configure CWB according to the CWB block mask within the writeback phys encoder Signed-off-b

Re: [PATCH] drm: panel: jd9365da-h3: Remove unused num_init_cmds structure member

2024-10-01 Thread Neil Armstrong
_init_cmds; bool lp11_before_reset; bool reset_before_power_off_vcioo; unsigned int vcioo_to_lp11_delay_ms; base-commit: 9852d85ec9d492ebef56dc5f229416c925758edc Reviewed-by: Neil Armstrong

Re: [PATCH] drm: panel: jd9365da-h3: fix reset signal polarity

2024-09-30 Thread neil . armstrong
On 30/09/2024 17:05, Hugo Villeneuve wrote: On Mon, 30 Sep 2024 16:38:14 +0200 Neil Armstrong wrote: Hi, On 27/09/2024 15:53, Hugo Villeneuve wrote: From: Hugo Villeneuve In jadard_prepare() a reset pulse is generated with the following statements (delays ommited for clarity

Re: [PATCH] drm: panel: jd9365da-h3: fix reset signal polarity

2024-09-30 Thread Neil Armstrong
Hi, On 27/09/2024 15:53, Hugo Villeneuve wrote: From: Hugo Villeneuve In jadard_prepare() a reset pulse is generated with the following statements (delays ommited for clarity): gpiod_set_value(jadard->reset, 1); --> Deassert reset gpiod_set_value(jadard->reset, 0); --> Assert reset

Re: [PATCH v5 2/2] drm/panel: Add support for S6E3HA8 panel driver

2024-09-30 Thread Neil Armstrong
of_match[] = { + { .compatible = "samsung,s6e3ha8" }, + { /* sentinel */ } +}; +MODULE_DEVICE_TABLE(of, s6e3ha8_amb577px01_wqhd_of_match); + +static struct mipi_dsi_driver s6e3ha8_amb577px01_wqhd_driver = { + .probe = s6e3ha8_amb577px01_wqhd_probe, + .remove = s6e3ha8_amb577px01_wqhd_remove, + .driver = { + .name = "panel-s6e3ha8", + .of_match_table = s6e3ha8_amb577px01_wqhd_of_match, + }, +}; +module_mipi_dsi_driver(s6e3ha8_amb577px01_wqhd_driver); + +MODULE_AUTHOR("Dzmitry Sankouski "); +MODULE_DESCRIPTION("DRM driver for S6E3HA8 panel"); +MODULE_LICENSE("GPL"); With that fixes: Reviewed-by: Neil Armstrong Thanks, Neil

Re: [PATCH 5/6] drm/panel: ili9322: Constify struct regmap_bus

2024-09-30 Thread Neil Armstrong
, .reg_format_endian_default = REGMAP_ENDIAN_BIG, Reviewed-by: Neil Armstrong

Re: [PATCH v2 16/22] drm/msm/dpu: Configure CWB in writeback encoder

2024-09-30 Thread neil . armstrong
On 25/09/2024 00:59, Jessica Zhang wrote: Cache the CWB block mask in the DPU virtual encoder and configure CWB according to the CWB block mask within the writeback phys encoder Signed-off-by: Jessica Zhang --- drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c| 83 +- d

Re: [PATCH 09/28] drm/meson: Use video aperture helpers

2024-09-30 Thread Neil Armstrong
On 30/09/2024 15:03, Thomas Zimmermann wrote: DRM's aperture functions have long been implemented as helpers under drivers/video/ for use with fbdev. Avoid the DRM wrappers by calling the video functions directly. Signed-off-by: Thomas Zimmermann Cc: Neil Armstrong Cc: Kevin Hilma

Re: [PATCH] drm: panel: nv3052c: correct spi_device_id for RG35XX panel

2024-09-30 Thread Neil Armstrong
8", }, + { "rg35xx-plus-panel", }, { /* sentinel */ } }; MODULE_DEVICE_TABLE(spi, nv3052c_ids); Reviewed-by: Neil Armstrong

Re: [PATCH v4 00/11] Preemption support for A7XX

2024-09-21 Thread Neil Armstrong
Le 20/09/2024 à 19:09, Akhil P Oommen a écrit : On Wed, Sep 18, 2024 at 09:46:33AM +0200, Neil Armstrong wrote: Hi, On 17/09/2024 13:14, Antonino Maniscalco wrote: This series implements preemption for A7XX targets, which allows the GPU to switch to an higher priority ring when work is pushed

Re: [PATCH v2 09/10] drm: bridge: dw_hdmi: Update EDID during hotplug processing

2024-09-20 Thread neil . armstrong
On 19/09/2024 22:34, Jonas Karlman wrote: Hi Neil, On 2024-09-13 10:02, Neil Armstrong wrote: On 08/09/2024 15:28, Jonas Karlman wrote: Update successfully read EDID during hotplug processing to ensure the connector diplay_info is always up-to-date. Signed-off-by: Jonas Karlman --- v2: No

Re: [PATCH v4 00/11] Preemption support for A7XX

2024-09-18 Thread Neil Armstrong
in unrelated to preempt support. So you can also add: Tested-by: Neil Armstrong # on SM8550-QRD Tested-by: Neil Armstrong # on SM8450-HDK Thanks, Neil

Re: [PATCH v1 1/1] drm/panel: sony-acx565akm: Use %*ph to print small buffer

2024-09-13 Thread Neil Armstrong
Hi, On Wed, 11 Sep 2024 23:01:25 +0300, Andy Shevchenko wrote: > Use %*ph format to print small buffer as hex string. > > Thanks, Applied to https://gitlab.freedesktop.org/drm/misc/kernel.git (drm-misc-next) [1/1] drm/panel: sony-acx565akm: Use %*ph to print small buffer https://gitlab

Re: [PATCH] drm/panel: khadas-ts050: make ts050[v2]_panel_data static

2024-09-13 Thread Neil Armstrong
Hi, On Sun, 08 Sep 2024 21:35:30 +0800, Min-Hua Chen wrote: > make ts050_panel_data and ts050v2_panel_data static because they > are only used in drivers/gpu/drm/panel/panel-khadas-ts050.c, > and fix the following sparse warnings: > > drivers/gpu/drm/panel/panel-khadas-ts050.c:620:32: > sparse: w

Re: [PATCH] drm: panel: nt36523: use devm_mipi_dsi_* function to register and attach dsi

2024-09-13 Thread Neil Armstrong
Hi, On Wed, 04 Sep 2024 22:29:07 +0800, Jianhua Lu wrote: > Switch to devm_mipi_dsi_* function, we don't need to detach and > unregister dsi manually any more. > > Thanks, Applied to https://gitlab.freedesktop.org/drm/misc/kernel.git (drm-misc-next) [1/1] drm: panel: nt36523: use devm_mipi_ds

Re: [PATCH v2 2/4] dt-bindings: display: panel-lvds: Add compatible for Jenson BL-JT60050-01A

2024-09-13 Thread Neil Armstrong
Hi, On 28/08/2024 09:46, Frieder Schrempf wrote: From: Frieder Schrempf The Jenson BL-JT60050-01A is a 7" 1024x600 LVDS display. Signed-off-by: Frieder Schrempf Acked-by: Conor Dooley --- Changes for v2: * Add tag from Conor (thanks!) --- Documentation/devicetree/bindings/display/panel/pa

Re: [PATCH v1 1/1] drm/panel: sony-acx565akm: Use %*ph to print small buffer

2024-09-13 Thread Neil Armstrong
d[2]); + dev_dbg(&lcd->spi->dev, "MIPI display ID: %3phN\n", lcd->display_id); switch (lcd->display_id[0]) { case 0x10: Reviewed-by: Neil Armstrong

Re: [PATCH] drm: panel: nt36523: use devm_mipi_dsi_* function to register and attach dsi

2024-09-13 Thread Neil Armstrong
s = pinfo->desc->mode_flags; - ret = mipi_dsi_attach(pinfo->dsi[i]); + ret = devm_mipi_dsi_attach(dev, pinfo->dsi[i]); if (ret < 0) return dev_err_probe(dev, ret, "cannot attach to DSI%d host.\n", i); } Reviewed-by: Neil Armstrong

Re: [PATCH] drm/panel: raydium-rm69380: transition to mipi_dsi wrapped functions

2024-09-13 Thread neil . armstrong
Hi, On 07/09/2024 16:01, Tejas Vipin wrote: Changes the raydium-rm69380 panel to use multi style functions for improved error handling. Signed-off-by: Tejas Vipin --- drivers/gpu/drm/panel/panel-raydium-rm69380.c | 95 ++- 1 file changed, 30 insertions(+), 65 deletions(-) di

Re: [PATCH 3/5] drm/fsl-dcu: constify regmap_config

2024-09-13 Thread Neil Armstrong
CON_BYPASS); } -static struct regmap_config fsl_tcon_regmap_config = { +static const struct regmap_config fsl_tcon_regmap_config = { .reg_bits = 32, .reg_stride = 4, .val_bits = 32, Reviewed-by: Neil Armstrong

Re: [PATCH v2] drm/bridge: imx8mp-hdmi-tx: allow 0.5% margin with selected clock

2024-09-13 Thread Neil Armstrong
Hi, On Sat, 07 Sep 2024 14:54:33 +0900, Dominique Martinet wrote: > This allows the hdmi driver to pick e.g. 64.8MHz instead of 65Mhz when we > cannot output the exact frequency, enabling the imx8mp HDMI output to > support more modes > > Thanks, Applied to https://gitlab.freedesktop.org/drm/mi

Re: [PATCH 1/6] drm/bridge: imx8mp-hdmi-tx: Switch to SYSTEM_SLEEP_PM_OPS()

2024-09-13 Thread Neil Armstrong
Hi, On Wed, 26 Jun 2024 20:06:59 -0300, Fabio Estevam wrote: > Replace SET_SYSTEM_SLEEP_PM_OPS with its modern SYSTEM_SLEEP_PM_OPS() > alternative. > > The combined usage of pm_ptr() and SYSTEM_SLEEP_PM_OPS() > allows the compiler to evaluate if the runtime suspend/resume() functions > are used a

Re: [PATCH v3 0/3] Improve tc358767 debugging

2024-09-13 Thread Neil Armstrong
Hi, On Wed, 04 Sep 2024 14:05:42 +0200, Alexander Stein wrote: > this small series improves debugging the tc358767 driver by using > dev_err_probe for additional information (patch 1) and print IRQ > debug output only if hotplug status actually changed. > > Changes inv 3: > * Collected Robert's a

Re: [PATCH v2 05/10] drm: bridge: dw_hdmi: Fold poweron and setup functions

2024-09-13 Thread Neil Armstrong
mutex_lock(&hdmi->mutex); hdmi->disabled = false; hdmi->curr_conn = connector; - dw_hdmi_poweron(hdmi); + dw_hdmi_poweron(hdmi, connector, mode); dw_hdmi_update_phy_mask(hdmi); handle_plugged_change(hdmi, true); mutex_unlock(&hdmi->mutex); Reviewed-by: Neil Armstrong

Re: [PATCH v2 03/10] drm: bridge: dw_hdmi: Call poweron/poweroff from atomic enable/disable

2024-09-13 Thread Neil Armstrong
if (hpd) hdmi->rxsense = true; - dw_hdmi_update_power(hdmi); dw_hdmi_update_phy_mask(hdmi); } mutex_unlock(&hdmi->mutex); Reviewed-by: Neil Armstrong

Re: [PATCH v2 04/10] drm: bridge: dw_hdmi: Use passed mode instead of stored previous_mode

2024-09-13 Thread Neil Armstrong
&connector->display_info, - &hdmi->previous_mode); + /* HDMI Initialization Step B.2 */ + ret = hdmi->phy.ops->init(hdmi, hdmi->phy.data, display, mode); if (ret) return ret; hdmi->phy.enabled = true; Reviewed-by: Neil Armstrong

Re: [PATCH v2 06/10] drm: bridge: dw_hdmi: Remove previous_mode and mode_set

2024-09-13 Thread Neil Armstrong
dw_hdmi_bridge_mode_set, .mode_valid = dw_hdmi_bridge_mode_valid, .detect = dw_hdmi_bridge_detect, .edid_read = dw_hdmi_bridge_edid_read, Reviewed-by: Neil Armstrong

Re: [PATCH v2 09/10] drm: bridge: dw_hdmi: Update EDID during hotplug processing

2024-09-13 Thread Neil Armstrong
On 08/09/2024 15:28, Jonas Karlman wrote: Update successfully read EDID during hotplug processing to ensure the connector diplay_info is always up-to-date. Signed-off-by: Jonas Karlman --- v2: No change --- drivers/gpu/drm/bridge/synopsys/dw-hdmi.c | 12 1 file changed, 12 inser

Re: [PATCH 1/6] drm/bridge: imx8mp-hdmi-tx: Switch to SYSTEM_SLEEP_PM_OPS()

2024-09-13 Thread neil . armstrong
ver imx8mp_dw_hdmi_platform_driver = { .driver = { .name = "imx8mp-dw-hdmi-tx", .of_match_table = imx8mp_dw_hdmi_of_table, - .pm = &imx8mp_dw_hdmi_pm_ops, + .pm = pm_ptr(&imx8mp_dw_hdmi_pm_ops), }, };

Re: [PATCH] drm/bridge: nwl-dsi: Use vsync/hsync polarity from display mode

2024-09-13 Thread Neil Armstrong
0x21c --- base-commit: 7c626ce4bae1ac14f60076d00eafe71af30450ba change-id: 20240814-nwl-dsi-sync-polarity-ddc58435a4c4 Best regards, Reviewed-by: Neil Armstrong

Re: [PATCH 1/2] drm/bridge: dw-hdmi: Move vmalloc PCM buffer management into the driver

2024-09-13 Thread Neil Armstrong
_prepare, .trigger = dw_hdmi_trigger, .pointer = dw_hdmi_pointer, - .page = snd_pcm_lib_get_vmalloc_page, + .page = dw_hdmi_get_page, }; static int snd_dw_hdmi_probe(struct platform_device *pdev) Reviewed-by: Neil Armstrong

Re: [PATCH 6/6] drm/bridge: imx8qxp-ldb: Switch to RUNTIME_PM_OPS()

2024-09-13 Thread neil . armstrong
.of_match_table = imx8qxp_ldb_dt_ids, }, Reviewed-by: Neil Armstrong

Re: [PATCH 5/6] drm/bridge: dw-hdmi-cec: Switch to SYSTEM_SLEEP_PM_OPS()

2024-09-13 Thread neil . armstrong
odule_platform_driver(dw_hdmi_cec_driver); Reviewed-by: Neil Armstrong

Re: [PATCH 4/6] drm/bridge: samsung-dsim: Switch to RUNTIME_PM_OPS()

2024-09-13 Thread neil . armstrong
driver = { .name = "samsung-dsim", - .pm = &samsung_dsim_pm_ops, + .pm = pm_ptr(&samsung_dsim_pm_ops), .of_match_table = samsung_dsim_of_match, }, }; Reviewed-by: Neil Armstrong

Re: [PATCH 3/6] drm/bridge: imx8qxp-pixel-combiner: Switch to RUNTIME_PM_OPS()

2024-09-13 Thread neil . armstrong
.of_match_table = imx8qxp_pc_dt_ids, }, Reviewed-by: Neil Armstrong

  1   2   3   4   5   6   7   8   9   10   >