Re: [PATCH] drm/bridge: analogix_dp: Don't return -EBUSY when msg->size is 0 in aux transaction

2017-02-20 Thread Zain Wang
Hi Tomasz, 在 2017/2/20 10:40, Tomasz Figa 写道: Hi Zain, On Mon, Feb 13, 2017 at 6:27 PM, zain wang <w...@rock-chips.com> wrote: The analogix_dp_transfer() will return -EBUSY if num_transferred is zero. But sometimes we will send a bare address packet to start the transaction

Re: [PATCH] drm/bridge: analogix_dp: Don't return -EBUSY when msg->size is 0 in aux transaction

2017-02-20 Thread Zain Wang
Hi Sean, Could you give some comments for this patch? Thanks Zain 在 2017/2/13 17:27, zain wang 写道: The analogix_dp_transfer() will return -EBUSY if num_transferred is zero. But sometimes we will send a bare address packet to start the transaction, like drm_dp_i2c_xfer() show

[PATCH] drm/bridge: analogix_dp: Don't return -EBUSY when msg->size is 0 in aux transaction

2017-02-13 Thread zain wang
urn num_transferred if num_transferred equals msg->size. Signed-off-by: zain wang <w...@rock-chips.com> --- drivers/gpu/drm/bridge/analogix/analogix_dp_reg.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/bridge/analogix/analogix_dp_reg.c b/drivers/gp

[PATCH v2] drm/bridge: analogix: Don't return -EINVAL when panel not support PSR in PSR functions

2016-12-07 Thread zain wang
We will ignored PSR setting if panel not support it. So, in this case, we should return from analogix_dp_enable/disable_psr() without any error code. Let's retrun 0 instead of -EINVAL when panel not support PSR in analogix_dp_enable/disable_psr(). Signed-off-by: zain wang --- Changes in v2

[PATCH] drm/bridge: analogix: Don't return -EINVAL when panel not support PSR in PSR functions

2016-12-02 Thread zain wang
We will ignored PSR setting if panel not support it. So, in this case, we should return from analogix_dp_enable/disable_psr() without any error code. Let's retrun 0 instead of -EINVAL when panel not support PSR in analogix_dp_enable/disable_psr(). Signed-off-by: zain wang --- drivers/gpu/drm

[PATCH] drm/panel: simple: add 8bit-bps for Sharp lq123p1jx31

2016-11-19 Thread zain wang
Sharp lq123p1jx31 support 8bit bps. Signed-off-by: zain wang --- drivers/gpu/drm/panel/panel-simple.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c index 113db3c..6b0c026 100644 --- a/drivers/gpu/drm/panel/panel

[PATCH 6/6] drm: bridge/analogix: enable vop standby when entry PSR

2016-10-18 Thread Zain Wang
From: zain wang <w...@rock-chips.com> make VOP standby when entry PSR to save some power. Signed-off-by: zain wang --- drivers/gpu/drm/rockchip/analogix_dp-rockchip.c | 29 ++--- drivers/gpu/drm/rockchip/rockchip_drm_drv.h | 1 + drivers/gpu/drm/ro

[PATCH v3 5/6] drm: bridge/analogix: add fast link train for eDP

2016-10-18 Thread Zain Wang
From: zain wang <w...@rock-chips.com> we would meet a short black screen when exit PSR with the full link training, In this case, we should use fast link train instead of full link training. Signed-off-by: zain wang --- drivers/gpu/drm/bridge/analogix/analogix_dp_core.

[PATCH v3 4/6] drm: bridge/analogix: switch Main-link and eDP PHY when enable/disable psr

2016-10-18 Thread Zain Wang
From: zain wang <w...@rock-chips.com> turn off Main-link and power down eDP PHY when enable psr, turn on Main-link and power up eDP PHY when disable psr. Signed-off-by: zain wang --- Changes in v3: - detecting PSR state at enable/disable_psr() avoid to make link training when sink in n

[PATCH v3 3/6] drm/bridge: analogix_dp: detect Sink PSR state after configuring the PSR

2016-10-18 Thread Zain Wang
From: Yakir Yang <y...@rock-chips.com> Make sure the request PSR state takes effect in analogix_dp_send_psr_spd() function, or print the sink PSR error state if we failed to apply the requested PSR setting. Signed-off-by: zain wang Signed-off-by: Yakir Yang --- Changes in v3: None C

[PATCH v3 2/6] drm/bridge: remove dp init from analogix_dp_bind

2016-10-18 Thread Zain Wang
From: zain wang <w...@rock-chips.com> phy_power_on() and analogix_dp_init_dp would be called in bridge_eanble, so remove them from analogix_dp_bind to be clear. Signed-off-by: zain wang --- Changes in v3: - remove changes before - remove phy_power_on() and analogix_dp_init_d

[PATCH v3 1/6] drm/bridge: analogix_dp: set psr activate/deactivate when enable/disable bridge

2016-10-18 Thread Zain Wang
From: zain wang <w...@rock-chips.com> There's a race between when bridge_disable and when vop_crtc_disable are called. If the flush timer triggers a new psr work between these, we will operate eDP without power shutdowned by bridge_disable. In this case, moving activate/deactivate to

[PATCH v3 0/6] Misc changes to Rockchip PSR drivers

2016-10-18 Thread Zain Wang
Yang (1): drm/bridge: analogix_dp: detect Sink PSR state after configuring the PSR zain wang (5): drm/bridge: analogix_dp: set psr activate/deactivate when enable/disable bridge drm/bridge: remove dp init from analogix_dp_bind drm: bridge/analogix: switch Main-link and eDP PHY when

[PATCH v2 4/4] drm: bridge/analogix: switch Main-link and eDP PHY when enable/disable psr

2016-09-30 Thread zain wang
turn off Main-link and power down eDP PHY when enable psr, turn on Main-link and power up eDP PHY when disable psr. Signed-off-by: zain wang --- Changes in v2: - misc changes drivers/gpu/drm/bridge/analogix/analogix_dp_core.c | 124 - 1 file changed, 70 insertions(+), 54

[PATCH v2 3/4] drm/bridge: analogix_dp: detect Sink PSR state after configuring the PSR

2016-09-30 Thread zain wang
From: Yakir Yang <y...@rock-chips.com> Make sure the request PSR state takes effect in analogix_dp_send_psr_spd() function, or print the sink PSR error state if we failed to apply the requested PSR setting. Signed-off-by: Yakir Yang Signed-off-by: Zain Wang --- Changes in v2: None d

[PATCH v2 2/4] drm/bridge: analogix_dp: get sync PM when init eDP

2016-09-30 Thread zain wang
Signed-off-by: zain wang --- Changes in v2: None drivers/gpu/drm/bridge/analogix/analogix_dp_core.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c b/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c index b4ce16a..1bd190e 100644

[PATCH v2 1/4] drm/bridge: analogix_dp: prevent runing enable_psr when disabled bridge.

2016-09-30 Thread zain wang
When disabled bridge, analogix_dp_enable_psr() may run due to timer was set by rockchip_drm_do_flush(), in this case we should return -EBUSY. Signed-off-by: zain wang --- Changes in v2: - add spin_lock to protect dpms_mode drivers/gpu/drm/bridge/analogix/analogix_dp_core.c | 43

[PATCH v2 0/4] Misc changes to Rockchip PSR drivers

2016-09-30 Thread zain wang
: analogix_dp: detect Sink PSR state after configuring the PSR zain wang (3): drm/bridge: analogix_dp: prevent runing enable_psr when disabled bridge. drm/bridge: analogix_dp: get sync PM when init eDP drm: bridge/analogix: switch Main-link and eDP PHY when enable/disable psr

[PATCH v1 4/4] drm: bridge/analogix: switch Main-link and eDP PHY when enable/disable psr

2016-09-29 Thread zain wang
turn off Main-link and power down eDP PHY when enable psr, turn on Main-link and power up eDP PHY when disable psr. Signed-off-by: zain wang --- drivers/gpu/drm/bridge/analogix/analogix_dp_core.c | 105 ++--- 1 file changed, 52 insertions(+), 53 deletions(-) diff --git

[PATCH v1 3/4] drm/bridge: analogix_dp: detect Sink PSR state after configuring the PSR

2016-09-29 Thread zain wang
From: Yakir Yang <y...@rock-chips.com> Make sure the request PSR state takes effect in analogix_dp_send_psr_spd() function, or print the sink PSR error state if we failed to apply the requested PSR setting. Signed-off-by: Yakir Yang Signed-off-by: Zain Wang --- drivers/gpu/drm/

[PATCH v1 2/4] drm/bridge: analogix_dp: get sync PM when init eDP

2016-09-29 Thread zain wang
Signed-off-by: zain wang --- drivers/gpu/drm/bridge/analogix/analogix_dp_core.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c b/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c index 206529a..026ec91 100644 --- a/drivers/gpu/drm

[PATCH v1 1/4] drm/bridge: analogix_dp: prevent runing enable_psr when disabled bridge.

2016-09-29 Thread zain wang
When disabled bridge, analogix_dp_enable_psr() may run due to timer was set by rockchip_drm_do_flush(), in this case we should return -EBUSY. Signed-off-by: zain wang --- drivers/gpu/drm/bridge/analogix/analogix_dp_core.c | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff

[PATCH v1 0/4] Misc changes to Rockchip PSR drivers

2016-09-29 Thread zain wang
zain wang (3): drm/bridge: analogix_dp: prevent runing enable_psr when disabled bridge. drm/bridge: analogix_dp: get sync PM when init eDP drm: bridge/analogix: switch Main-link and eDP PHY when enable/disable psr drivers/gpu/drm/bridge/analogix/analogix_dp_core.c | 107