If it is not submitted yet, Reviewed-by: Chunming Zhou
-David
On 2019年08月09日 21:43, Lionel Landwerlin wrote:
The Vulkan timeline semaphores allow signaling to happen on the point
of the timeline without all of the its dependencies to be created.
The current 2 implementations (AMD/Intel) of
On 2019年08月02日 17:41, Lionel Landwerlin wrote:
Hey David,
On 02/08/2019 12:11, zhoucm1 wrote:
Hi Lionel,
For binary semaphore, I guess every one will think application will
guarantee wait is behind the signal, whenever the semaphore is shared
or used in internal-process.
I think below
Hi Lionel,
For binary semaphore, I guess every one will think application will
guarantee wait is behind the signal, whenever the semaphore is shared or
used in internal-process.
I think below two options can fix your problem:
a. Can we extend vkWaitForFence so that it can be able to wait on
On 2019年07月30日 17:40, Lionel Landwerlin wrote:
On 30/07/2019 12:36, Daniel Vetter wrote:
On Tue, Jul 30, 2019 at 05:31:26PM +0800, zhoucm1 wrote:
On 2019年07月30日 17:27, Daniel Vetter wrote:
On Mon, Jul 29, 2019 at 04:20:39PM +0800, Chunming Zhou wrote:
It is normal that binary syncobj
On 2019年07月30日 17:27, Daniel Vetter wrote:
On Mon, Jul 29, 2019 at 04:20:39PM +0800, Chunming Zhou wrote:
It is normal that binary syncobj replaces the underlying fence.
Signed-off-by: Chunming Zhou
Do we hit this with one of the syncobj igts?
Unforturnately, No, It's only hit in AMDGPU pat
Thanks guys, since I have no write permission to libdrm, I need your
help to push patch.
-David
On 2019年07月25日 16:11, Chunming Zhou wrote:
v2: nit-picks fix
Signed-off-by: Chunming Zhou
Cc: Lionel Landwerlin
Cc: Christian König
Reviewed-by: Christian König
For the xf86drm.[ch] part : Revie
Thank guys. Since I have write permission to libdrm mast, I need your
help to push patch.
-David
On 2019年07月25日 16:11, Chunming Zhou wrote:
v2: nit-picks fix
Signed-off-by: Chunming Zhou
Cc: Lionel Landwerlin
Cc: Christian König
Reviewed-by: Christian König
For the xf86drm.[ch] part : Re
On 2019年07月24日 03:20, Lionel Landwerlin wrote:
On 23/07/2019 17:21, Chunming Zhou wrote:
user space needs a flexiable query ability.
So that umd can get last signaled or submitted point.
v2:
add sanitizer checking.
Change-Id: I6512b430524ebabe715e602a2bf5abb0a7e780ea
Signed-off-by: Chunming Z
On 2019年07月22日 16:46, Lionel Landwerlin wrote:
On 18/07/2019 14:13, Chunming Zhou wrote:
if WAIT_FOR_SUBMIT isn't set and in the meanwhile no underlying fence
on syncobj,
then return non-block error code to user sapce.
Signed-off-by: Chunming Zhou
---
drivers/gpu/drm/drm_syncobj.c | 4 ++-
On 2019年07月19日 16:13, Lionel Landwerlin wrote:
On 18/07/2019 17:33, Chunming Zhou wrote:
在 2019/7/18 22:08, Lionel Landwerlin 写道:
On 18/07/2019 16:02, Chunming Zhou wrote:
在 2019/7/18 19:31, Lionel Landwerlin 写道:
On 18/07/2019 14:13, Chunming Zhou wrote:
if WAIT_FOR_SUBMIT isn't set and in
https://gitlab.freedesktop.org/mesa/drm, Where the merge request button?
-David
On 2019年06月06日 18:20, Michel Dänzer wrote:
On 2019-05-24 7:15 a.m., zhoucm1 wrote:
anyone can pick up to gitlab for libdrm?
Can you create a merge request?
___
dri
anyone can pick up to gitlab for libdrm?
Thanks,
-David
On 2019年05月22日 18:46, Koenig, Christian wrote:
Am 22.05.19 um 11:07 schrieb Chunming Zhou:
a) delta: only DRM_CAP_SYNCOBJ_TIMELINE
b) Generated using make headers_install.
c) Generated from origin/drm-misc-next commit
9
On 2019年05月22日 20:59, Christian König wrote:
[CAUTION: External Email]
BOs on the LRU might be blocked during command submission
and cause OOM situations.
Avoid this by blocking for the first busy BO not locked by
the same ticket as the BO we are searching space for.
v10: completely start ov
On 2019年05月22日 20:59, Christian König wrote:
[CAUTION: External Email]
We are already doing this for DMA-buf imports and also for
amdgpu VM BOs for quite a while now.
If this doesn't run into any problems we are probably going
to stop removing BOs from the LRU altogether.
Signed-off-by: Chri
Sorry for late response.
Although we don't expect that, drm_syncobj_timeline_signal_ioctl already
handle this case I think. Which can handle both (point value > 0) and
(point value = 0).
-David
On 2019年05月21日 16:44, Lionel Landwerlin wrote:
[CAUTION: External Email]
Ping?
On 16/05/2019
ping, Could you help check in patch to gitlab? My connection to gitlab
still has problem.
Thanks,
-David
On 2019年05月16日 19:03, Zhou, David(ChunMing) wrote:
could you help push this patch as well?
Thanks,
-David
Original Message
Subject: Re: [PATCH libdrm] enable syncobj
On 2019年05月16日 18:09, Christian König wrote:
[CAUTION: External Email]
Am 16.05.19 um 10:16 schrieb zhoucm1:
I was able to push changes to libdrm, but now seems after libdrm is
migrated to gitlab, I cannot yet. What step do I need to get back my
permission? I already can login into gitlab
I was able to push changes to libdrm, but now seems after libdrm is
migrated to gitlab, I cannot yet. What step do I need to get back my
permission? I already can login into gitlab with old freedesktop account.
@Christian, Can you help submit this patch set to libdrm first?
Thanks,
-David
Thank you, Lionel.
-David
On 2019年05月14日 17:49, Lionel Landwerlin wrote:
[CAUTION: External Email]
With the small nits, patches 2 & 4 are : Reviewed-by: Lionel Landwerlin
The other patches are a bit amdgpu specific so maybe you might want
someone more familiar with amdgpu to review them.
Sti
ping... for patch set.
On 2019年05月13日 17:52, Chunming Zhou wrote:
[CAUTION: External Email]
Signed-off-by: Chunming Zhou
---
include/drm/amdgpu_drm.h | 9 +
1 file changed, 9 insertions(+)
diff --git a/include/drm/amdgpu_drm.h b/include/drm/amdgpu_drm.h
index d0701ffc..3d0318e6 10
On 2019年05月07日 19:13, Koenig, Christian wrote:
Am 07.05.19 um 13:08 schrieb zhoucm1:
On 2019年05月07日 18:53, Koenig, Christian wrote:
Am 07.05.19 um 11:36 schrieb Chunming Zhou:
heavy gpu job could occupy memory long time, which lead other user
fail to get memory.
basically pick up
On 2019年05月07日 18:53, Koenig, Christian wrote:
Am 07.05.19 um 11:36 schrieb Chunming Zhou:
heavy gpu job could occupy memory long time, which lead other user fail to get
memory.
basically pick up Christian idea:
1. Reserve the BO in DC using a ww_mutex ticket (trivial).
2. If we then run in
On 2019年05月07日 17:03, Christian König wrote:
[CAUTION: External Email]
Ping!
in fact, already address your comments, just wait for Prike test result,
anyway, send v6 first.
-David
Marek is going to need this for its GDS patches as well.
Christina.
Am 30.04.19 um 11:10 schrieb Christian
please ignore v4. Will send v5 instead.
On 2019年04月26日 17:53, Chunming Zhou wrote:
heavy gpu job could occupy memory long time, which lead other user fail to get
memory.
basically pick up Christian idea:
1. Reserve the BO in DC using a ww_mutex ticket (trivial).
2. If we then run into this E
On 2019年04月26日 17:11, Koenig, Christian wrote:
Am 26.04.19 um 11:07 schrieb zhoucm1:
[SNIP]
+ spin_lock(&glob->lru_lock);
+ for (i = 0; i < TTM_MAX_BO_PRIORITY; ++i) {
+ if (list_empty(&man->lru[i]))
+ continue;
+ bo = list_first_
On 2019年04月26日 16:31, Christian König wrote:
Am 25.04.19 um 09:39 schrieb Chunming Zhou:
heavy gpu job could occupy memory long time, which lead other user
fail to get memory.
basically pick up Christian idea:
1. Reserve the BO in DC using a ww_mutex ticket (trivial).
Any reason you don't
On 2019年04月25日 03:22, Eric Anholt wrote:
"Zhou, David(ChunMing)" writes:
Will linux be only mesa-linux? I thought linux is an open linux.
Which will impact our opengl/amdvlk(MIT open source), not sure Rocm:
1. how to deal with one uapi that opengl/amdvlk needs but mesa dont need?
reject?
2
OK, Let's drop mine, then Could you draft a solution for that?
-David
On 2019年04月24日 16:59, Koenig, Christian wrote:
Am 24.04.19 um 10:11 schrieb zhoucm1:
On 2019年04月24日 16:07, Christian König wrote:
This is used in a work item, so you don't need to check for signals.
w
loop.
I already add a timeout for that.
-David
Christian.
Am 24.04.19 um 09:59 schrieb zhoucm1:
how about new attached?
-David
On 2019年04月24日 15:30, Christian König wrote:
That would change the semantics of ttm_bo_mem_space() and so could
change the return code in an IOCTL as well. Not a
check if you get an -ENOMEM
and then call schedule().
If after the schedule() we see that we have now BOs on the LRU we can
try again and see if pinning the frame buffer now succeeds.
Christian.
Am 24.04.19 um 09:17 schrieb zhoucm1:
I made a patch as attached.
I'm not sure how to
I made a patch as attached.
I'm not sure how to make patch as your proposal, Could you make a patch
for that if mine isn't enough?
-David
On 2019年04月24日 15:12, Christian König wrote:
how about just adding a wrapper for pin function as below?
I considered this as well and don't think it will
On 2019年04月01日 16:19, Lionel Landwerlin wrote:
On 01/04/2019 06:54, Zhou, David(ChunMing) wrote:
-Original Message-
From: Lionel Landwerlin
Sent: Saturday, March 30, 2019 10:09 PM
To: Koenig, Christian ; Zhou, David(ChunMing)
; dri-devel@lists.freedesktop.org; amd-
g...@lists.freede
quot;
Hi David,
For the cmpxchg() case I of hand don't know either. Looks like so far
nobody has used cmpxchg() with rcu protected structures.
The other cases should be replaced by RCU_INIT_POINTER() or
rcu_dereference_protected(.., true);
Regards,
Christian.
Am 21.03.19 um 07:34 schrieb
Hi Lionel and Christian,
Below is robot report for chain->prev, which was added __rcu as you
suggested.
How to fix this line "tmp = cmpxchg(&chain->prev, prev, replacement); "?
I checked kernel header file, seems it has no cmpxchg for rcu.
Any suggestion to fix this robot report?
Thanks,
-Da
On 2019年03月19日 19:54, Lionel Landwerlin wrote:
On 15/03/2019 12:09, Chunming Zhou wrote:
v2: individually allocate chain array, since chain node is free
independently.
v3: all existing points must be already signaled before cpu perform
signal operation,
so add check condition for that.
On 2019年02月20日 15:59, Koenig, Christian wrote:
Am 20.02.19 um 05:53 schrieb zhoucm1:
On 2019年02月19日 19:32, Koenig, Christian wrote:
Hi David,
Could you have a look if it's reasonable?
Patch #1 is also something I already fixed on my local branch.
But patch #2 won't work
bmitted work to the hardware. And just dropping the fence
like you do in the patch is a clearly no-go as well.
Then do you have any idea to skip the messed order signal point?
-David
Regards,
Christian.
Am 19.02.19 um 11:46 schrieb zhoucm1:
Hi Lionel,
the attached should fix your problem
Hi Lionel,
the attached should fix your problem and also messed signal order.
Hi Christian,
Could you have a look if it's reasonable?
btw: I pushed to change to
https://github.com/amingriyue/timeline-syncobj-kernel, which is already
rebased to latest drm-misc(kernel 5.0). You can directly u
Hi Lionel,
I checked your igt test case,
uint64_t points[5] = { 1, 5, 3, 7, 6 };
which is illegal signal order.
I must admit we should handle it gracefully if signal isn't in-order,
and we shouldn't lead to deadlock.
Hi Christian,
Can we just ignore when signal point X <= timeline Y? Or ju
On 2019年02月17日 03:22, Christian König wrote:
Am 15.02.19 um 20:31 schrieb Lionel Landwerlin via amd-gfx:
On 07/12/2018 09:55, Chunming Zhou wrote:
user mode can query timeline payload.
v2: check return value of copy_to_user
v3: handle querying entry by entry
v4: rebase on new chain container,
On 2019年01月11日 21:15, Christian König wrote:
Move the BO on the LRU only when it is actually moved by a DMA
operation.
Signed-off-by: Christian König
Tested-And-Reviewed-by: Chunming Zhou
I just sent lru_notify v2 patches, please review them. With yours and
mine, the OOM issue is fixed w
On 2018年12月04日 14:39, Wei Yongjun wrote:
Fix the return value check which testing the wrong variable
in amdgpu_allocate_static_csa().
Fixes: 7946340fa389 ("drm/amdgpu: Move csa related code to separate file")
Signed-off-by: Wei Yongjun
---
drivers/gpu/drm/amd/amdgpu/amdgpu_csa.c | 2 +-
1
On 2018年11月28日 22:50, Christian König wrote:
Lockless container implementation similar to a dma_fence_array, but with
only two elements per node and automatic garbage collection.
v2: properly document dma_fence_chain_for_each, add dma_fence_chain_find_seqno,
drop prev reference during gar
Could you move this one to dma-fence as you said? Which will be used in
other place as well.
-David
On 2018年11月28日 22:50, Christian König wrote:
Extract of useful code from the timeline work. Let's use just a single
stub fence instance instead of allocating a new one all the time.
Signed-off
On 2018年11月28日 22:50, Christian König wrote:
From: Chunming Zhou
v2: symbos are stored in lexical order.
v3: drop export/import and extra query indirection
Signed-off-by: Chunming Zhou
Signed-off-by: Christian König
---
amdgpu/amdgpu-symbol-check | 2 ++
amdgpu/amdgpu.h| 39
Looks very very good, and I applied them in my local, and tested by
./amdgpu_test -s 9 and synobj_basic/wait of IGT today.
+Daniel, Chris, Eric, Could you also have a look as well?
-David
On 2018年11月28日 22:50, Christian König wrote:
Tested this patch set more extensively in the last two we
On 2018年11月28日 22:50, Christian König wrote:
From: Chunming Zhou
v2: drop export/import
Signed-off-by: Chunming Zhou
---
xf86drm.c | 44
xf86drm.h | 8
2 files changed, 52 insertions(+)
diff --git a/xf86drm.c b/xf86drm.c
index 71ad
On 2018年11月28日 22:50, Christian König wrote:
For a lot of use cases we need 64bit sequence numbers. Currently drivers
overload the dma_fence structure to store the additional bits.
Stop doing that and make the sequence number in the dma_fence always
64bit.
For compatibility with hardware whic
On 2018年11月23日 18:10, Koenig, Christian wrote:
Am 23.11.18 um 03:36 schrieb zhoucm1:
On 2018年11月22日 19:30, Christian König wrote:
Am 22.11.18 um 07:52 schrieb zhoucm1:
On 2018年11月15日 19:12, Christian König wrote:
Implement finding the right timeline point in drm_syncobj_find_fence
On 2018年11月22日 19:30, Christian König wrote:
Am 22.11.18 um 07:52 schrieb zhoucm1:
On 2018年11月15日 19:12, Christian König wrote:
Implement finding the right timeline point in drm_syncobj_find_fence.
Signed-off-by: Christian König
---
drivers/gpu/drm/drm_syncobj.c | 10 +-
1
On 2018年11月15日 19:12, Christian König wrote:
Implement finding the right timeline point in drm_syncobj_find_fence.
Signed-off-by: Christian König
---
drivers/gpu/drm/drm_syncobj.c | 10 +-
1 file changed, 9 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/drm_syncobj.c b/
On 2018年11月12日 18:16, Christian König wrote:
Am 09.11.18 um 23:26 schrieb Eric Anholt:
Eric Anholt writes:
[ Unknown signature status ]
zhoucm1 writes:
On 2018年11月09日 00:52, Christian König wrote:
Am 08.11.18 um 17:07 schrieb Koenig, Christian:
Am 08.11.18 um 17:04 schrieb Eric Anholt
On 2018年11月12日 18:48, Chris Wilson wrote:
Quoting Christian König (2018-11-12 10:16:01)
Am 09.11.18 um 23:26 schrieb Eric Anholt:
Eric Anholt writes:
[ Unknown signature status ]
zhoucm1 writes:
On 2018年11月09日 00:52, Christian König wrote
On 2018年11月12日 18:16, Christian König wrote:
Am 09.11.18 um 23:26 schrieb Eric Anholt:
Eric Anholt writes:
[ Unknown signature status ]
zhoucm1 writes:
On 2018年11月09日 00:52, Christian König wrote:
Am 08.11.18 um 17:07 schrieb Koenig, Christian:
Am 08.11.18 um 17:04 schrieb Eric Anholt
On 2018年11月09日 00:52, Christian König wrote:
Am 08.11.18 um 17:07 schrieb Koenig, Christian:
Am 08.11.18 um 17:04 schrieb Eric Anholt:
Daniel suggested I submit this, since we're still seeing regressions
from it. This is a revert to before 48197bc564c7 ("drm: add syncobj
timeline support v9"
On 2018年11月02日 17:54, Koenig, Christian wrote:
Am 02.11.18 um 10:42 schrieb zhoucm1:
On 2018年11月02日 16:46, Christian König wrote:
Am 02.11.18 um 09:25 schrieb Chunming Zhou:
user space can specify timeline point fence to export/import.
Signed-off-by: Chunming Zhou
Cc: Daniel Rakos
Cc
On 2018年11月02日 16:46, Christian König wrote:
Am 02.11.18 um 09:25 schrieb Chunming Zhou:
user space can specify timeline point fence to export/import.
Signed-off-by: Chunming Zhou
Cc: Daniel Rakos
Cc: Jason Ekstrand
Cc: Bas Nieuwenhuizen
Cc: Dave Airlie
Cc: Christian König
Cc: Chris Wil
On 2018年10月31日 20:07, Chris Wilson wrote:
drivers/gpu/drm/drm_syncobj.c:181:6: warning: no previous prototype for
‘drm_syncobj_add_callback’ [-Wmissing-prototypes]
drivers/gpu/drm/drm_syncobj.c:190:6: warning: no previous prototype for
‘drm_syncobj_remove_callback’ [-Wmissing-prototypes]
Fix
On 2018年10月26日 16:32, Daniel Vetter wrote:
On Fri, Oct 26, 2018 at 5:50 AM Zhou, David(ChunMing)
wrote:
Make igt for cross-driver, I think you should rename it first, not an intel
specific. NO company wants their employee working on other company stuff.
You can rename it to DGT(drm graphics
Thanks, Could you help to submit to drm-misc again?
-David
On 2018年10月26日 15:43, Christian König wrote:
Am 26.10.18 um 08:20 schrieb Chunming Zhou:
drivers/gpu/drm/drm_syncobj.c:202:4-14: ERROR: function
drm_syncobj_find_signal_pt_for_point called on line 390 inside lock
on line 389 but uses
On 2018年10月25日 17:38, Christian König wrote:
Am 25.10.18 um 11:35 schrieb Daniel Vetter:
On Thu, Oct 25, 2018 at 04:36:34PM +0800, Chunming Zhou wrote:
drivers/gpu/drm/drm_syncobj.c:202:4-14: ERROR: function
drm_syncobj_find_signal_pt_for_point called on line 390 inside lock
on line 389 but
On 2018年10月25日 17:30, Koenig, Christian wrote:
Am 25.10.18 um 11:28 schrieb zhoucm1:
On 2018年10月25日 17:23, Koenig, Christian wrote:
Am 25.10.18 um 11:20 schrieb zhoucm1:
On 2018年10月25日 17:11, Koenig, Christian wrote:
Am 25.10.18 um 11:03 schrieb zhoucm1:
On 2018年10月25日 16:56
On 2018年10月25日 17:23, Koenig, Christian wrote:
Am 25.10.18 um 11:20 schrieb zhoucm1:
On 2018年10月25日 17:11, Koenig, Christian wrote:
Am 25.10.18 um 11:03 schrieb zhoucm1:
On 2018年10月25日 16:56, Christian König wrote:
+++ b/drivers/gpu/drm/drm_syncobj.c
@@ -111,15 +111,16 @@ static
On 2018年10月25日 17:11, Koenig, Christian wrote:
Am 25.10.18 um 11:03 schrieb zhoucm1:
On 2018年10月25日 16:56, Christian König wrote:
+++ b/drivers/gpu/drm/drm_syncobj.c
@@ -111,15 +111,16 @@ static struct dma_fence
uint64_t point)
{
struct
On 2018年10月25日 16:56, Christian König wrote:
+++ b/drivers/gpu/drm/drm_syncobj.c
@@ -111,15 +111,16 @@ static struct dma_fence
uint64_t point)
{
struct drm_syncobj_signal_pt *signal_pt;
+ struct dma_fence *f = NULL;
+ struct drm_syncobj_stub_fence *fence =
pls ignore this one, please review v2.
On 2018年10月25日 16:36, Chunming Zhou wrote:
drivers/gpu/drm/drm_syncobj.c:202:4-14: ERROR: function
drm_syncobj_find_signal_pt_for_point called on line 390 inside lock on line 389
but uses GFP_KERNEL
Find functions that refer to GFP_KERNEL but are ca
will send a fix soon.
Thanks,
David
On 2018年10月25日 15:57, Koenig, Christian wrote:
Am 25.10.18 um 09:51 schrieb Maarten Lankhorst:
Op 25-10-18 om 08:53 schreef Christian König:
Am 25.10.18 um 03:28 schrieb Zhou, David(ChunMing):
Reviewed-by: Chunming Zhou
NAK, GFP_ATOMIC should be avoid
On 2018年10月23日 17:01, Chris Wilson wrote:
Quoting Chunming Zhou (2018-10-23 08:57:54)
v2:
add a mutex between sync_cb execution and free.
v3:
clearly separating the roles for pt_lock and cb_mutex (Chris)
v4:
the cb_mutex should be taken outside of the pt_lock around this if() block.
(Chris)
v
On 2018年10月23日 15:51, Chris Wilson wrote:
Quoting Chunming Zhou (2018-10-23 02:50:08)
v2:
add a mutex between sync_cb execution and free.
v3:
clearly separating the roles for pt_lock and cb_mutex (Chris)
v4:
the cb_mutex should be taken outside of the pt_lock around this if() block.
(Chris)
On 2018年10月22日 16:34, Chris Wilson wrote:
Quoting Chunming Zhou (2018-10-21 12:14:24)
v2:
add a mutex between sync_cb execution and free.
The result would appear to be that syncobj->lock is relegated to
protecting the pt_list and the mutex would only be needed for the
syncobj->cb_list.
The p
On 2018年10月19日 20:08, Koenig, Christian wrote:
Am 19.10.18 um 14:01 schrieb zhoucm1:
On 2018年10月19日 19:26, zhoucm1 wrote:
On 2018年10月19日 18:50, Chris Wilson wrote:
Quoting Chunming Zhou (2018-10-19 11:26:41)
Signed-off-by: Chunming Zhou
Cc: Daniel Vetter
Cc: Chris Wilson
Cc: Christian
On 2018年10月19日 19:26, zhoucm1 wrote:
On 2018年10月19日 18:50, Chris Wilson wrote:
Quoting Chunming Zhou (2018-10-19 11:26:41)
Signed-off-by: Chunming Zhou
Cc: Daniel Vetter
Cc: Chris Wilson
Cc: Christian König
---
drivers/gpu/drm/drm_syncobj.c | 7 +--
1 file changed, 5 insertions
On 2018年10月19日 18:50, Chris Wilson wrote:
Quoting Chunming Zhou (2018-10-19 11:26:41)
Signed-off-by: Chunming Zhou
Cc: Daniel Vetter
Cc: Chris Wilson
Cc: Christian König
---
drivers/gpu/drm/drm_syncobj.c | 7 +--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/drivers/
[snip]
Went boom:
https://bugs.freedesktop.org/show_bug.cgi?id=108490
Can we revert pls?
Sorry for bug, please.
In fact, the bug is already caught and fixed, just the fix part isn't
in patch#1, but in patch#2:
Have you reverted? If not, I can send that fix in one minute.
Regards,
David Z
On 2018年10月19日 17:20, zhoucm1 wrote:
On 2018年10月19日 16:55, Daniel Vetter wrote:
On Fri, Oct 19, 2018 at 10:29:55AM +0800, zhoucm1 wrote:
On 2018年10月18日 19:50, Christian König wrote:
Am 18.10.18 um 05:11 schrieb zhoucm1:
On 2018年10月17日 18:24, Daniel Vetter wrote:
On Wed, Oct 17, 2018
On 2018年10月19日 16:55, Daniel Vetter wrote:
On Fri, Oct 19, 2018 at 10:29:55AM +0800, zhoucm1 wrote:
On 2018年10月18日 19:50, Christian König wrote:
Am 18.10.18 um 05:11 schrieb zhoucm1:
On 2018年10月17日 18:24, Daniel Vetter wrote:
On Wed, Oct 17, 2018 at 11:29 AM Koenig, Christian
wrote:
Am
On 2018年10月18日 19:50, Christian König wrote:
Am 18.10.18 um 05:11 schrieb zhoucm1:
On 2018年10月17日 18:24, Daniel Vetter wrote:
On Wed, Oct 17, 2018 at 11:29 AM Koenig, Christian
wrote:
Am 17.10.18 um 11:17 schrieb zhoucm1:
[SNIP]
+struct drm_syncobj_signal_pt {
+ struct
On 2018年10月17日 18:24, Daniel Vetter wrote:
On Wed, Oct 17, 2018 at 11:29 AM Koenig, Christian
wrote:
Am 17.10.18 um 11:17 schrieb zhoucm1:
[SNIP]
+struct drm_syncobj_signal_pt {
+struct dma_fence_array *base;
Out of curiosity, why the pointer and not embedding? base is kinda
+Jason as well.
On 2018年10月17日 18:22, Daniel Vetter wrote:
On Wed, Oct 17, 2018 at 11:17 AM zhoucm1 wrote:
On 2018年10月17日 16:09, Daniel Vetter wrote:
On Mon, Oct 15, 2018 at 04:55:48PM +0800, Chunming Zhou wrote:
This patch is for VK_KHR_timeline_semaphore extension, semaphore is called
On 2018年10月17日 16:09, Daniel Vetter wrote:
On Mon, Oct 15, 2018 at 04:55:48PM +0800, Chunming Zhou wrote:
This patch is for VK_KHR_timeline_semaphore extension, semaphore is called
syncobj in kernel side:
This extension introduces a new type of syncobj that has an integer payload
identifying
On 2018年10月16日 20:54, Christian König wrote:
I've added my rb to patch #1 and pushed it to drm-misc-next.
I would really like to get an rb from other people on patch #2 before
proceeding.
Daniel, Dave and all the other usual suspects on the list what is your
opinion on this implementation?
...@lists.freedesktop.org
Cc: Dave Airlie ; Rakos, Daniel
; Daniel Vetter ; amd-
g...@lists.freedesktop.org
Subject: Re: [PATCH 1/4] [RFC]drm: add syncobj timeline support v6
Am 19.09.2018 um 09:32 schrieb zhoucm1:
On 2018年09月19日 15:18, Christian König wrote:
Am 19.09.2018 um 06:26 schrieb Chunming Zhou:
[snip
On 2018年09月19日 15:18, Christian König wrote:
Am 19.09.2018 um 06:26 schrieb Chunming Zhou:
[snip]
*fence = NULL;
drm_syncobj_add_callback_locked(syncobj, cb, func);
@@ -164,6 +177,153 @@ void drm_syncobj_remove_callback(struct
drm_syncobj *syncobj,
spin_unlock(&syn
On 2018年09月19日 15:18, Christian König wrote:
Am 19.09.2018 um 06:26 schrieb Chunming Zhou:
[snip]
*fence = NULL;
drm_syncobj_add_callback_locked(syncobj, cb, func);
@@ -164,6 +177,153 @@ void drm_syncobj_remove_callback(struct
drm_syncobj *syncobj,
spin_unlock(&syn
On 2018年09月18日 16:32, Christian König wrote:
+ for (i = 0; i < args->count_handles; i++) {
+ if (syncobjs[i]->type == DRM_SYNCOBJ_TYPE_TIMELINE) {
+ DRM_ERROR("timeline syncobj cannot reset!\n");
Why not? I mean that should still work or do I miss anything?
timeline semap
On 2018年09月17日 16:37, Christian König wrote:
Am 14.09.2018 um 12:37 schrieb Chunming Zhou:
This patch is for VK_KHR_timeline_semaphore extension, semaphore is
called syncobj in kernel side:
This extension introduces a new type of syncobj that has an integer
payload
identifying a point in a t
PM
To: Zhou, David(ChunMing) ; Zhou,
David(ChunMing) ; dri-
de...@lists.freedesktop.org
Cc: Dave Airlie ; Rakos, Daniel
; amd-...@lists.freedesktop.org
Subject: Re: [PATCH 1/3] [RFC]drm: add syncobj timeline support v4
Am 13.09.2018 um 04:15 schrieb zhoucm1:
On 2018年09月12日 19:05, Christian König
On 2018年09月14日 11:14, zhoucm1 wrote:
On 2018年09月13日 18:22, Christian König wrote:
Am 13.09.2018 um 11:35 schrieb Zhou, David(ChunMing):
-Original Message-
From: Koenig, Christian
Sent: Thursday, September 13, 2018 5:20 PM
To: Zhou, David(ChunMing) ; dri-
de
On 2018年09月12日 19:05, Christian König wrote:
Am 12.09.2018 um 12:20 schrieb zhoucm1:
[SNIP]
Drop the term semaphore here, better use syncobj.
This is from VK_KHR_timeline_semaphore extension describe, not my
invention, I just quote it. In kernel side, we call syncobj, in UMD,
they still
On 2018年09月12日 15:22, Christian König wrote:
Ping? Have you seen my comments here?
Sorry, I didn't see this reply. inline...
Looks like you haven't addressed any of them in your last mail.
Christian.
Am 06.09.2018 um 09:25 schrieb Christian König:
Am 06.09.2018 um 08:25 schrieb Chunming
On 2018年09月04日 17:20, Christian König wrote:
Am 04.09.2018 um 11:00 schrieb zhoucm1:
On 2018年09月04日 16:42, Christian König wrote:
Am 04.09.2018 um 10:27 schrieb zhoucm1:
On 2018年09月04日 16:05, Christian König wrote:
Am 04.09.2018 um 09:53 schrieb zhoucm1:
[SNIP]
How about this idea
On 2018年09月04日 16:42, Christian König wrote:
Am 04.09.2018 um 10:27 schrieb zhoucm1:
On 2018年09月04日 16:05, Christian König wrote:
Am 04.09.2018 um 09:53 schrieb zhoucm1:
[SNIP]
How about this idea:
1. Each signaling point is a fence implementation with an rb node.
2. Each node keeps a
On 2018年09月04日 16:05, Christian König wrote:
Am 04.09.2018 um 09:53 schrieb zhoucm1:
[SNIP]
How about this idea:
1. Each signaling point is a fence implementation with an rb node.
2. Each node keeps a reference to the last previously inserted node.
3. Each node is referenced by the sync
On 2018年09月04日 15:00, Christian König wrote:
Am 04.09.2018 um 06:04 schrieb zhoucm1:
On 2018年09月03日 19:19, Christian König wrote:
Am 03.09.2018 um 12:07 schrieb Chunming Zhou:
在 2018/9/3 16:50, Christian König 写道:
Am 03.09.2018 um 06:13 schrieb Chunming Zhou:
在 2018/8/30 19:32
On 2018年09月03日 19:19, Christian König wrote:
Am 03.09.2018 um 12:07 schrieb Chunming Zhou:
在 2018/9/3 16:50, Christian König 写道:
Am 03.09.2018 um 06:13 schrieb Chunming Zhou:
在 2018/8/30 19:32, Christian König 写道:
[SNIP]
+
+struct drm_syncobj_wait_pt {
+ struct drm_syncobj_stub_fe
On 2018年08月30日 15:25, Christian König wrote:
Am 30.08.2018 um 05:50 schrieb zhoucm1:
On 2018年08月29日 19:42, Christian König wrote:
Am 29.08.2018 um 12:44 schrieb Chunming Zhou:
VK_KHR_timeline_semaphore:
This extension introduces a new type of semaphore that has an
integer payload
On 2018年08月29日 19:42, Christian König wrote:
Am 29.08.2018 um 12:44 schrieb Chunming Zhou:
VK_KHR_timeline_semaphore:
This extension introduces a new type of semaphore that has an integer
payload
identifying a point in a timeline. Such timeline semaphores support the
following operations:
On 2018年08月23日 17:15, Christian König wrote:
Am 23.08.2018 um 10:25 schrieb Chunming Zhou:
VK_KHR_timeline_semaphore:
This extension introduces a new type of semaphore that has an integer
payload
identifying a point in a timeline. Such timeline semaphores support the
following operations:
On 2018年08月23日 17:08, Daniel Vetter wrote:
On Thu, Aug 23, 2018 at 04:25:42PM +0800, Chunming Zhou wrote:
VK_KHR_timeline_semaphore:
This extension introduces a new type of semaphore that has an integer payload
identifying a point in a timeline. Such timeline semaphores support the
following o
On 2018年08月22日 17:31, Daniel Vetter wrote:
On Wed, Aug 22, 2018 at 05:28:17PM +0800, zhoucm1 wrote:
On 2018年08月22日 17:24, Daniel Vetter wrote:
On Wed, Aug 22, 2018 at 04:49:28PM +0800, Chunming Zhou wrote:
VK_KHR_timeline_semaphore:
This extension introduces a new type of semaphore that
1 - 100 of 170 matches
Mail list logo
