Re: [Intel-gfx] [PATCH] drm/i915/gt: Use the correct error value when kernel_context() fails

2023-06-01 Thread Andrzej Hajda
On 26.05.2023 14:41, Andi Shyti wrote: kernel_context() returns an error pointer. Use pointer-error conversion functions to evaluate its return value, rather than checking for a '0' return. Fixes: eb5c10cbbc2f ("drm/i915: Remove I915_USER_PRIORITY_SHIFT") Reported-by: Dan Carpenter Signed-off-b

Re: [Intel-gfx] [PATCH] drm/i915/gt: Use the correct error value when kernel_context() fails

2023-06-01 Thread Andi Shyti
Hi Tejas, > > > @@ -1530,8 +1530,8 @@ static int live_busywait_preempt(void *arg) > > > struct drm_i915_gem_object *obj; > > > struct i915_vma *vma; > > > enum intel_engine_id id; > > > - int err = -ENOMEM; > > > u32 *map; > > > + int err; > > We could init

RE: [Intel-gfx] [PATCH] drm/i915/gt: Use the correct error value when kernel_context() fails

2023-06-01 Thread Upadhyay, Tejas
ect: Re: [Intel-gfx] [PATCH] drm/i915/gt: Use the correct error value > when kernel_context() fails > > On 26.05.2023 14:41, Andi Shyti wrote: > > kernel_context() returns an error pointer. Use pointer-error > > conversion functions to evaluate its return value, rather t