Re: [Intel-gfx] [PATCH] drm/i915: Lock timeline mutex directly in error path of eb_pin_timeline

2022-01-06 Thread Matthew Brost
On Thu, Jan 06, 2022 at 04:51:21PM +, Tvrtko Ursulin wrote: > > On 06/01/2022 16:18, Matthew Brost wrote: > > On Thu, Jan 06, 2022 at 09:56:03AM +, Tvrtko Ursulin wrote: > > > > > > On 05/01/2022 16:24, Matthew Brost wrote: > > > > On Wed, Jan 05, 2022 at 09:35:44AM +, Tvrtko Ursulin

Re: [Intel-gfx] [PATCH] drm/i915: Lock timeline mutex directly in error path of eb_pin_timeline

2022-01-06 Thread Tvrtko Ursulin
On 06/01/2022 16:18, Matthew Brost wrote: On Thu, Jan 06, 2022 at 09:56:03AM +, Tvrtko Ursulin wrote: On 05/01/2022 16:24, Matthew Brost wrote: On Wed, Jan 05, 2022 at 09:35:44AM +, Tvrtko Ursulin wrote: On 04/01/2022 23:30, Matthew Brost wrote: Don't use the interruptable version

Re: [Intel-gfx] [PATCH] drm/i915: Lock timeline mutex directly in error path of eb_pin_timeline

2022-01-06 Thread Matthew Brost
On Thu, Jan 06, 2022 at 09:56:03AM +, Tvrtko Ursulin wrote: > > On 05/01/2022 16:24, Matthew Brost wrote: > > On Wed, Jan 05, 2022 at 09:35:44AM +, Tvrtko Ursulin wrote: > > > > > > On 04/01/2022 23:30, Matthew Brost wrote: > > > > Don't use the interruptable version of the timeline mutex

Re: [Intel-gfx] [PATCH] drm/i915: Lock timeline mutex directly in error path of eb_pin_timeline

2022-01-06 Thread Tvrtko Ursulin
On 05/01/2022 16:24, Matthew Brost wrote: On Wed, Jan 05, 2022 at 09:35:44AM +, Tvrtko Ursulin wrote: On 04/01/2022 23:30, Matthew Brost wrote: Don't use the interruptable version of the timeline mutex lock in the interruptible error path of eb_pin_timeline as the cleanup must always

Re: [Intel-gfx] [PATCH] drm/i915: Lock timeline mutex directly in error path of eb_pin_timeline

2022-01-05 Thread Matthew Brost
On Wed, Jan 05, 2022 at 09:35:44AM +, Tvrtko Ursulin wrote: > > On 04/01/2022 23:30, Matthew Brost wrote: > > Don't use the interruptable version of the timeline mutex lock in the > > interruptible > > > error path of eb_pin_timeline as the cleanup must always happen. > > > > v2: > > (Joh

Re: [Intel-gfx] [PATCH] drm/i915: Lock timeline mutex directly in error path of eb_pin_timeline

2022-01-05 Thread Tvrtko Ursulin
On 04/01/2022 23:30, Matthew Brost wrote: Don't use the interruptable version of the timeline mutex lock in the interruptible error path of eb_pin_timeline as the cleanup must always happen. v2: (John Harrison) - Don't check for interrupt during mutex lock Fixes: 544460c33821 ("drm/i