Re: [Intel-gfx] [PATCH 02/12] drm/i915/guc: Don't call ring_is_idle in GuC submission

2022-07-19 Thread Tvrtko Ursulin
On 19/07/2022 10:49, Tvrtko Ursulin wrote: On 19/07/2022 01:09, John Harrison wrote: On 7/18/2022 05:26, Tvrtko Ursulin wrote: On 13/07/2022 00:31, john.c.harri...@intel.com wrote: From: Matthew Brost The engine registers really shouldn't be touched during GuC submission as the GuC owns

Re: [Intel-gfx] [PATCH 02/12] drm/i915/guc: Don't call ring_is_idle in GuC submission

2022-07-19 Thread Tvrtko Ursulin
On 19/07/2022 01:09, John Harrison wrote: On 7/18/2022 05:26, Tvrtko Ursulin wrote: On 13/07/2022 00:31, john.c.harri...@intel.com wrote: From: Matthew Brost The engine registers really shouldn't be touched during GuC submission as the GuC owns the registers. Don't call ring_is_idle and

Re: [Intel-gfx] [PATCH 02/12] drm/i915/guc: Don't call ring_is_idle in GuC submission

2022-07-18 Thread John Harrison
On 7/18/2022 05:26, Tvrtko Ursulin wrote: On 13/07/2022 00:31, john.c.harri...@intel.com wrote: From: Matthew Brost The engine registers really shouldn't be touched during GuC submission as the GuC owns the registers. Don't call ring_is_idle and tie Touch being just read and it is somehow

Re: [Intel-gfx] [PATCH 02/12] drm/i915/guc: Don't call ring_is_idle in GuC submission

2022-07-18 Thread Tvrtko Ursulin
On 13/07/2022 00:31, john.c.harri...@intel.com wrote: From: Matthew Brost The engine registers really shouldn't be touched during GuC submission as the GuC owns the registers. Don't call ring_is_idle and tie Touch being just read and it is somehow harmful? intel_engine_is_idle strictly