Re: [Intel-gfx] [PATCH 3/4] drm/i915: Add helpers for managing rps thresholds

2023-05-23 Thread Andi Shyti
Hi Tvrtko, > > > + /* Force reset. */ > > > + rps->last_freq = -1; > > > + mutex_lock(>power.mutex); > > > + rps->power.mode = -1; > > > + mutex_unlock(>power.mutex); > > > + > > > + intel_rps_set(rps, clamp(rps->cur_freq, > > > + rps->min_freq_softlimit, > > > +

Re: [Intel-gfx] [PATCH 3/4] drm/i915: Add helpers for managing rps thresholds

2023-05-23 Thread Tvrtko Ursulin
On 23/05/2023 00:09, Andi Shyti wrote: Hi Tvrtko, On Mon, May 22, 2023 at 12:59:27PM +0100, Tvrtko Ursulin wrote: From: Tvrtko Ursulin In preparation for exposing via sysfs add helpers for managing rps thresholds. v2: * Force sw and hw re-programming on threshold change. Signed-off-by:

Re: [Intel-gfx] [PATCH 3/4] drm/i915: Add helpers for managing rps thresholds

2023-05-22 Thread Andi Shyti
Hi Tvrtko, On Mon, May 22, 2023 at 12:59:27PM +0100, Tvrtko Ursulin wrote: > From: Tvrtko Ursulin > > In preparation for exposing via sysfs add helpers for managing rps > thresholds. > > v2: > * Force sw and hw re-programming on threshold change. > > Signed-off-by: Tvrtko Ursulin > Cc: