[Intel-gfx] [PATCH 4/7] drm/i915: Let panel power sequencing hardware do its job

2011-11-03 Thread Keith Packard
On Thu, 3 Nov 2011 12:57:08 -0700, Jesse Barnes wrote: > Modulo what we already discussed on irc about the PP_READY bit, and the Right, the PP_READY bit requires that everything needed for PCH eDP be running, even when you're using a CPU connected eDP panel, and so it's not actually useful. >

[Intel-gfx] [PATCH 4/7] drm/i915: Let panel power sequencing hardware do its job

2011-11-03 Thread Jesse Barnes
On Tue, 1 Nov 2011 23:20:27 -0700 Keith Packard wrote: > The panel power sequencing hardware tracks the stages of panel power > sequencing and signals when the panel is completely on or off. Instead > of blindly assuming the panel timings will work, poll the panel power > status register until

Re: [Intel-gfx] [PATCH 4/7] drm/i915: Let panel power sequencing hardware do its job

2011-11-03 Thread Jesse Barnes
On Tue, 1 Nov 2011 23:20:27 -0700 Keith Packard kei...@keithp.com wrote: The panel power sequencing hardware tracks the stages of panel power sequencing and signals when the panel is completely on or off. Instead of blindly assuming the panel timings will work, poll the panel power status

Re: [Intel-gfx] [PATCH 4/7] drm/i915: Let panel power sequencing hardware do its job

2011-11-03 Thread Keith Packard
On Thu, 3 Nov 2011 12:57:08 -0700, Jesse Barnes jbar...@virtuousgeek.org wrote: Modulo what we already discussed on irc about the PP_READY bit, and the Right, the PP_READY bit requires that everything needed for PCH eDP be running, even when you're using a CPU connected eDP panel, and so it's

[Intel-gfx] [PATCH 4/7] drm/i915: Let panel power sequencing hardware do its job

2011-11-02 Thread Keith Packard
On Wed, 2 Nov 2011 09:23:10 -0700, Jesse Barnes wrote: > Note that PP_READY will incorrectly depend on some other register > values, so in some configs the panel will happily power up even if > PP_READY isn't set yet... Here's the new version of that chunk: @@ -906,32 +905,56 @@

[Intel-gfx] [PATCH 4/7] drm/i915: Let panel power sequencing hardware do its job

2011-11-02 Thread Keith Packard
On Wed, 2 Nov 2011 09:23:10 -0700, Jesse Barnes wrote: > Note that PP_READY will incorrectly depend on some other register > values, so in some configs the panel will happily power up even if > PP_READY isn't set yet... Yeah, I'd like to understand why PP_READY isn't getting set; we should

[Intel-gfx] [PATCH 4/7] drm/i915: Let panel power sequencing hardware do its job

2011-11-02 Thread Jesse Barnes
On Wed, 02 Nov 2011 00:31:40 -0700 Keith Packard wrote: > On Tue, 1 Nov 2011 23:20:27 -0700, Keith Packard > wrote: > > > -static void ironlake_wait_panel_off(struct intel_dp *intel_dp) > > +#define IDLE_ON_MASK (PP_ON | PP_READY | PP_SEQUENCE_MASK | > > 0

Re: [Intel-gfx] [PATCH 4/7] drm/i915: Let panel power sequencing hardware do its job

2011-11-02 Thread Jesse Barnes
On Wed, 02 Nov 2011 00:31:40 -0700 Keith Packard kei...@keithp.com wrote: On Tue, 1 Nov 2011 23:20:27 -0700, Keith Packard kei...@keithp.com wrote: -static void ironlake_wait_panel_off(struct intel_dp *intel_dp) +#define IDLE_ON_MASK (PP_ON | PP_READY | PP_SEQUENCE_MASK |

Re: [Intel-gfx] [PATCH 4/7] drm/i915: Let panel power sequencing hardware do its job

2011-11-02 Thread Keith Packard
On Wed, 2 Nov 2011 09:23:10 -0700, Jesse Barnes jbar...@virtuousgeek.org wrote: Note that PP_READY will incorrectly depend on some other register values, so in some configs the panel will happily power up even if PP_READY isn't set yet... Yeah, I'd like to understand why PP_READY isn't