Re: [Intel-gfx] [PATCH 7/8] drm/mipi-dbi: Remove ->enabled

2020-06-24 Thread Daniel Vetter
On Tue, Jun 16, 2020 at 07:16:45PM +0200, Daniel Vetter wrote: > On Tue, Jun 16, 2020 at 3:57 PM Emil Velikov wrote: > > > > On Tue, 16 Jun 2020 at 07:50, Daniel Vetter wrote: > > > > > > On Mon, Jun 15, 2020 at 11:35 PM Emil Velikov > > > wrote: > > > > > > > > Hi Daniel, > > > > > > > > On Fr

Re: [Intel-gfx] [PATCH 7/8] drm/mipi-dbi: Remove ->enabled

2020-06-16 Thread Daniel Vetter
On Tue, Jun 16, 2020 at 3:57 PM Emil Velikov wrote: > > On Tue, 16 Jun 2020 at 07:50, Daniel Vetter wrote: > > > > On Mon, Jun 15, 2020 at 11:35 PM Emil Velikov > > wrote: > > > > > > Hi Daniel, > > > > > > On Fri, 12 Jun 2020 at 17:01, Daniel Vetter > > > wrote: > > > > > > > > The atomic he

Re: [Intel-gfx] [PATCH 7/8] drm/mipi-dbi: Remove ->enabled

2020-06-16 Thread Emil Velikov
On Tue, 16 Jun 2020 at 07:50, Daniel Vetter wrote: > > On Mon, Jun 15, 2020 at 11:35 PM Emil Velikov > wrote: > > > > Hi Daniel, > > > > On Fri, 12 Jun 2020 at 17:01, Daniel Vetter wrote: > > > > > > The atomic helpers try really hard to not lose track of things, > > > duplicating enabled track

Re: [Intel-gfx] [PATCH 7/8] drm/mipi-dbi: Remove ->enabled

2020-06-15 Thread Daniel Vetter
On Mon, Jun 15, 2020 at 11:35 PM Emil Velikov wrote: > > Hi Daniel, > > On Fri, 12 Jun 2020 at 17:01, Daniel Vetter wrote: > > > > The atomic helpers try really hard to not lose track of things, > > duplicating enabled tracking in the driver is at best confusing. > > Double-enabling or disabling

Re: [Intel-gfx] [PATCH 7/8] drm/mipi-dbi: Remove ->enabled

2020-06-15 Thread Emil Velikov
Hi Daniel, On Fri, 12 Jun 2020 at 17:01, Daniel Vetter wrote: > > The atomic helpers try really hard to not lose track of things, > duplicating enabled tracking in the driver is at best confusing. > Double-enabling or disabling is a bug in atomic helpers. > > In the fb_dirty function we can just