[Beignet] [Intel-gfx] [PATCH i-g-t v3] tests/core_getparams: Create new test core_getparams

2015-03-13 Thread Daniel Vetter
On Fri, Mar 13, 2015 at 09:51:57AM -0700, Jeff McGee wrote: > On Fri, Mar 13, 2015 at 05:32:41PM +0100, Daniel Vetter wrote: > > On Fri, Mar 13, 2015 at 05:09:46PM +0800, Zhigang Gong wrote: > > > My only concern is about the following macros: > > > > > > > +#define

[Intel-gfx] [PATCH i-g-t v3] tests/core_getparams: Create new test core_getparams

2015-03-13 Thread Daniel Vetter
On Fri, Mar 13, 2015 at 05:09:46PM +0800, Zhigang Gong wrote: > My only concern is about the following macros: > > > +#define LOCAL_I915_PARAM_SUBSLICE_TOTAL 33 > > +#define LOCAL_I915_PARAM_EU_TOTAL34 > > How about to just use the definitons in the kernel header file? > For an example:

[Intel-gfx] [PATCH i-g-t v3] tests/core_getparams: Create new test core_getparams

2015-03-13 Thread Zhigang Gong
My only concern is about the following macros: > +#define LOCAL_I915_PARAM_SUBSLICE_TOTAL 33 > +#define LOCAL_I915_PARAM_EU_TOTAL34 How about to just use the definitons in the kernel header file? For an example: #include #ifdef LOCAL_I915_PARAM_SUBSLICE_TOTAL //Put all the code

[Beignet] [Intel-gfx] [PATCH i-g-t v3] tests/core_getparams: Create new test core_getparams

2015-03-13 Thread Jeff McGee
On Fri, Mar 13, 2015 at 05:32:41PM +0100, Daniel Vetter wrote: > On Fri, Mar 13, 2015 at 05:09:46PM +0800, Zhigang Gong wrote: > > My only concern is about the following macros: > > > > > +#define LOCAL_I915_PARAM_SUBSLICE_TOTAL 33 > > > +#define LOCAL_I915_PARAM_EU_TOTAL34 > > > > How