[Intel-gfx] [PATCH v2] drm/i915: restore backlight precision when converting from opregion

2014-05-05 Thread Aaron Lu
On 05/04/2014 06:41 PM, Chris Wilson wrote: > On Sun, May 04, 2014 at 03:31:01PM +0800, Aaron Lu wrote: >> On 05/04/2014 03:22 PM, Chris Wilson wrote: >>> Also this still has the same rounding error as before. >> >> I didn't get this, care to explain? > > The calculation you use, truncates, rather

[Intel-gfx] [PATCH v2] drm/i915: restore backlight precision when converting from opregion

2014-05-04 Thread Aaron Lu
On 05/04/2014 03:22 PM, Chris Wilson wrote: > On Sun, May 04, 2014 at 03:16:05PM +0800, Aaron Lu wrote: >> On 04/28/2014 09:41 PM, Daniel Vetter wrote: >>> 64bit divisions won't compile on 32bit. You need one of the DO_DIV macros, >>> or whatever they're called again. I pain, I know ;-) >> >> Thank

[Intel-gfx] [PATCH v2] drm/i915: restore backlight precision when converting from opregion

2014-05-04 Thread Chris Wilson
On Sun, May 04, 2014 at 03:31:01PM +0800, Aaron Lu wrote: > On 05/04/2014 03:22 PM, Chris Wilson wrote: > > Also this still has the same rounding error as before. > > I didn't get this, care to explain? The calculation you use, truncates, rather than say round to nearest, would is the same discre

[Intel-gfx] [PATCH v2] drm/i915: restore backlight precision when converting from opregion

2014-05-04 Thread Chris Wilson
On Sun, May 04, 2014 at 03:16:05PM +0800, Aaron Lu wrote: > On 04/28/2014 09:41 PM, Daniel Vetter wrote: > > 64bit divisions won't compile on 32bit. You need one of the DO_DIV macros, > > or whatever they're called again. I pain, I know ;-) > > Thanks for the correction, here is an updated patch :