[Linaro-mm-sig] thoughts of looking at android fences

2013-11-11 Thread Rom Lemarchand
I ran some benchmarks and things seem to be running about the same. No one on our graphics team seemed concerned about the change. The only concern I heard was about the increased complexity of the new sync code as opposed to the old sync framework which tried to keep things straightforward. On

[Linaro-mm-sig] thoughts of looking at android fences

2013-11-08 Thread Maarten Lankhorst
op 07-11-13 22:11, Rom Lemarchand schreef: > Hi Maarten, I tested your changes and needed the attached patch: behavior > now seems equivalent as android sync. I haven't tested performance. > > The issue resolved by this patch happens when i_b < b->num_fences and i_a >> = a->num_fences (or vice vers

[Linaro-mm-sig] thoughts of looking at android fences

2013-11-08 Thread Maarten Lankhorst
op 07-11-13 22:11, Rom Lemarchand schreef: > Hi Maarten, I tested your changes and needed the attached patch: behavior > now seems equivalent as android sync. I haven't tested performance. > > The issue resolved by this patch happens when i_b < b->num_fences and > i_a >= a->num_fences (or vice vers

[Linaro-mm-sig] thoughts of looking at android fences

2013-11-08 Thread Rom Lemarchand
Let me run some benchmarks today, talk to people internally, and I'll let you know. On Nov 8, 2013 3:43 AM, "Maarten Lankhorst" wrote: > op 07-11-13 22:11, Rom Lemarchand schreef: > > Hi Maarten, I tested your changes and needed the attached patch: behavior > > now seems equivalent as android syn

[Linaro-mm-sig] thoughts of looking at android fences

2013-11-07 Thread Rom Lemarchand
Hi Maarten, I tested your changes and needed the attached patch: behavior now seems equivalent as android sync. I haven't tested performance. The issue resolved by this patch happens when i_b < b->num_fences and i_a >= a->num_fences (or vice versa). Then, pt_a is invalid and so dereferencing pt_a-

[Linaro-mm-sig] thoughts of looking at android fences

2013-11-04 Thread Maarten Lankhorst
op 02-11-13 22:36, Colin Cross schreef: > On Wed, Oct 30, 2013 at 5:17 AM, Maarten Lankhorst > wrote: >> op 24-10-13 14:13, Maarten Lankhorst schreef: >>> So I actually tried to implement it now. I killed all the deprecated >>> members and assumed a linear timeline. >>> This means that syncpoints

[Linaro-mm-sig] thoughts of looking at android fences

2013-11-04 Thread Maarten Lankhorst
op 02-11-13 22:36, Colin Cross schreef: > On Wed, Oct 30, 2013 at 5:17 AM, Maarten Lankhorst > wrote: >> op 24-10-13 14:13, Maarten Lankhorst schreef: >>> So I actually tried to implement it now. I killed all the deprecated >>> members and assumed a linear timeline. >>> This means that syncpoints

[Linaro-mm-sig] thoughts of looking at android fences

2013-11-03 Thread Maarten Lankhorst
op 02-11-13 22:36, Colin Cross schreef: > On Wed, Oct 30, 2013 at 5:17 AM, Maarten Lankhorst > wrote: >> op 24-10-13 14:13, Maarten Lankhorst schreef: >>> So I actually tried to implement it now. I killed all the deprecated >>> members and assumed a linear timeline. >>> This means that syncpoints

[Linaro-mm-sig] thoughts of looking at android fences

2013-11-02 Thread Colin Cross
On Wed, Oct 30, 2013 at 5:17 AM, Maarten Lankhorst wrote: > op 24-10-13 14:13, Maarten Lankhorst schreef: >> So I actually tried to implement it now. I killed all the deprecated members >> and assumed a linear timeline. >> This means that syncpoints can only be added at the end, not in between. I

[Linaro-mm-sig] thoughts of looking at android fences

2013-11-01 Thread Rom Lemarchand
Sorry about the delay. Hopefully other people from Android will also chime in. We need the ability to merge sync fences and keep the sync_pt ordered: the idea behind sync timelines is that we promise an ordering of operations. Our reference device is Nexus 10: we need to make sure that any new imp

[Linaro-mm-sig] thoughts of looking at android fences

2013-10-30 Thread Maarten Lankhorst
op 24-10-13 14:13, Maarten Lankhorst schreef: > op 09-10-13 16:39, Maarten Lankhorst schreef: >> Hey, >> >> op 08-10-13 19:37, John Stultz schreef: >>> On Wed, Oct 2, 2013 at 11:13 AM, Erik Gilling >>> wrote: On Wed, Oct 2, 2013 at 12:35 AM, Maarten Lankhorst wrote: > Depending on

[Linaro-mm-sig] thoughts of looking at android fences

2013-10-24 Thread Maarten Lankhorst
op 09-10-13 16:39, Maarten Lankhorst schreef: > Hey, > > op 08-10-13 19:37, John Stultz schreef: >> On Wed, Oct 2, 2013 at 11:13 AM, Erik Gilling wrote: >>> On Wed, Oct 2, 2013 at 12:35 AM, Maarten Lankhorst >>> wrote: Depending on feedback I'll try reflashing my nexus 7 to stock android, a

Re: [Linaro-mm-sig] thoughts of looking at android fences

2013-10-09 Thread Maarten Lankhorst
Hey, op 08-10-13 19:37, John Stultz schreef: > On Wed, Oct 2, 2013 at 11:13 AM, Erik Gilling wrote: >> On Wed, Oct 2, 2013 at 12:35 AM, Maarten Lankhorst >> wrote: >>> Depending on feedback I'll try reflashing my nexus 7 to stock android, and >>> work on trying to convert android >>> syncpoint

Re: [Linaro-mm-sig] thoughts of looking at android fences

2013-10-08 Thread Rob Clark
On Tue, Oct 8, 2013 at 1:37 PM, John Stultz wrote: > On Wed, Oct 2, 2013 at 11:13 AM, Erik Gilling wrote: >> On Wed, Oct 2, 2013 at 12:35 AM, Maarten Lankhorst >> wrote: >>> Depending on feedback I'll try reflashing my nexus 7 to stock android, and >>> work on trying to convert android >>> sync

Re: [Linaro-mm-sig] thoughts of looking at android fences

2013-10-08 Thread Rob Clark
On Wed, Oct 2, 2013 at 2:13 PM, Erik Gilling wrote: >> The lock is provided by the driver, which makes adding support for old >> hardware that has no reliable way of notifying completion of events easier. > > I'm a bit confused here how it's possible to implement sync on > hardware with "no relia

Re: [Linaro-mm-sig] thoughts of looking at android fences

2013-10-08 Thread John Stultz
On Wed, Oct 2, 2013 at 11:13 AM, Erik Gilling wrote: > On Wed, Oct 2, 2013 at 12:35 AM, Maarten Lankhorst > wrote: >> Depending on feedback I'll try reflashing my nexus 7 to stock android, and >> work on trying to convert android >> syncpoints to dma-fence, which I'll probably rename to syncpoin

Re: [Linaro-mm-sig] thoughts of looking at android fences

2013-10-02 Thread Erik Gilling
On Wed, Oct 2, 2013 at 12:35 AM, Maarten Lankhorst wrote: > The timeline is similar to what I called a fence context. Each command stream > on a gpu can have a context. Because > nvidia hardware can have 4095 separate timelines, I didn't want to keep the > bookkeeping for each timeline, although