[PATCH/RESEND 9/9] drm/tilcdc: replace late_initcall with module_init

2014-06-25 Thread Russell King - ARM Linux
On Wed, Jun 25, 2014 at 11:32:46AM -0300, Ezequiel Garc?a wrote: > (Ccing Guido back) > > Hello Russell, Darren, > > On 25 Jun 02:00 PM, Russell King - ARM Linux wrote: > > On Tue, Jun 24, 2014 at 05:04:36PM -0500, Darren Etheridge wrote: > > > If I recall, the late_initcall stuff was done to

[PATCH/RESEND 9/9] drm/tilcdc: replace late_initcall with module_init

2014-06-25 Thread Russell King - ARM Linux
On Wed, Jun 25, 2014 at 02:00:42PM +0100, Russell King - ARM Linux wrote: > On Tue, Jun 24, 2014 at 05:04:36PM -0500, Darren Etheridge wrote: > > On 06/17/2014 09:17 AM, Guido Mart?nez wrote: > >> Use module_init instead of late_initcall, as is the norm for modular > >> drivers. > >> > >>

[PATCH/RESEND 9/9] drm/tilcdc: replace late_initcall with module_init

2014-06-25 Thread Russell King - ARM Linux
On Tue, Jun 24, 2014 at 05:04:36PM -0500, Darren Etheridge wrote: > On 06/17/2014 09:17 AM, Guido Mart?nez wrote: >> Use module_init instead of late_initcall, as is the norm for modular >> drivers. >> >> module_init was used until 6e8de0bd6a51fdeebd5d975c4fcc426f730b339b >> ("drm/tilcdc: add

[PATCH/RESEND 9/9] drm/tilcdc: replace late_initcall with module_init

2014-06-25 Thread Ezequiel García
Hi Russell, On 25 Jun 03:46 PM, Russell King - ARM Linux wrote: > > > > That doesn't make any sense. Using late_initcall for the tilcdc DRM > > driver would make the tilcdc DRM get probed before any other regular > > module_init driver, including the tda998x encoder. > > A module_init() is a

[PATCH/RESEND 9/9] drm/tilcdc: replace late_initcall with module_init

2014-06-25 Thread Ezequiel García
(Ccing Guido back) Hello Russell, Darren, On 25 Jun 02:00 PM, Russell King - ARM Linux wrote: > On Tue, Jun 24, 2014 at 05:04:36PM -0500, Darren Etheridge wrote: > > On 06/17/2014 09:17 AM, Guido Mart?nez wrote: > >> Use module_init instead of late_initcall, as is the norm for modular > >>

[PATCH/RESEND 9/9] drm/tilcdc: replace late_initcall with module_init

2014-06-24 Thread Darren Etheridge
On 06/17/2014 09:17 AM, Guido Mart?nez wrote: > Use module_init instead of late_initcall, as is the norm for modular > drivers. > > module_init was used until 6e8de0bd6a51fdeebd5d975c4fcc426f730b339b > ("drm/tilcdc: add encoder slave (v2)") changed it to a late_initcall, > but it does not explain

[PATCH/RESEND 9/9] drm/tilcdc: replace late_initcall with module_init

2014-06-17 Thread Guido Martínez
Use module_init instead of late_initcall, as is the norm for modular drivers. module_init was used until 6e8de0bd6a51fdeebd5d975c4fcc426f730b339b ("drm/tilcdc: add encoder slave (v2)") changed it to a late_initcall, but it does not explain why. Tests show it's working properly with module_init.