[PATCH][next] drm/i915/display: Fix spelling mistake "Uncomressed" -> "Uncompressed"

2024-10-02 Thread Colin Ian King
There is a spelling mistake in a drm_WARN message. Fix it. Signed-off-by: Colin Ian King --- drivers/gpu/drm/i915/display/intel_display.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/display/intel_display.c b/drivers/gpu/drm/i915/display/intel_display

[PATCH 1/1] drm/display: Fix building with GCC 15

2024-10-02 Thread Brahmajit Das
GCC 15 enables -Werror=unterminated-string-initialization by default. This results in the following build error drivers/gpu/drm/display/drm_dp_dual_mode_helper.c: In function ‘is_hdmi_adaptor’: drivers/gpu/drm/display/drm_dp_dual_mode_helper.c:164:17: error: initializer-string for array of ‘cha

[PATCH 2/3] dma-buf/heaps: replace kmap_atomic with kmap_local_page

2024-10-02 Thread Pintu Kumar
Use of kmap_atomic/kunmap_atomic is deprecated, use kmap_local_page/kunmap_local instead. This is reported by checkpatch. Also fix repeated word issue. WARNING: Deprecated use of 'kmap_atomic', prefer 'kmap_local_page' instead + void *vaddr = kmap_atomic(page); WARNING: Dep

[PATCH 1/1] drm/display: Fix building with GCC 15

2024-10-02 Thread Brahmajit Das
GCC 15 enables -Werror=unterminated-string-initialization by default. This results in the following build error drivers/gpu/drm/display/drm_dp_dual_mode_helper.c: In function ‘is_hdmi_adaptor’: drivers/gpu/drm/display/drm_dp_dual_mode_helper.c:164:17: error: initializer-string for array of ‘cha

Re: [PATCH v3 13/14] drm/mediatek: Support DRM plane alpha in OVL

2024-10-02 Thread Adam Thiede
uot;, "state->base.alpha" and "con" here? pr_info("fmt:0x%x, has_alpha:0x%x, alpha:0x%x, con:0x%x \n", fmt, state->base.fb->format->has_alpha, state->base.alpha, con); I'm not sure if it's the color format setting problem, maybe

[PATCH 1/3] dma-buf: replace symbolic permission S_IRUGO with octal 0444

2024-10-02 Thread Pintu Kumar
Symbolic permissions are not preferred, instead use the octal. Also, fix other warnings/errors as well for cleanup. WARNING: Block comments use * on subsequent lines + /* only support discovering the end of the buffer, + but also allow SEEK_SET to maintain the idiomatic WARNING: Bl

Re: [PATCH v5 0/7] drm/mgag200: Implement VBLANK support

2024-10-02 Thread Thomas Zimmermann
m/mgag200: Only set VIDRST bits in CRTC modesetting I tried a mini-bisct across these changes and found the system boots normally with: 5cd522b5331b drm/mgag200: Add dedicted variable for field and fails with: 89c6ea2006e2 drm/mgag200: Add vblank support I do see that there is a subsequent

Re: [PATCH] Revert "drm/radeon: use GEM references instead of TTMs"

2024-10-01 Thread Christian König
verts commit fd69ef05029f9beb7b031ef96e7a36970806a670. The original patch causes NULL pointer references: [   21.620856] CPU 3 Unable to handle kernel paging request at virtual address , era == 94bf61d8, ra == 94bf61d4 [   21.717958] Oops[#1]: [   21.803205] C

Re: [PATCH v4 5/5] dt-bindings: display: mediatek: dpi: correct power-domains property

2024-10-01 Thread Krzysztof Kozlowski
- > > > .../display/mediatek/mediatek,dpi.yaml| 24 --- > > > 1 file changed, 10 insertions(+), 14 deletions(-) > > > > You missed Krzysztof's R-by tag. > > > > Oh, I just missed that reply for v3 in the mailbox > and thought it still need to be reviewed. > I just found Krzysztof's R-by tag in the mailbox right now. > > I'll send an update for this patch set. > Thanks for the reminder. Plaese, instead just start using b4... Best regards, Krzysztof

Re: [PATCH v5 2/2] drm/mediatek: Add blend_modes to mtk_plane_init() for different SoCs

2024-10-01 Thread kernel test robot
Hi Jason-JH.Lin, kernel test robot noticed the following build errors: [auto build test ERROR on drm/drm-next] [also build test ERROR on linus/master v6.12-rc1 next-20241001] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use

[PATCH v5 2/5] dt-bindings: iommu: mediatek: Fix interrupt count constraint for new SoCs

2024-10-01 Thread Macpaul Lin
The infra-iommu node in mt8195.dtsi was triggering a CHECK_DTBS error due to an excessively long 'interrupts' property. The error message was: infra-iommu@10315000: interrupts: [[0, 795, 4, 0], [0, 796, 4, 0], [0, 797, 4, 0], [0, 798, 4, 0], [0, 799, 4, 0]]

[PATCH v5 5/5] dt-bindings: display: mediatek: dpi: correct power-domains property

2024-10-01 Thread Macpaul Lin
dtbs_check errors. So keeps no change here. Changes for v3: - The origin patch is [2] https://lore.kernel.org/all/20240926111449.9245-2-macpaul@mediatek.com/ - Thanks for Conor's reminding, after MediaTek's internal discussion, This patch v3 is the replacement of [2] v2

[PATCH v5 1/5] arm64: dts: mt8195: Fix dtbs_check error for infracfg_ao node

2024-10-01 Thread Macpaul Lin
The infracfg_ao node in mt8195.dtsi was causing a dtbs_check error. The error message was: syscon@10001000: compatible: ['mediatek,mt8195-infracfg_ao', 'syscon', 'simple-mfd'] is too long To resolve this, remove 'simple-mfd' from the 'compatible' property of the infracfg_ao node.

[PATCH v5 3/5] arm64: dts: mediatek: mt8395-genio-1200-evk: Fix dtbs_check error for phy

2024-10-01 Thread Macpaul Lin
The ethernet-phy node in mt8395-genio-1200-evk.dts was triggering a dtbs_check error. The error message was: eth-phy0@1: $nodename:0: 'eth-phy0@1' does not match '^ethernet-phy(@[a-f0-9]+)?$' Fix this issue by replacing 'eth-phy' node to generic 'ethernet-phy'. Fixes: f2b543a191b6

[PATCH v5 4/5] arm64: dts: mt8195: Fix dtbs_check error for mutex node

2024-10-01 Thread Macpaul Lin
The mutex node in mt8195.dtsi was triggering a dtbs_check error: mutex@1c101000: 'clock-names', 'reg-names' do not match any of the regexes: 'pinctrl-[0-9]+' This seems no need by inspecting the DT schemas and other reference boards, so drop 'clock-names' and 'reg-names' in mt8

Re: [PATCH v2 2/5] dt-bindings: iommu: mediatek: Fix interrupt count constraint for new SoCs

2024-10-01 Thread Macpaul Lin
On 9/30/24 16:49, AngeloGioacchino Del Regno wrote: Il 26/09/24 13:14, Macpaul Lin ha scritto: The infra-iommu node in mt8195.dtsi was triggering a CHECK_DTBS error due to an excessively long 'interrupts' property. The error message was: [snip] diff --git a/Documentation/devicetree/bin

Re: [PATCH v11 08/15] drm/vkms: Re-introduce line-per-line composition algorithm

2024-10-01 Thread Randy Dunlap
On 9/30/24 8:31 AM, Louis Chauvet wrote: > Re-introduce a line-by-line composition algorithm for each pixel format. > This allows more performance by not requiring an indirection per pixel > read. This patch is focused on readability of the code. > > Line-by-line composition wa

Re: [PATCH v11 06/15] drm/vkms: Avoid computing blending limits inside pre_mul_alpha_blend

2024-10-01 Thread Randy Dunlap
Hi-- On 9/30/24 8:31 AM, Louis Chauvet wrote: > The pre_mul_alpha_blend is dedicated to blending, so to avoid mixing > different concepts (coordinate calculation and color management), extract > the x_limit and x_dst computation outside of this helper. > It also increases the maintainability by gr

Re: [PATCH v11 03/15] drm/vkms: Add typedef and documentation for pixel_read and pixel_write functions

2024-10-01 Thread Randy Dunlap
Hi, On 9/30/24 8:31 AM, Louis Chauvet wrote: > Introduce two typedefs: pixel_read_t and pixel_write_t. It allows the > compiler to check if the passed functions take the correct arguments. > Such typedefs will help ensuring consistency across the code base in > case of update of these prototypes.

[PATCH v8 2/2] drm/tiny: Add driver for Sharp Memory LCD

2024-10-01 Thread Alex Lanzano
Add support for the monochrome Sharp Memory LCDs. Co-developed-by: Mehdi Djait Signed-off-by: Mehdi Djait Signed-off-by: Alex Lanzano Reviewed-by: Dmitry Baryshkov --- MAINTAINERS | 6 + drivers/gpu/drm/tiny/Kconfig| 20 + drivers/gpu/drm/tiny/Makefile

[PATCH v8 1/2] dt-bindings: display: Add Sharp Memory LCD bindings

2024-10-01 Thread Alex Lanzano
Add device tree bindings for the monochrome Sharp Memory LCD Co-developed-by: Mehdi Djait Signed-off-by: Mehdi Djait Signed-off-by: Alex Lanzano Reviewed-by: Krzysztof Kozlowski --- .../bindings/display/sharp,ls010b7dh04.yaml | 92 +++ 1 file changed, 92 insertions(+) creat

[PATCH v8 0/2] Add driver for Sharp Memory LCD

2024-10-01 Thread Alex Lanzano
This patch series add support for the monochrome Sharp Memory LCD panels. This series is based off of the work done by Mehdi Djait. References: https://lore.kernel.org/dri-devel/71a9dbf4609dbba46026a31f60261830163a0b99.1701267411.git.mehdi.dj...@bootlin.com/ https://www.sharpsde.com/fileadmin

Re: [PATCH v4 5/5] dt-bindings: display: mediatek: dpi: correct power-domains property

2024-10-01 Thread Macpaul Lin
y tag. Oh, I just missed that reply for v3 in the mailbox and thought it still need to be reviewed. I just found Krzysztof's R-by tag in the mailbox right now. I'll send an update for this patch set. Thanks for the reminder. Regards, Macpaul Lin

Re: [PATCH v4 5/5] dt-bindings: display: mediatek: dpi: correct power-domains property

2024-10-01 Thread Rob Herring
On Mon, Sep 30, 2024 at 04:38:54PM +0800, Macpaul Lin wrote: > The MediaTek DPI module is typically associated with one of the > following multimedia power domains: > - POWER_DOMAIN_DISPLAY > - POWER_DOMAIN_VDOSYS > - POWER_DOMAIN_MM > The specific power domain used varies depending on the SoC d

Re: [PATCH 5/8] dt-bindings: display: bridge: Add ITE IT6263 LVDS to HDMI converter

2024-10-01 Thread Rob Herring
On Mon, Sep 30, 2024 at 01:29:00PM +0800, Liu Ying wrote: > Document ITE IT6263 LVDS to HDMI converter. > > Product link: > https://www.ite.com.tw/en/product/cate1/IT6263 > > Signed-off-by: Liu Ying > --- > .../bindings/display/bridge/ite,it6263.yaml | 310 ++ > 1 file changed

[PATCH v4] drm/etnaviv: Request pages from DMA32 zone on addressing_limited

2024-10-01 Thread Xiaolei Wang
Suggested-by: Sui Jingfeng Signed-off-by: Xiaolei Wang Reviewed-by: Christian Gmeiner --- v1: https://patchwork.kernel.org/project/dri-devel/patch/20240806104733.2018783-1-xiaolei.w...@windriver.com/ v2: Modify the issue of not retaining GFP_USER in v1 and update the commit log. v3:

Re: [PATCH v5 0/7] drm/mgag200: Implement VBLANK support

2024-10-01 Thread Tony Luck
iable for field and fails with: 89c6ea2006e2 drm/mgag200: Add vblank support I do see that there is a subsequent "Fix VBLANK" patch, but it appears that whatever it fixed didn't help on my system. -Tony

[RFC PATCH 1/1] drm/meson: Support drm_panic

2024-10-01 Thread Yao Zi
This patch implements drm_plane_helper_funcs.get_scanout_buffer for primary plane, enabling meson-drm to work with drm_panic. This implementation tries to use current framebuffer as scanout buffer. In case of AFBC enabled, we disable the decoder path and adjust OSD1 parameters in

Re: [PATCH 2/3] dma-buf/heaps: replace kmap_atomic with kmap_local_page

2024-10-01 Thread T.J. Mercier
On Tue, Oct 1, 2024 at 7:51 PM Pintu Kumar wrote: > > Use of kmap_atomic/kunmap_atomic is deprecated, use > kmap_local_page/kunmap_local instead. > > This is reported by checkpatch. > Also fix repeated word issue. > > WARNING: Deprecated use of 'kmap_atomic', prefer 'kmap_local_page' instead > +

Re: [PATCH v3] drm/panel: elida-kd35t133: transition to mipi_dsi wrapped functions

2024-10-01 Thread Doug Anderson
Hi, On Wed, Sep 25, 2024 at 1:00 AM Tejas Vipin wrote: > > Changes the elida-kd35t133 panel to use multi style functions for > improved error handling. > > Reviewed-by: Jessica Zhang > Reviewed-by: Dmitry Baryshkov > Signed-off-by: Tejas Vipin > --- > Changes in v3: > - Added back bytes t

[RFC PATCH 0/1] meson/drm: Support drm_panic

2024-10-01 Thread Yao Zi
This patch adds drm_panic support for meson-drm, has been tested on A311D with both TTY and Wayland session. It is an RFC since I am not sure whether AFBC enabled case is handled properly and don't find a good test case. Thanks for your time and advice. Yao Zi (1): drm/meson: Support drm_

Re: [PATCH] Documentation: dma-buf: heaps: Add heap name definitions

2024-10-01 Thread T.J. Mercier
On Mon, Sep 30, 2024 at 4:41 PM Maxime Ripard wrote: > > Following a recent discussion at last Plumbers, John Stultz, Sumit > Sewal, TJ Mercier and I came to an agreement that we should document > what the dma-buf heaps names are expected to be, and what the buffers > attributes you'll get should

Re: [PATCH 1/1] platform/x86/tuxedo: Add virtual LampArray for TUXEDO NB04 devices

2024-10-01 Thread Pavel Machek
Hi! > PPS: sorry for pushing that hard on HID-BPF, but I can see that it fits > all of the requirements here: > - need to be dynamic > - still unsure of the userspace implementation, meaning that userspace > might do something wrong, which might require kernel changes > - possibility to extend l

[PATCH] uapi/drm: Specify time constraints of DRM_MODE_ATOMIC_NONBLOCK

2024-10-01 Thread Jonas Ådahl
From: Jonas Ådahl In order for compositors to utilize real time scheduling capabilities, it must be ensured by the kernel that calling a drmModeAtomicCommit() with DRM_MODE_ATOMIC_NONBLOCK does not block in a manner that makes the realtime scheduler watchdog send a SIGKILL to the calling process.

Re: [PATCH 1/1] platform/x86/tuxedo: Add virtual LampArray for TUXEDO NB04 devices

2024-10-01 Thread Pavel Machek
Hi! > > > > LampArray HID device and translates the input from hidraw to the > > > > corresponding WMI calls. This is a new approach as the leds > > > > subsystem lacks > > > > a suitable UAPI for per-key keyboard backlights, and like this > > > > no new UAPI > > > > needs to be established. > > >

Re: [PATCH v6 11/11] Documentation: document adreno preemption

2024-10-01 Thread Antonino Maniscalco
On 10/1/24 3:10 AM, Bagas Sanjaya wrote: On Thu, Sep 26, 2024 at 11:16:53PM +0200, Antonino Maniscalco wrote: +.. SPDX-License-Identifier: GPL-2.0 + +:orphan: Why don't this be added to toctree in Documentation/gpu/index.rst? Yes so there is existing orphan documentation for msm so my intent

Re: [PATCH 1/1] platform/x86/tuxedo: Add virtual LampArray for TUXEDO NB04 devices

2024-10-01 Thread Werner Sembach
Hi Armin, Am 01.10.24 um 18:45 schrieb Armin Wolf: Am 01.10.24 um 15:41 schrieb Benjamin Tissoires: On Oct 01 2024, Werner Sembach wrote: (sorry resend because thunderbird made it a html mail) Hi, Am 30.09.24 um 19:06 schrieb Benjamin Tissoires: On Sep 30 2024, Werner Sembach wrote: [...]

Re: [PATCH] drm/etnaviv: Print error message if inserting IOVA address range fails

2024-10-01 Thread Sui Jingfeng
Insert iova failed, va: %llx, size: %zx\n", + va, etnaviv_obj->base.size); As this might happen for a lot of buffers in a single submit and userspace might be unimpressed by the submit failure and keep pushing new submits, this has a potential to spam the lo

Re: [PATCH 1/1] platform/x86/tuxedo: Add virtual LampArray for TUXEDO NB04 devices

2024-10-01 Thread Werner Sembach
Hi Benjamin, Am 01.10.24 um 15:41 schrieb Benjamin Tissoires: On Oct 01 2024, Werner Sembach wrote: (sorry resend because thunderbird made it a html mail) Hi, Am 30.09.24 um 19:06 schrieb Benjamin Tissoires: On Sep 30 2024, Werner Sembach wrote: [...] Thinking about it, maybe it's not to ba

Re: [PATCH v15 16/19] drm/etnaviv: Call etnaviv_gem_obj_add() in ernaviv_gem_new_private()

2024-10-01 Thread Sui Jingfeng
iately after it was successfully created. A benifit is that we only need to call etnaviv_gem_obj_add() once now, since the ernaviv_gem_new_private() has been unified. Make the etnaviv_gem_obj_add() static is a next nature thing. Seeing this patch, I would really ask you to drop patch 11 from thi

[PATCH] drm: renesas: rz-du: Drop DU_MCR0_DPI_OE macro

2024-10-01 Thread Biju Das
The DPI_OE bit is removed from the latest RZ/G2UL and RZ/G2L hardware manual. So, drop this macro. Signed-off-by: Biju Das --- drivers/gpu/drm/renesas/rz-du/rzg2l_du_crtc.c | 8 +--- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/drivers/gpu/drm/renesas/rz-du/rzg2l_du_crtc.c b

Re: [PATCH v15 11/19] drm/etnaviv: Add etnaviv_gem_obj_remove() helper

2024-10-01 Thread Sui Jingfeng
Hi, On 2024/10/1 22:21, Lucas Stach wrote: Am Sonntag, dem 08.09.2024 um 17:43 +0800 schrieb Sui Jingfeng: Which is corresonding to the etnaviv_gem_obj_add() While symmetry is nice, Thanks a lot for understanding and review my patch. it's still not really symmetric, patch 0016

Re: [PATCH v6 0/8] drm: zynqmp_dp: IRQ cleanups and debugfs support

2024-10-01 Thread Sean Anderson
On 8/9/24 15:35, Sean Anderson wrote: > This series cleans up the zyqnmp_dp IRQ and locking situation. Once > that's done, it adds debugfs support. The intent is to enable compliance > testing or to help debug signal-integrity issues. > > Previously, I discussed converting the HPD work(s) to a thr

Re: [PATCH] drm/i915/backlight: Remove a useless kstrdup_const()

2024-10-01 Thread Christophe JAILLET
for the noise. CJ The code simplicity is much more important than saving a few bytes. BR, Jani. Signed-off-by: Christophe JAILLET --- Compile tested only. For the records, this patch is a clean-up effort related to discussions at: - https://lore.kernel.org/all/ZvHurCYlCoi1ZTCX@skv

[RFC PATCH v4 1/1] platform/x86/tuxedo: Add virtual LampArray for TUXEDO NB04 devices

2024-10-01 Thread Werner Sembach
The TUXEDO Sirius 16 Gen1 and TUXEDO Sirius 16 Gen2 devices have a per-key controllable RGB keyboard backlight. The firmware API for it is implemented via WMI. To make the backlight userspace configurable this driver emulates a LampArray HID device and translates the input from hidraw to the corre

[RFC PATCH v4 0/1] platform/x86/tuxedo: Add virtual LampArray for TUXEDO NB04

2024-10-01 Thread Werner Sembach
Just wanted to send my current state as previous version had a null pointer dereference. On this toppic, why does hdev have a hdev->driver_data and a hdev->dev.driver_data which are not the same? I assume hdev->driver_data is for the ll_driver and hdev->dev.driver_data for the driver?

Re: [PATCH v3 13/14] drm/mediatek: Support DRM plane alpha in OVL

2024-10-01 Thread 林睿祥

Re: [PATCH] drm/panthor: Don't add write fences to the shared BOs

2024-10-01 Thread Boris Brezillon
On Thu, 5 Sep 2024 09:01:54 +0200 Boris Brezillon wrote: > The only user (the mesa gallium driver) is already assuming explicit > synchronization and doing the export/import dance on shared BOs. The > only reason we were registering ourselves as writers on external BOs > is because Xe, which was

Re: [PATCH] drm/panthor: Don't declare a queue blocked if deferred operations are pending

2024-10-01 Thread Boris Brezillon
On Thu, 5 Sep 2024 09:19:14 +0200 Boris Brezillon wrote: > If deferred operations are pending, we want to wait for those to > land before declaring the queue blocked on a SYNC_WAIT. We need > this to deal with the case where the sync object is signalled through > a deferred SYNC_{ADD,SET} from t

Re: [PATCH 1/1] platform/x86/tuxedo: Add virtual LampArray for TUXEDO NB04 devices

2024-10-01 Thread Armin Wolf
Am 01.10.24 um 15:41 schrieb Benjamin Tissoires: On Oct 01 2024, Werner Sembach wrote: (sorry resend because thunderbird made it a html mail) Hi, Am 30.09.24 um 19:06 schrieb Benjamin Tissoires: On Sep 30 2024, Werner Sembach wrote: [...] Thinking about it, maybe it's not to bad that it onl

Re: [PATCH v2] drm/panthor: Fix access to uninitialized variable in tick_ctx_cleanup()

2024-10-01 Thread Boris Brezillon
On Mon, 30 Sep 2024 18:37:42 +0200 Boris Brezillon wrote: > The group variable can't be used to retrieve ptdev in our second loop, > because it points to the previously iterated list_head, not a valid > group. Get the ptdev object from the scheduler instead. > > Cc: > Fixes: d72f049087d4 ("drm/

Re: [PATCH] drm/panthor: Lock the VM resv before calling drm_gpuvm_bo_obtain_prealloc()

2024-10-01 Thread Boris Brezillon
On Fri, 13 Sep 2024 13:27:22 +0200 Boris Brezillon wrote: > drm_gpuvm_bo_obtain_prealloc() will call drm_gpuvm_bo_put() on our > pre-allocated BO if the association exists. Given we > only have one ref on preallocated_vm_bo, drm_gpuvm_bo_destroy() will > be called immediately, and we have to hol

Re: [PATCH] drm/panthor: Add FOP_UNSIGNED_OFFSET to fop_flags

2024-10-01 Thread Boris Brezillon
On Fri, 20 Sep 2024 11:28:02 +0100 Liviu Dudau wrote: > Since 641bb4394f40 ("fs: move FMODE_UNSIGNED_OFFSET to fop_flags") > the FMODE_UNSIGNED_OFFSET flag has been moved to fop_flags and renamed, > but the patch failed to make the changes for the panthor driver. > Whe

Re: [PATCH v7 1/5] drm: Introduce device wedged event

2024-10-01 Thread Raag Jadav
On Tue, Oct 01, 2024 at 05:54:46PM +0300, Andy Shevchenko wrote: > On Tue, Oct 01, 2024 at 05:18:33PM +0300, Raag Jadav wrote: > > On Tue, Oct 01, 2024 at 03:07:59PM +0300, Andy Shevchenko wrote: > > > On Tue, Oct 01, 2024 at 08:08:18AM +0300, Raag Jadav wrote: > > > > On Mon, Sep 30, 2024 at 03:59

Re: [PATCH v3 13/14] drm/mediatek: Support DRM plane alpha in OVL

2024-10-01 Thread 胡俊光

Re: [PATCH v4] docs/gpu: ci: update flake tests requirements

2024-10-01 Thread Vignesh Raman
d.dtb # Linux Version: 6.6-rc1 # IGT Version: 1.28-gd2af13d9f # Failure Rate: 100 flaky-test +Use the appropriate link below to create a GitLab issue: +amdgpu driver: https://gitlab.freedesktop.org/drm/amd/-/issues Please could you ack this patch. Thanks. +i915 driver:

Re: [PATCH] drm/panthor: Add FOP_UNSIGNED_OFFSET to fop_flags

2024-10-01 Thread Heiko Stübner
Am Freitag, 20. September 2024, 12:28:02 CEST schrieb Liviu Dudau: > Since 641bb4394f40 ("fs: move FMODE_UNSIGNED_OFFSET to fop_flags") > the FMODE_UNSIGNED_OFFSET flag has been moved to fop_flags and renamed, > but the patch failed to make the changes for the panthor driver

Re: [PATCH v15 05/19] drm/etnaviv: Add contructor and destructor for etnaviv_gem_get_mapping structure

2024-10-01 Thread Lucas Stach
e90b 100644 > --- a/drivers/gpu/drm/etnaviv/etnaviv_gem.h > +++ b/drivers/gpu/drm/etnaviv/etnaviv_gem.h > @@ -31,6 +31,12 @@ struct etnaviv_vram_mapping { > u32 iova; > }; > > +static inline struct etnaviv_vram_mapping * > +to_etnaviv_vram_mapping(struct drm_mm_node *vram) > +{ > + return container_of(vram, struct etnaviv_vram_mapping, vram_node); > +} > + This hunk looks unrelated to this patch. Otherwise patch looks good. Regards, Lucas > struct etnaviv_gem_object { > struct drm_gem_object base; > const struct etnaviv_gem_ops *ops;

Re: [PATCH v2] drm/amdgpu: add dce6 drm_panic support

2024-10-01 Thread Jocelyn Falempe
pretty user friendly message on the screen when a Linux kernel panic occurs. Signed-off-by: Lu Yao Patch looks good to me.  Any chance you want to convert the other non-DC dce files (dce_v8_0.c, dce_v10_0.c, dce_v11_0.c) while you are at it? I've made a similar patch in amdgpu_dm_plane.c, a

Re: [PATCH v10 3/3] drm/mediatek: Implement OF graphs support for display paths

2024-10-01 Thread AngeloGioacchino Del Regno
Il 01/10/24 12:07, CK Hu (胡俊光) ha scritto: Hi, Angelo: On Tue, 2024-09-10 at 10:51 +, AngeloGioacchino Del Regno wrote: It is impossible to add each and every possible DDP path combination for each and every possible combination of SoC and board: right now, this driver hardcodes configurati

Re: [PATCH v2 16/22] drm/msm/dpu: Configure CWB in writeback encoder

2024-10-01 Thread neil . armstrong
Hi, On 30/09/2024 21:19, Jessica Zhang wrote: On 9/30/2024 7:17 AM, neil.armstr...@linaro.org wrote: On 25/09/2024 00:59, Jessica Zhang wrote: Cache the CWB block mask in the DPU virtual encoder and configure CWB according to the CWB block mask within the writeback phys encoder Signed-off-b

Re: [PATCH v7 1/5] drm: Introduce device wedged event

2024-10-01 Thread Andy Shevchenko
On Tue, Oct 01, 2024 at 08:08:18AM +0300, Raag Jadav wrote: > On Mon, Sep 30, 2024 at 03:59:59PM +0300, Andy Shevchenko wrote: > > On Mon, Sep 30, 2024 at 01:08:41PM +0530, Raag Jadav wrote: ... > > > +static const char *const drm_wedge_recovery_opts[] = { > > > + [DRM_WEDGE_RECOVERY_REBIND] = "r

Re: [PATCH v15 01/19] drm/etnaviv: Implement drm_gem_object_funcs::print_info()

2024-10-01 Thread Lucas Stach
Hi Sui, Am Sonntag, dem 08.09.2024 um 17:43 +0800 schrieb Sui Jingfeng: > It will be called by drm_gem_print_info() if implemented, and it can > provide more information about the framebuffer objects. Etnaviv GEM BOs are not framebuffer objects. > > Signed-off-by: Sui Jingfeng > --- > drivers

Patch "drm/vmwgfx: Prevent unmapping active read buffers" has been added to the 6.1-stable tree

2024-10-01 Thread gregkh
This is a note to let you know that I've just added the patch titled drm/vmwgfx: Prevent unmapping active read buffers to the 6.1-stable tree which can be found at: http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary The filename of the patch is:

[PATCH drm-dp 3/4] drm/hisilicon/hibmc: add dp kapi moduel in hibmc drivers

2024-10-01 Thread shiyongbang
From: baihan li Build a kapi level that hibmc driver can enable dp by calling these kapi functions. Signed-off-by: baihan li --- drivers/gpu/drm/hisilicon/hibmc/Makefile | 2 +- .../gpu/drm/hisilicon/hibmc/dp/dp_config.h| 20 drivers/gpu/drm/hisilicon/hibmc/dp/dp_kapi.c | 1

Re: [PATCH v3 0/5] Display enablement changes for Qualcomm SA8775P platform

2024-10-01 Thread Krzysztof Kozlowski
device tree changes, and their YAML bindings. > > --- > In this series PATCH 5: "arm64: dts: qcom: sa8775p: add display dt nodes for > MDSS0 and DPU" > depends on the clock enablement change: > https://lore.kernel.org/all/20240816-sa8775p-mm-v3-v1-0-77d53c3c0...@quicinc.com/

Re: [PATCH 1/1] platform/x86/tuxedo: Add virtual LampArray for TUXEDO NB04 devices

2024-10-01 Thread Benjamin Tissoires
On Oct 01 2024, Werner Sembach wrote: > (sorry resend because thunderbird made it a html mail) > > Hi, > > Am 30.09.24 um 19:06 schrieb Benjamin Tissoires: > > On Sep 30 2024, Werner Sembach wrote: > > > [...] > > > Thinking about it, maybe it's not to bad that it only changes once udev is > > >

Re: [PATCH v8 2/3] drm/mediatek: ovl: Add blend_modes to driver data

2024-10-01 Thread 胡俊光

Re: [PATCH v10 3/3] drm/mediatek: Implement OF graphs support for display paths

2024-10-01 Thread 胡俊光

Re: [PATCH v15 04/19] drm/etnaviv: Make etnaviv_gem_prime_vmap() a static function

2024-10-01 Thread Lucas Stach
n, it has no direct relation > ship with the PRIME. The etnaviv_gem_prime.c file already has > etnaviv_gem_prime_vmap_impl() as the implementation to vmap > a imported GEM buffer object. > I don't agree with the premise with this patch. This function is clearly prime specific, so

Re: [PATCH 1/1] platform/x86/tuxedo: Add virtual LampArray for TUXEDO NB04 devices

2024-10-01 Thread Werner Sembach
Hi again, Am 01.10.24 um 14:23 schrieb Werner Sembach: (sorry resend because thunderbird made it a html mail) Hi, Am 30.09.24 um 19:06 schrieb Benjamin Tissoires: On Sep 30 2024, Werner Sembach wrote: [...] Thinking about it, maybe it's not to bad that it only changes once udev is ready, lik

Re: [PATCH v7 1/5] drm: Introduce device wedged event

2024-10-01 Thread Andy Shevchenko
On Tue, Oct 01, 2024 at 05:18:33PM +0300, Raag Jadav wrote: > On Tue, Oct 01, 2024 at 03:07:59PM +0300, Andy Shevchenko wrote: > > On Tue, Oct 01, 2024 at 08:08:18AM +0300, Raag Jadav wrote: > > > On Mon, Sep 30, 2024 at 03:59:59PM +0300, Andy Shevchenko wrote: > > > > On Mon, Sep 30, 2024 at 01:08

Re: [PATCH] drm/amd/pm: check return value of amdgpu_irq_add_id()

2024-10-01 Thread Christian König
Am 01.10.24 um 12:57 schrieb Igor Artemiev: amdgpu_irq_ad_id() may fail and the irq handlers will not be registered. This patch adds error code check. Found by Linux Verification Center (linuxtesting.org) with static analysis tool SVACE. Signed-off-by: Igor Artemiev --- .../drm/amd/pm

Re: [PATCH v2 2/2] drm/panel: simple: Add Microchip AC69T88A LVDS Display panel

2024-10-01 Thread Manikandan.M
On 27/09/24 4:51 am, Dmitry Baryshkov wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you know the > content is safe > > On Thu, Sep 26, 2024 at 03:58:11PM GMT, Maxime Ripard wrote: >> On Thu, Sep 26, 2024 at 04:32:59PM GMT, Dmitry Baryshkov wrote: >>> On Thu, Sep 26, 2024

Re: [PATCH v2 1/3] drm/nouveau/tegra: Use iommu_paging_domain_alloc()

2024-10-01 Thread Jason Gunthorpe
On Mon, Sep 16, 2024 at 04:42:33PM -0400, Lyude Paul wrote: > Sigh. Took me a minute but I think I know what happened - I meant to push the > entire series to drm-misc-next and not drm-misc-fixes, but I must have misread > or typo'd the branch name and pushed the second half of patches to drm-misc-

Re: [PATCH v15 03/19] drm/etnaviv: Implement drm_gem_object_funcs::vunmap()

2024-10-01 Thread Lucas Stach
Am Sonntag, dem 08.09.2024 um 17:43 +0800 schrieb Sui Jingfeng: > The vunmap() can be used to release virtual mapping obtained by vmap(), > While the vmap() is used to make a long duration mapping of multiple > physical pages into a contiguous virtual space. > > Make the implementation-specific vu

[PATCH drm-dp 4/4] drm/hisilicon/hibmc: add dp module in hibmc

2024-10-01 Thread shiyongbang
From: baihan li To support DP interface displaying in hibmc driver. Add a encoder and connector for DP modual. Signed-off-by: baihan li --- drivers/gpu/drm/hisilicon/hibmc/Makefile | 2 +- .../gpu/drm/hisilicon/hibmc/hibmc_drm_dp.c| 195 ++ .../gpu/drm/hisilicon/hibm

[PATCH drm-dp 0/4] Add dp module in hibmc driver

2024-10-01 Thread shiyongbang
From: baihan li Realizing the basic display function of DP cable for DP connector displaying. Add DP module in hibmc drm driver, which is for Hisilicon Hibmc SoC which used for Out-of-band management. Blow is the general hardware connection, both the Hibmc and the host CPU are on

[PATCH drm-dp 1/4] drm/hisilicon/hibmc: add dp aux in hibmc drivers

2024-10-01 Thread shiyongbang
From: baihan li Add dp aux read/write functions. They are basic functions and will be used later. Signed-off-by: baihan li --- drivers/gpu/drm/hisilicon/hibmc/Makefile | 3 +- drivers/gpu/drm/hisilicon/hibmc/dp/dp_aux.c | 227 +++ drivers/gpu/drm/hisilicon/hibmc/dp/dp_a

Re: [PATCH v15 18/19] drm/etnaviv: Allow userspace specify the domain of etnaviv GEM buffer object

2024-10-01 Thread Lucas Stach
Am Sonntag, dem 08.09.2024 um 17:43 +0800 schrieb Sui Jingfeng: > Otherwise we don't know where a etnaviv GEM buffer object should put when > we create it at userspace. > > Signed-off-by: Sui Jingfeng > --- > drivers/gpu/drm/etnaviv/etnaviv_drv.c | 9 + > include/uapi/drm/etnaviv_drm.h

Re: [PATCH 1/6] drm/sysfs: Remove version attribute

2024-10-01 Thread Dmitry Baryshkov
On September 30, 2024 1:49:41 PM GMT+03:00, Heiner Kallweit wrote: >On 22.09.2024 16:55, Dmitry Baryshkov wrote: >> On Sun, Sep 08, 2024 at 02:08:58PM GMT, Heiner Kallweit wrote: >>> This undocumented attribute returns a version string which hasn't been >>> changed for ages. libdrm doesn't use it

Re: [PATCH 1/1] platform/x86/tuxedo: Add virtual LampArray for TUXEDO NB04 devices

2024-10-01 Thread Werner Sembach
(sorry resend because thunderbird made it a html mail) Hi, Am 30.09.24 um 19:06 schrieb Benjamin Tissoires: On Sep 30 2024, Werner Sembach wrote: [...] Thinking about it, maybe it's not to bad that it only changes once udev is ready, like this udev could decide if leds should be used or if it

Re: [PATCH] drm: panel: jd9365da-h3: Remove unused num_init_cmds structure member

2024-10-01 Thread Neil Armstrong
On 30/09/2024 19:05, Hugo Villeneuve wrote: From: Hugo Villeneuve Now that the driver has been converted to use wrapped MIPI DCS functions, the num_init_cmds structure member is no longer needed, so remove it. Fixes: 35583e129995 ("drm/panel: panel-jadard-jd9365da-h3: use wrapped MIPI DCS fun

Re: [PATCH 1/1] platform/x86/tuxedo: Add virtual LampArray for TUXEDO NB04 devices

2024-10-01 Thread Werner Sembach
Hi, Am 30.09.24 um 19:06 schrieb Benjamin Tissoires: On Sep 30 2024, Werner Sembach wrote: [...] Thinking about it, maybe it's not to bad that it only changes once udev is ready, like this udev could decide if leds should be used or if it should directly be passed to OpenRGB for example, giving

Re: [PATCH v7 1/5] drm: Introduce device wedged event

2024-10-01 Thread Michal Wajdeczko
Hi, sorry for late comments, On 30.09.2024 09:38, Raag Jadav wrote: > Introduce device wedged event, which will notify userspace of wedged > (hanged/unusable) state of the DRM device through a uevent. This is > useful especially in cases where the device is no longer operating as > expected even

Re: [PATCH v3] drm/etnaviv: Request pages from DMA32 zone on addressing_limited

2024-10-01 Thread Lucas Stach
etnaviv_bind(). > > Fixes: b72af445cd38 ("drm/etnaviv: request pages from DMA32 zone when needed") > Suggested-by: Sui Jingfeng > Signed-off-by: Xiaolei Wang > --- > > change log > > v1: > > https://patchwork.kernel.org/project/dri-devel/patch/20240

Re: [PATCH 1/6] drm/sysfs: Remove version attribute

2024-10-01 Thread Heiner Kallweit
On 01.10.2024 12:01, Dmitry Baryshkov wrote: > On September 30, 2024 1:49:41 PM GMT+03:00, Heiner Kallweit > wrote: >> On 22.09.2024 16:55, Dmitry Baryshkov wrote: >>> On Sun, Sep 08, 2024 at 02:08:58PM GMT, Heiner Kallweit wrote: This undocumented attribute returns a version string which ha

[PATCH] drm/amd/pm: check return value of amdgpu_irq_add_id()

2024-10-01 Thread Igor Artemiev
amdgpu_irq_ad_id() may fail and the irq handlers will not be registered. This patch adds error code check. Found by Linux Verification Center (linuxtesting.org) with static analysis tool SVACE. Signed-off-by: Igor Artemiev --- .../drm/amd/pm/powerplay/hwmgr/smu_helper.c | 19

[PATCH] drm: renesas: rz-du: Drop DU_MCR0_DPI_OE macro

2024-10-01 Thread Biju Das
The DPI_OE bit is removed from the latest RZ/G2UL and RZ/G2L hardware manual. So, drop this macro. Signed-off-by: Biju Das --- drivers/gpu/drm/renesas/rz-du/rzg2l_du_crtc.c | 8 +--- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/drivers/gpu/drm/renesas/rz-du/rzg2l_du_crtc.c b

Re: [PATCH v15 16/19] drm/etnaviv: Call etnaviv_gem_obj_add() in ernaviv_gem_new_private()

2024-10-01 Thread Lucas Stach
GEM buffer object immediately > after it was successfully created. > > A benifit is that we only need to call etnaviv_gem_obj_add() once now, > since the ernaviv_gem_new_private() has been unified. Make the > etnaviv_gem_obj_add() static is a next nature thing. > Seeing this patch

Re: [PATCH] drm/etnaviv: Print error message if inserting IOVA address range fails

2024-10-01 Thread Lucas Stach
0) { > + dev_err(context->global->dev, > + "Insert iova failed, va: %llx, size: %zx\n", > + va, etnaviv_obj->base.size); As this might happen for a lot of buffers in a single submit and userspace might be unimpre

Re: [PATCH] Revert "drm/radeon: use GEM references instead of TTMs"

2024-10-01 Thread Mingcong Bai
Hi Huacai, 在 2024-09-29 15:50,Huacai Chen 写道: This reverts commit fd69ef05029f9beb7b031ef96e7a36970806a670. The original patch causes NULL pointer references: [ 21.620856] CPU 3 Unable to handle kernel paging request at virtual address , era == 94bf61d8, ra

Re: [PATCH v7 1/5] drm: Introduce device wedged event

2024-10-01 Thread Raag Jadav
On Tue, Oct 01, 2024 at 03:07:59PM +0300, Andy Shevchenko wrote: > On Tue, Oct 01, 2024 at 08:08:18AM +0300, Raag Jadav wrote: > > On Mon, Sep 30, 2024 at 03:59:59PM +0300, Andy Shevchenko wrote: > > > On Mon, Sep 30, 2024 at 01:08:41PM +0530, Raag Jadav wrote: > > ... > > > > > +static const cha

Re: [PATCH v15 08/19] drm/etnaviv: Fix wrong caching mode being used for non writecombine buffers

2024-10-01 Thread Lucas Stach
Am Sonntag, dem 08.09.2024 um 17:43 +0800 schrieb Sui Jingfeng: > In the etnaviv_gem_vmap_impl() function, the driver vmap whatever buffers > with write combine(WC) page property. This is incorrect, as some platforms > are cached coherent. Cached buffers should be mapped with cached page > property

Re: [PATCH 1/6] drm/sysfs: Remove version attribute

2024-10-01 Thread Dmitry Baryshkov
On October 1, 2024 2:07:28 PM GMT+03:00, Heiner Kallweit wrote: >On 01.10.2024 12:01, Dmitry Baryshkov wrote: >> On September 30, 2024 1:49:41 PM GMT+03:00, Heiner Kallweit >> wrote: >>> On 22.09.2024 16:55, Dmitry Baryshkov wrote: On Sun, Sep 08, 2024 at 02:08:58PM GMT, Heiner Kallweit wr

Re: [PATCH v15 04/19] drm/etnaviv: Make etnaviv_gem_prime_vmap() a static function

2024-10-01 Thread Sui Jingfeng
intermidiate layer function, it has no direct relation ship with the PRIME. The etnaviv_gem_prime.c file already has etnaviv_gem_prime_vmap_impl() as the implementation to vmap a imported GEM buffer object. I don't agree with the premise with this patch. I think it is a fact, not a premise.

Re: [PATCH v15 02/19] drm/etnaviv: Export drm_gem_print_info() and use it

2024-10-01 Thread Lucas Stach
info(struct drm_printer *p, unsigned > int indent, > if (obj->funcs->print_info) > obj->funcs->print_info(p, indent, obj); > } > +EXPORT_SYMBOL(drm_gem_print_info); This needs to be a separate patch. I don't think I can take such a change inter

Re: [PATCH v3] drm/etnaviv: Request pages from DMA32 zone on addressing_limited

2024-10-01 Thread xiaolei wang
ed-by: Sui Jingfeng Signed-off-by: Xiaolei Wang --- change log v1: https://patchwork.kernel.org/project/dri-devel/patch/20240806104733.2018783-1-xiaolei.w...@windriver.com/ v2: Modify the issue of not retaining GFP_USER in v1 and update the commit log. v3: Use "priv->shm_g

Re: [PATCH v15 11/19] drm/etnaviv: Add etnaviv_gem_obj_remove() helper

2024-10-01 Thread Lucas Stach
t I don't really see how this patch improves code legibility. Regards, Lucas > Signed-off-by: Sui Jingfeng > --- > drivers/gpu/drm/etnaviv/etnaviv_gem.c | 17 + > 1 file changed, 13 insertions(+), 4 deletions(-) > > diff --git a/drivers/gpu/drm/etnaviv/etn

Patch "drm/vmwgfx: Prevent unmapping active read buffers" has been added to the 6.6-stable tree

2024-10-01 Thread gregkh
This is a note to let you know that I've just added the patch titled drm/vmwgfx: Prevent unmapping active read buffers to the 6.6-stable tree which can be found at: http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary The filename of the patch is:

<    9   10   11   12   13   14   15   16   17   18   >