Re: [PATCH][drm-next] drm/pl111: make structure pl111_display_funcs static

2017-05-23 Thread Daniel Vetter
On Tue, May 23, 2017 at 11:31:22AM +0300, Dan Carpenter wrote: > On Tue, May 23, 2017 at 11:19:58AM +0300, Jani Nikula wrote: > > On Fri, 19 May 2017, Dan Carpenter wrote: > > > On Fri, May 19, 2017 at 01:08:20PM -0700, Eric Anholt wrote: > > >> OK, that's definitely not

Re: [PATCH][drm-next] drm/pl111: make structure pl111_display_funcs static

2017-05-23 Thread Dan Carpenter
On Tue, May 23, 2017 at 11:19:58AM +0300, Jani Nikula wrote: > On Fri, 19 May 2017, Dan Carpenter wrote: > > On Fri, May 19, 2017 at 01:08:20PM -0700, Eric Anholt wrote: > >> OK, that's definitely not how I've read the > >> Documentation/process/submitting-patches.rst

Re: [PATCH][drm-next] drm/pl111: make structure pl111_display_funcs static

2017-05-23 Thread Jani Nikula
On Fri, 19 May 2017, Dan Carpenter wrote: > On Fri, May 19, 2017 at 01:08:20PM -0700, Eric Anholt wrote: >> OK, that's definitely not how I've read the >> Documentation/process/submitting-patches.rst description of the Fixes >> tag, which talks about bugs found with git

Re: [PATCH][drm-next] drm/pl111: make structure pl111_display_funcs static

2017-05-19 Thread Dan Carpenter
On Fri, May 19, 2017 at 01:08:20PM -0700, Eric Anholt wrote: > OK, that's definitely not how I've read the > Documentation/process/submitting-patches.rst description of the Fixes > tag, which talks about bugs found with git bisect and things that should > go to -stable. I would not have

Re: [PATCH][drm-next] drm/pl111: make structure pl111_display_funcs static

2017-05-19 Thread Eric Anholt
Dan Carpenter writes: > On Fri, May 19, 2017 at 03:03:31PM +0300, Jani Nikula wrote: >> On Fri, 19 May 2017, Colin King wrote: >> > From: Colin Ian King >> > >> > structure pl111_display_funcs can be made static as

Re: [PATCH][drm-next] drm/pl111: make structure pl111_display_funcs static

2017-05-19 Thread Dan Carpenter
On Fri, May 19, 2017 at 03:03:31PM +0300, Jani Nikula wrote: > On Fri, 19 May 2017, Colin King wrote: > > From: Colin Ian King > > > > structure pl111_display_funcs can be made static as it does not need to be > > in global scope. Fixes sparse

Re: [PATCH][drm-next] drm/pl111: make structure pl111_display_funcs static

2017-05-19 Thread Dan Carpenter
On Fri, May 19, 2017 at 11:19:03AM -0700, Eric Anholt wrote: > Jani Nikula writes: > > > On Fri, 19 May 2017, Colin King wrote: > >> From: Colin Ian King > >> > >> structure pl111_display_funcs can be made static

Re: [PATCH][drm-next] drm/pl111: make structure pl111_display_funcs static

2017-05-19 Thread Eric Anholt
Jani Nikula writes: > On Fri, 19 May 2017, Colin King wrote: >> From: Colin Ian King >> >> structure pl111_display_funcs can be made static as it does not need to be >> in global scope. Fixes sparse warning: >>

Re: [PATCH][drm-next] drm/pl111: make structure pl111_display_funcs static

2017-05-19 Thread Jani Nikula
On Fri, 19 May 2017, Colin King wrote: > From: Colin Ian King > > structure pl111_display_funcs can be made static as it does not need to be > in global scope. Fixes sparse warning: > > "warning: symbol 'pl111_display_funcs' was not declared.

[PATCH][drm-next] drm/pl111: make structure pl111_display_funcs static

2017-05-19 Thread Colin King
From: Colin Ian King structure pl111_display_funcs can be made static as it does not need to be in global scope. Fixes sparse warning: "warning: symbol 'pl111_display_funcs' was not declared. Should it be static?" Fixes: bed41005e6174d ("drm/pl111: Initial drm/kms