Re: [PATCH][next] drm/amdgpu: fix return of an uninitialized value in variable ret

2019-05-11 Thread Nathan Chancellor
On Fri, May 10, 2019 at 11:08:42AM +0100, Colin King wrote: > From: Colin Ian King > > In the case where is_enable is false and lo_base_addr is non-zero the > variable ret has not been initialized and is being checked for non-zero > and potentially garbage is being returned. Fix this by not

Re: [PATCH][next] drm/amdgpu: fix return of an uninitialized value in variable ret

2019-05-10 Thread Dan Carpenter
On Fri, May 10, 2019 at 11:08:42AM +0100, Colin King wrote: > From: Colin Ian King > > In the case where is_enable is false and lo_base_addr is non-zero the > variable ret has not been initialized and is being checked for non-zero > and potentially garbage is being returned. Fix this by not

[PATCH][next] drm/amdgpu: fix return of an uninitialized value in variable ret

2019-05-10 Thread Colin King
From: Colin Ian King In the case where is_enable is false and lo_base_addr is non-zero the variable ret has not been initialized and is being checked for non-zero and potentially garbage is being returned. Fix this by not returning ret but instead returning -EINVAL on the zero lo_base_addr case.