Re: [PATCH] [RESEND] drm/gma500: initialize gma_clock_t structures

2018-01-18 Thread Daniel Vetter
On Wed, Jan 17, 2018 at 8:44 PM, Arnd Bergmann wrote: > On Wed, Jan 17, 2018 at 3:55 PM, Daniel Vetter wrote: >> On Wed, Jan 17, 2018 at 3:36 PM, Arnd Bergmann wrote: >>> On Wed, Jan 17, 2018 at 9:27 AM, Daniel Vetter wrote: On Tue, Jan 16, 2018 at 03:57:10PM +0100, Arnd Bergmann wrote: >>

Re: [PATCH] [RESEND] drm/gma500: initialize gma_clock_t structures

2018-01-18 Thread Arnd Bergmann
On Wed, Jan 17, 2018 at 3:55 PM, Daniel Vetter wrote: > On Wed, Jan 17, 2018 at 3:36 PM, Arnd Bergmann wrote: >> On Wed, Jan 17, 2018 at 9:27 AM, Daniel Vetter wrote: >>> On Tue, Jan 16, 2018 at 03:57:10PM +0100, Arnd Bergmann wrote: The two functions pass a partially initialized structure

Re: [PATCH] [RESEND] drm/gma500: initialize gma_clock_t structures

2018-01-17 Thread Daniel Vetter
On Wed, Jan 17, 2018 at 3:36 PM, Arnd Bergmann wrote: > On Wed, Jan 17, 2018 at 9:27 AM, Daniel Vetter wrote: >> On Tue, Jan 16, 2018 at 03:57:10PM +0100, Arnd Bergmann wrote: >>> The two functions pass a partially initialized structure back to the >>> caller after a memset() on the destination.

Re: [PATCH] [RESEND] drm/gma500: initialize gma_clock_t structures

2018-01-17 Thread Arnd Bergmann
On Wed, Jan 17, 2018 at 9:27 AM, Daniel Vetter wrote: > On Tue, Jan 16, 2018 at 03:57:10PM +0100, Arnd Bergmann wrote: >> The two functions pass a partially initialized structure back to the >> caller after a memset() on the destination. >> >> This is not entirely well-defined, most compilers are

Re: [PATCH] [RESEND] drm/gma500: initialize gma_clock_t structures

2018-01-17 Thread Daniel Vetter
On Tue, Jan 16, 2018 at 03:57:10PM +0100, Arnd Bergmann wrote: > The two functions pass a partially initialized structure back to the > caller after a memset() on the destination. > > This is not entirely well-defined, most compilers are sensible enough > to either keep the zero-initialization for

Re: [PATCH] [RESEND] drm/gma500: initialize gma_clock_t structures

2018-01-17 Thread Patrik Jakobsson
On Tue, Jan 16, 2018 at 3:57 PM, Arnd Bergmann wrote: > The two functions pass a partially initialized structure back to the > caller after a memset() on the destination. > > This is not entirely well-defined, most compilers are sensible enough > to either keep the zero-initialization for the unin

[PATCH] [RESEND] drm/gma500: initialize gma_clock_t structures

2018-01-16 Thread Arnd Bergmann
The two functions pass a partially initialized structure back to the caller after a memset() on the destination. This is not entirely well-defined, most compilers are sensible enough to either keep the zero-initialization for the uninitialized members, but gcc-4.4 does not, and it warns about this