On 7/24/19 10:33 AM, Pavel Machek wrote:
> Hi!
>
> +++ b/drivers/leds/trigger/ledtrig-backlight.c
> @@ -114,6 +114,8 @@ static int bl_trig_activate(struct led_classdev *led)
> n->old_status = UNBLANK;
> n->notifier.notifier_call = fb_notifier_callback;
>
> +
Hi!
> >>> +++ b/drivers/leds/trigger/ledtrig-backlight.c
> >>> @@ -114,6 +114,8 @@ static int bl_trig_activate(struct led_classdev *led)
> >>> n->old_status = UNBLANK;
> >>> n->notifier.notifier_call = fb_notifier_callback;
> >>>
> >>> + led_set_brightness(led, LED_ON);
> >>> +
> >>
> >>
Hi!
> >> This looks fishy.
> >>
> >> Maybe you should use a default-state = "keep" instead? (and you'll have
> >> to support it in the LED driver).
> >>
> >> That'll give you proper "don't touch the LED if it was turned on" behavior,
> >> which is what you seem to want.
> >
> > Actually no,
Hi Pavel,
On 7/22/19 9:50 AM, Pavel Machek wrote:
> Hi!
>
>>> Configuring backlight trigger from dts results in backlight off during
>>> boot. Machine looks dead upon boot, which is not good.
>>>
>>> Fix that by enabling LED on trigger activation.
>
>>> +++
Hi!
> > Configuring backlight trigger from dts results in backlight off during
> > boot. Machine looks dead upon boot, which is not good.
> >
> > Fix that by enabling LED on trigger activation.
> > +++ b/drivers/leds/trigger/ledtrig-backlight.c
> > @@ -114,6 +114,8 @@ static int
Hi Pavel,
The commit log is lacking the proper "leds: triggers: ".
Also...
On Thu, 2019-07-18 at 21:08 +0200, Pavel Machek wrote:
> Configuring backlight trigger from dts results in backlight off during
> boot. Machine looks dead upon boot, which is not good.
>
> Fix that by enabling LED on
Configuring backlight trigger from dts results in backlight off during
boot. Machine looks dead upon boot, which is not good.
Fix that by enabling LED on trigger activation.
Signed-off-by: Pavel Machek
diff --git a/drivers/leds/trigger/ledtrig-backlight.c
