Re: [PATCH] accel/habanalabs: Remove redundant pci_clear_master

2023-03-23 Thread Oded Gabbay
On Thu, Mar 23, 2023 at 12:29 PM Stanislaw Gruszka wrote: > > On Thu, Mar 23, 2023 at 04:35:49PM +0800, Cai Huoqing wrote: > > Remove pci_clear_master to simplify the code, > > the bus-mastering is also cleared in do_pci_disable_device, > > like this: > > ./drivers/pci/pci.c:2197 > > static void

Re: [PATCH] accel/habanalabs: Remove redundant pci_clear_master

2023-03-23 Thread Stanislaw Gruszka
On Thu, Mar 23, 2023 at 04:35:49PM +0800, Cai Huoqing wrote: > Remove pci_clear_master to simplify the code, > the bus-mastering is also cleared in do_pci_disable_device, > like this: > ./drivers/pci/pci.c:2197 > static void do_pci_disable_device(struct pci_dev *dev) > { > u16 pci_command; >

[PATCH] accel/habanalabs: Remove redundant pci_clear_master

2023-03-23 Thread Cai Huoqing
Remove pci_clear_master to simplify the code, the bus-mastering is also cleared in do_pci_disable_device, like this: ./drivers/pci/pci.c:2197 static void do_pci_disable_device(struct pci_dev *dev) { u16 pci_command; pci_read_config_word(dev, PCI_COMMAND, _command); if