Re: [PATCH] backlight: pwm_bl: configure pwm only once per backlight toggle

2019-10-23 Thread Uwe Kleine-König
On Wed, Oct 23, 2019 at 11:23:11AM -0300, Fabio Estevam wrote: > On Wed, Oct 23, 2019 at 11:16 AM Adam Ford wrote: > > > What is the plan to address the regression for 5.4? I wasn't sure if > > we're going to apply the i.mx fixes or temporarily revert the > > offending patch, or something else.

Re: [PATCH] backlight: pwm_bl: configure pwm only once per backlight toggle

2019-10-23 Thread Fabio Estevam
On Wed, Oct 23, 2019 at 11:16 AM Adam Ford wrote: > What is the plan to address the regression for 5.4? I wasn't sure if > we're going to apply the i.mx fixes or temporarily revert the > offending patch, or something else. (or maybe nothing at all) Yes, I do see the regression on a imx53 board

Re: [PATCH] backlight: pwm_bl: configure pwm only once per backlight toggle

2019-10-23 Thread Adam Ford
On Fri, Oct 18, 2019 at 4:36 AM Michal Vokáč wrote: > > On 17. 10. 19 19:44, Adam Ford wrote: > > On Thu, Oct 17, 2019 at 12:13 PM Thierry Reding > > wrote: > >> > >> On Thu, Oct 17, 2019 at 12:07:21PM -0500, Adam Ford wrote: > >>> On Thu, Oct 17, 2019 at 10:14 AM Thierry Reding > >>> wrote: >

Re: [PATCH] backlight: pwm_bl: configure pwm only once per backlight toggle

2019-10-18 Thread Michal Vokáč
On 17. 10. 19 11:48, Michal Vokáč wrote: On 17. 10. 19 10:10, Uwe Kleine-König wrote: A previous change in the pwm core (namely 01ccf903edd6 ("pwm: Let pwm_get_state() return the last implemented state")) changed the semantic of pwm_get_state() and disclosed an (as it seems) common problem in

Re: [PATCH] backlight: pwm_bl: configure pwm only once per backlight toggle

2019-10-18 Thread Michal Vokáč
On 17. 10. 19 19:44, Adam Ford wrote: On Thu, Oct 17, 2019 at 12:13 PM Thierry Reding wrote: On Thu, Oct 17, 2019 at 12:07:21PM -0500, Adam Ford wrote: On Thu, Oct 17, 2019 at 10:14 AM Thierry Reding wrote: On Thu, Oct 17, 2019 at 03:58:25PM +0200, Michal Vokáč wrote: On 17. 10. 19

Re: [PATCH] backlight: pwm_bl: configure pwm only once per backlight toggle

2019-10-18 Thread Michal Vokáč
On 17. 10. 19 14:59, Thierry Reding wrote: On Thu, Oct 17, 2019 at 02:09:17PM +0200, Uwe Kleine-König wrote: On Thu, Oct 17, 2019 at 01:11:31PM +0200, Thierry Reding wrote: On Thu, Oct 17, 2019 at 12:11:16PM +0200, Uwe Kleine-König wrote: On Thu, Oct 17, 2019 at 11:48:08AM +0200, Michal Vokáč

Re: [PATCH] backlight: pwm_bl: configure pwm only once per backlight toggle

2019-10-18 Thread Michal Vokáč
On 17. 10. 19 10:10, Uwe Kleine-König wrote: A previous change in the pwm core (namely 01ccf903edd6 ("pwm: Let pwm_get_state() return the last implemented state")) changed the semantic of pwm_get_state() and disclosed an (as it seems) common problem in lowlevel PWM drivers. By not relying on the

Re: [PATCH] backlight: pwm_bl: configure pwm only once per backlight toggle

2019-10-17 Thread Uwe Kleine-König
Hello Thierry, On Thu, Oct 17, 2019 at 05:14:37PM +0200, Thierry Reding wrote: > On Thu, Oct 17, 2019 at 03:58:25PM +0200, Michal Vokáč wrote: > > On 17. 10. 19 14:59, Thierry Reding wrote: > > > On Thu, Oct 17, 2019 at 02:09:17PM +0200, Uwe Kleine-König wrote: > > > > On Thu, Oct 17, 2019 at

Re: [PATCH] backlight: pwm_bl: configure pwm only once per backlight toggle

2019-10-17 Thread Uwe Kleine-König
On Thu, Oct 17, 2019 at 12:59:20PM +0200, Michal Vokáč wrote: > On 17. 10. 19 11:48, Michal Vokáč wrote: > > On 17. 10. 19 10:10, Uwe Kleine-König wrote: > > > A previous change in the pwm core (namely 01ccf903edd6 ("pwm: Let > > > pwm_get_state() return the last implemented state")) changed the >

Re: [PATCH] backlight: pwm_bl: configure pwm only once per backlight toggle

2019-10-17 Thread Uwe Kleine-König
Hello Thierry, On Thu, Oct 17, 2019 at 02:59:32PM +0200, Thierry Reding wrote: > On Thu, Oct 17, 2019 at 02:09:17PM +0200, Uwe Kleine-König wrote: > > On Thu, Oct 17, 2019 at 01:11:31PM +0200, Thierry Reding wrote: > > > diff --git a/drivers/pwm/pwm-imx27.c b/drivers/pwm/pwm-imx27.c > > > index

Re: [PATCH] backlight: pwm_bl: configure pwm only once per backlight toggle

2019-10-17 Thread Uwe Kleine-König
On Thu, Oct 17, 2019 at 02:18:02PM +0100, Daniel Thompson wrote: > On Thu, Oct 17, 2019 at 02:19:45PM +0200, Uwe Kleine-König wrote: > > On Thu, Oct 17, 2019 at 12:47:27PM +0100, Daniel Thompson wrote: > > > On Thu, Oct 17, 2019 at 10:10:59AM +0200, Uwe Kleine-König wrote: > > > > A previous

Re: [PATCH] backlight: pwm_bl: configure pwm only once per backlight toggle

2019-10-17 Thread Adam Ford
On Thu, Oct 17, 2019 at 12:13 PM Thierry Reding wrote: > > On Thu, Oct 17, 2019 at 12:07:21PM -0500, Adam Ford wrote: > > On Thu, Oct 17, 2019 at 10:14 AM Thierry Reding > > wrote: > > > > > > On Thu, Oct 17, 2019 at 03:58:25PM +0200, Michal Vokáč wrote: > > > > On 17. 10. 19 14:59, Thierry

Re: [PATCH] backlight: pwm_bl: configure pwm only once per backlight toggle

2019-10-17 Thread Thierry Reding
On Thu, Oct 17, 2019 at 12:07:21PM -0500, Adam Ford wrote: > On Thu, Oct 17, 2019 at 10:14 AM Thierry Reding > wrote: > > > > On Thu, Oct 17, 2019 at 03:58:25PM +0200, Michal Vokáč wrote: > > > On 17. 10. 19 14:59, Thierry Reding wrote: > > > > On Thu, Oct 17, 2019 at 02:09:17PM +0200, Uwe

Re: [PATCH] backlight: pwm_bl: configure pwm only once per backlight toggle

2019-10-17 Thread Adam Ford
On Thu, Oct 17, 2019 at 10:14 AM Thierry Reding wrote: > > On Thu, Oct 17, 2019 at 03:58:25PM +0200, Michal Vokáč wrote: > > On 17. 10. 19 14:59, Thierry Reding wrote: > > > On Thu, Oct 17, 2019 at 02:09:17PM +0200, Uwe Kleine-König wrote: > > > > On Thu, Oct 17, 2019 at 01:11:31PM +0200, Thierry

Re: [PATCH] backlight: pwm_bl: configure pwm only once per backlight toggle

2019-10-17 Thread Thierry Reding
On Thu, Oct 17, 2019 at 03:58:25PM +0200, Michal Vokáč wrote: > On 17. 10. 19 14:59, Thierry Reding wrote: > > On Thu, Oct 17, 2019 at 02:09:17PM +0200, Uwe Kleine-König wrote: > > > On Thu, Oct 17, 2019 at 01:11:31PM +0200, Thierry Reding wrote: > > > > On Thu, Oct 17, 2019 at 12:11:16PM +0200,

Re: [PATCH] backlight: pwm_bl: configure pwm only once per backlight toggle

2019-10-17 Thread Adam Ford
On Thu, Oct 17, 2019 at 3:11 AM Uwe Kleine-König wrote: > > A previous change in the pwm core (namely 01ccf903edd6 ("pwm: Let > pwm_get_state() return the last implemented state")) changed the > semantic of pwm_get_state() and disclosed an (as it seems) common > problem in lowlevel PWM drivers.

Re: [PATCH] backlight: pwm_bl: configure pwm only once per backlight toggle

2019-10-17 Thread Adam Ford
On Thu, Oct 17, 2019 at 8:30 AM Adam Ford wrote: > > On Thu, Oct 17, 2019 at 6:11 AM Thierry Reding > wrote: > > > > On Thu, Oct 17, 2019 at 12:11:16PM +0200, Uwe Kleine-König wrote: > > > On Thu, Oct 17, 2019 at 11:48:08AM +0200, Michal Vokáč wrote: > > > > On 17. 10. 19 10:10, Uwe

Re: [PATCH] backlight: pwm_bl: configure pwm only once per backlight toggle

2019-10-17 Thread Adam Ford
On Thu, Oct 17, 2019 at 6:11 AM Thierry Reding wrote: > > On Thu, Oct 17, 2019 at 12:11:16PM +0200, Uwe Kleine-König wrote: > > On Thu, Oct 17, 2019 at 11:48:08AM +0200, Michal Vokáč wrote: > > > On 17. 10. 19 10:10, Uwe Kleine-König wrote: > > > > A previous change in the pwm core (namely

Re: [PATCH] backlight: pwm_bl: configure pwm only once per backlight toggle

2019-10-17 Thread Daniel Thompson
On Thu, Oct 17, 2019 at 02:19:45PM +0200, Uwe Kleine-König wrote: > On Thu, Oct 17, 2019 at 12:47:27PM +0100, Daniel Thompson wrote: > > On Thu, Oct 17, 2019 at 10:10:59AM +0200, Uwe Kleine-König wrote: > > > A previous change in the pwm core (namely 01ccf903edd6 ("pwm: Let > > > pwm_get_state()

Re: [PATCH] backlight: pwm_bl: configure pwm only once per backlight toggle

2019-10-17 Thread Adam Ford
On Thu, Oct 17, 2019 at 8:05 AM Thierry Reding wrote: > > On Thu, Oct 17, 2019 at 07:40:47AM -0500, Adam Ford wrote: > > On Thu, Oct 17, 2019 at 7:34 AM Adam Ford wrote: > > > > > > On Thu, Oct 17, 2019 at 7:19 AM Uwe Kleine-König > > > wrote: > > > > > > > > On Thu, Oct 17, 2019 at 12:47:27PM

Re: [PATCH] backlight: pwm_bl: configure pwm only once per backlight toggle

2019-10-17 Thread Thierry Reding
On Thu, Oct 17, 2019 at 07:40:47AM -0500, Adam Ford wrote: > On Thu, Oct 17, 2019 at 7:34 AM Adam Ford wrote: > > > > On Thu, Oct 17, 2019 at 7:19 AM Uwe Kleine-König > > wrote: > > > > > > On Thu, Oct 17, 2019 at 12:47:27PM +0100, Daniel Thompson wrote: > > > > On Thu, Oct 17, 2019 at

Re: [PATCH] backlight: pwm_bl: configure pwm only once per backlight toggle

2019-10-17 Thread Thierry Reding
On Thu, Oct 17, 2019 at 02:09:17PM +0200, Uwe Kleine-König wrote: > On Thu, Oct 17, 2019 at 01:11:31PM +0200, Thierry Reding wrote: > > On Thu, Oct 17, 2019 at 12:11:16PM +0200, Uwe Kleine-König wrote: > > > On Thu, Oct 17, 2019 at 11:48:08AM +0200, Michal Vokáč wrote: > > > > On 17. 10. 19 10:10,

Re: [PATCH] backlight: pwm_bl: configure pwm only once per backlight toggle

2019-10-17 Thread Adam Ford
On Thu, Oct 17, 2019 at 3:11 AM Uwe Kleine-König wrote: > > A previous change in the pwm core (namely 01ccf903edd6 ("pwm: Let > pwm_get_state() return the last implemented state")) changed the > semantic of pwm_get_state() and disclosed an (as it seems) common > problem in lowlevel PWM drivers.

Re: [PATCH] backlight: pwm_bl: configure pwm only once per backlight toggle

2019-10-17 Thread Adam Ford
On Thu, Oct 17, 2019 at 7:34 AM Adam Ford wrote: > > On Thu, Oct 17, 2019 at 7:19 AM Uwe Kleine-König > wrote: > > > > On Thu, Oct 17, 2019 at 12:47:27PM +0100, Daniel Thompson wrote: > > > On Thu, Oct 17, 2019 at 10:10:59AM +0200, Uwe Kleine-König wrote: > > > > A previous change in the pwm

Re: [PATCH] backlight: pwm_bl: configure pwm only once per backlight toggle

2019-10-17 Thread Adam Ford
On Thu, Oct 17, 2019 at 7:19 AM Uwe Kleine-König wrote: > > On Thu, Oct 17, 2019 at 12:47:27PM +0100, Daniel Thompson wrote: > > On Thu, Oct 17, 2019 at 10:10:59AM +0200, Uwe Kleine-König wrote: > > > A previous change in the pwm core (namely 01ccf903edd6 ("pwm: Let > > > pwm_get_state() return

Re: [PATCH] backlight: pwm_bl: configure pwm only once per backlight toggle

2019-10-17 Thread Uwe Kleine-König
On Thu, Oct 17, 2019 at 12:47:27PM +0100, Daniel Thompson wrote: > On Thu, Oct 17, 2019 at 10:10:59AM +0200, Uwe Kleine-König wrote: > > A previous change in the pwm core (namely 01ccf903edd6 ("pwm: Let > > pwm_get_state() return the last implemented state")) changed the > > semantic of

Re: [PATCH] backlight: pwm_bl: configure pwm only once per backlight toggle

2019-10-17 Thread Uwe Kleine-König
On Thu, Oct 17, 2019 at 01:11:31PM +0200, Thierry Reding wrote: > On Thu, Oct 17, 2019 at 12:11:16PM +0200, Uwe Kleine-König wrote: > > On Thu, Oct 17, 2019 at 11:48:08AM +0200, Michal Vokáč wrote: > > > On 17. 10. 19 10:10, Uwe Kleine-König wrote: > > > > A previous change in the pwm core (namely

Re: [PATCH] backlight: pwm_bl: configure pwm only once per backlight toggle

2019-10-17 Thread Daniel Thompson
On Thu, Oct 17, 2019 at 10:10:59AM +0200, Uwe Kleine-König wrote: > A previous change in the pwm core (namely 01ccf903edd6 ("pwm: Let > pwm_get_state() return the last implemented state")) changed the > semantic of pwm_get_state() and disclosed an (as it seems) common > problem in lowlevel PWM

Re: [PATCH] backlight: pwm_bl: configure pwm only once per backlight toggle

2019-10-17 Thread Thierry Reding
On Thu, Oct 17, 2019 at 12:11:16PM +0200, Uwe Kleine-König wrote: > On Thu, Oct 17, 2019 at 11:48:08AM +0200, Michal Vokáč wrote: > > On 17. 10. 19 10:10, Uwe Kleine-König wrote: > > > A previous change in the pwm core (namely 01ccf903edd6 ("pwm: Let > > > pwm_get_state() return the last

Re: [PATCH] backlight: pwm_bl: configure pwm only once per backlight toggle

2019-10-17 Thread Uwe Kleine-König
On Thu, Oct 17, 2019 at 11:48:08AM +0200, Michal Vokáč wrote: > On 17. 10. 19 10:10, Uwe Kleine-König wrote: > > A previous change in the pwm core (namely 01ccf903edd6 ("pwm: Let > > pwm_get_state() return the last implemented state")) changed the > > semantic of pwm_get_state() and disclosed an

[PATCH] backlight: pwm_bl: configure pwm only once per backlight toggle

2019-10-17 Thread Uwe Kleine-König
A previous change in the pwm core (namely 01ccf903edd6 ("pwm: Let pwm_get_state() return the last implemented state")) changed the semantic of pwm_get_state() and disclosed an (as it seems) common problem in lowlevel PWM drivers. By not relying on the period and duty cycle being retrievable from a