Re: [PATCH] dma-buf/sw_sync: Add a reference when adding fence to timeline list

2024-06-20 Thread Thadeu Lima de Souza Cascardo
On Thu, Jun 20, 2024 at 03:50:58PM -0300, Thadeu Lima de Souza Cascardo wrote: > On Wed, Jun 19, 2024 at 01:14:38PM +0100, Tvrtko Ursulin wrote: > > > > On 14/06/2024 19:00, Thadeu Lima de Souza Cascardo wrote: > > > On Fri, Jun 14, 2024 at 11:52:03AM +0100, Tvrtko Ursulin wrote: > > > > > > > >

Re: [PATCH] dma-buf/sw_sync: Add a reference when adding fence to timeline list

2024-06-20 Thread Thadeu Lima de Souza Cascardo
On Wed, Jun 19, 2024 at 01:14:38PM +0100, Tvrtko Ursulin wrote: > > On 14/06/2024 19:00, Thadeu Lima de Souza Cascardo wrote: > > On Fri, Jun 14, 2024 at 11:52:03AM +0100, Tvrtko Ursulin wrote: > > > > > > On 24/03/2024 10:15, Thadeu Lima de Souza Cascardo wrote: > > > > commit e531fdb5cd5e ("dma

Re: [PATCH] dma-buf/sw_sync: Add a reference when adding fence to timeline list

2024-06-19 Thread Tvrtko Ursulin
On 14/06/2024 19:00, Thadeu Lima de Souza Cascardo wrote: On Fri, Jun 14, 2024 at 11:52:03AM +0100, Tvrtko Ursulin wrote: On 24/03/2024 10:15, Thadeu Lima de Souza Cascardo wrote: commit e531fdb5cd5e ("dma-buf/sw_sync: Avoid recursive lock during fence signal") fixed a recursive locking when

Re: [PATCH] dma-buf/sw_sync: Add a reference when adding fence to timeline list

2024-06-14 Thread Thadeu Lima de Souza Cascardo
On Fri, Jun 14, 2024 at 11:52:03AM +0100, Tvrtko Ursulin wrote: > > On 24/03/2024 10:15, Thadeu Lima de Souza Cascardo wrote: > > commit e531fdb5cd5e ("dma-buf/sw_sync: Avoid recursive lock during fence > > signal") fixed a recursive locking when a signal callback released a fence. > > It did it b

Re: [PATCH] dma-buf/sw_sync: Add a reference when adding fence to timeline list

2024-06-14 Thread Tvrtko Ursulin
On 24/03/2024 10:15, Thadeu Lima de Souza Cascardo wrote: commit e531fdb5cd5e ("dma-buf/sw_sync: Avoid recursive lock during fence signal") fixed a recursive locking when a signal callback released a fence. It did it by taking an extra reference while traversing it on the list and holding the t

[PATCH] dma-buf/sw_sync: Add a reference when adding fence to timeline list

2024-03-24 Thread Thadeu Lima de Souza Cascardo
commit e531fdb5cd5e ("dma-buf/sw_sync: Avoid recursive lock during fence signal") fixed a recursive locking when a signal callback released a fence. It did it by taking an extra reference while traversing it on the list and holding the timeline lock. However, this is racy and may end up adding to