Re: [PATCH] dma-buf/sync_file: Don't leak fences on merge failure

2021-07-12 Thread Jason Ekstrand
No worries. Thanks for pushing! On Mon, Jul 12, 2021 at 6:37 AM Christian König wrote: > > Sorry for the vacation and sick leave induced delay. > > I've just pushed this to drm-misc-fixes. > > Thanks, > Christian. > > Am 24.06.21 um 21:43 schrieb Jason Ekstrand: > > I don't have drm-misc

Re: [PATCH] dma-buf/sync_file: Don't leak fences on merge failure

2021-07-12 Thread Christian König
Sorry for the vacation and sick leave induced delay. I've just pushed this to drm-misc-fixes. Thanks, Christian. Am 24.06.21 um 21:43 schrieb Jason Ekstrand: I don't have drm-misc access. Mind pushing? On Thu, Jun 24, 2021 at 12:59 PM Christian König wrote: Am 24.06.21 um 19:47 schrieb

Re: [PATCH] dma-buf/sync_file: Don't leak fences on merge failure

2021-06-24 Thread Jason Ekstrand
I don't have drm-misc access. Mind pushing? On Thu, Jun 24, 2021 at 12:59 PM Christian König wrote: > > Am 24.06.21 um 19:47 schrieb Jason Ekstrand: > > Each add_fence() call does a dma_fence_get() on the relevant fence. In > > the error path, we weren't calling dma_fence_put() so all those

Re: [PATCH] dma-buf/sync_file: Don't leak fences on merge failure

2021-06-24 Thread Christian König
Am 24.06.21 um 19:47 schrieb Jason Ekstrand: Each add_fence() call does a dma_fence_get() on the relevant fence. In the error path, we weren't calling dma_fence_put() so all those fences got leaked. Also, in the krealloc_array failure case, we weren't freeing the fences array. Instead, ensure

[PATCH] dma-buf/sync_file: Don't leak fences on merge failure

2021-06-24 Thread Jason Ekstrand
Each add_fence() call does a dma_fence_get() on the relevant fence. In the error path, we weren't calling dma_fence_put() so all those fences got leaked. Also, in the krealloc_array failure case, we weren't freeing the fences array. Instead, ensure that i and fences are always zero-initialized