Re: [PATCH] dma-buf: fix and rework dma_buf_poll v3

2021-06-23 Thread Daniel Vetter
On Wed, Jun 23, 2021 at 2:42 PM Christian König wrote: > > Am 23.06.21 um 13:30 schrieb Daniel Vetter: > > On Wed, Jun 23, 2021 at 1:17 PM Christian König > > wrote: > >> Am 22.06.21 um 19:02 schrieb Daniel Vetter: > >>> On Tue, Jun 22, 2021 at 3:07 PM Christian König > >>> wrote: > Crap,

Re: [PATCH] dma-buf: fix and rework dma_buf_poll v3

2021-06-23 Thread Christian König
Am 23.06.21 um 13:30 schrieb Daniel Vetter: On Wed, Jun 23, 2021 at 1:17 PM Christian König wrote: Am 22.06.21 um 19:02 schrieb Daniel Vetter: On Tue, Jun 22, 2021 at 3:07 PM Christian König wrote: Crap, hit enter to early before adding a cover letter. This is the same patch as before, but

Re: [PATCH] dma-buf: fix and rework dma_buf_poll v3

2021-06-23 Thread Daniel Vetter
On Wed, Jun 23, 2021 at 1:17 PM Christian König wrote: > > Am 22.06.21 um 19:02 schrieb Daniel Vetter: > > On Tue, Jun 22, 2021 at 3:07 PM Christian König > > wrote: > >> Crap, hit enter to early before adding a cover letter. > >> > >> This is the same patch as before, but as requested I'm

Re: [PATCH] dma-buf: fix and rework dma_buf_poll v3

2021-06-23 Thread Christian König
Am 22.06.21 um 19:02 schrieb Daniel Vetter: On Tue, Jun 22, 2021 at 3:07 PM Christian König wrote: Crap, hit enter to early before adding a cover letter. This is the same patch as before, but as requested I'm keeping the exclusive fence handling as it is for now. Daniel can you double check

Re: [PATCH] dma-buf: fix and rework dma_buf_poll v3

2021-06-23 Thread Dan Carpenter
Hi "Christian, url: https://github.com/0day-ci/linux/commits/Christian-K-nig/dma-buf-fix-and-rework-dma_buf_poll-v3/20210622-210643 base: git://anongit.freedesktop.org/tegra/linux.git drm/tegra/for-next config: i386-randconfig-m021-20210622 (attached as .config) compiler: gcc-9 (Debian

Re: [PATCH] dma-buf: fix and rework dma_buf_poll v3

2021-06-22 Thread Daniel Vetter
On Tue, Jun 22, 2021 at 3:07 PM Christian König wrote: > > Crap, hit enter to early before adding a cover letter. > > This is the same patch as before, but as requested I'm keeping the > exclusive fence handling as it is for now. > > Daniel can you double check this and/or make sure that it is

Re: [PATCH] dma-buf: fix and rework dma_buf_poll v3

2021-06-22 Thread Christian König
Crap, hit enter to early before adding a cover letter. This is the same patch as before, but as requested I'm keeping the exclusive fence handling as it is for now. Daniel can you double check this and/or make sure that it is tested? I only smoke tested it and the code is so complicated that

[PATCH] dma-buf: fix and rework dma_buf_poll v3

2021-06-22 Thread Christian König
Daniel pointed me towards this function and there are multiple obvious problems in the implementation. First of all the retry loop is not working as intended. In general the retry makes only sense if you grab the reference first and then check the sequence values. It's also good practice to keep