Re: [PATCH] drm/amd/display: add parameter backlight_min

2022-11-13 Thread Filip Moc
On Tue, Nov 01, 2022 at 12:06:55PM -0400, Alex Deucher wrote: > On Tue, Nov 1, 2022 at 11:42 AM Filip Moc wrote: > > > > Hello Alex, > > > > thank you for your response. > > > > Yes, I have HP ENVY x360 Convertible 13-ay1xxx, and backlight_min=2 > > seems to work the best in my case. > > > > I

Re: [PATCH] drm/amd/display: add parameter backlight_min

2022-11-02 Thread Harry Wentland
On 2022-11-01 11:33, Filip Moc wrote: > Hello Harry, > > thank you for your response. > >> amdgpu.backlight_min=2:-1 > > almost :-) > > Array elements in module parameters are separated by commas not colons. > So for cmdline it should look like this: > amdgpu.backlight_min=2,-1 > > Though

Re: [PATCH] drm/amd/display: add parameter backlight_min

2022-11-01 Thread Alex Deucher
On Tue, Nov 1, 2022 at 11:42 AM Filip Moc wrote: > > Hello Alex, > > thank you for your response. > > Yes, I have HP ENVY x360 Convertible 13-ay1xxx, and backlight_min=2 > seems to work the best in my case. > > I added a dmi based quirk table. So far with support only for display 0 > to make it

Re: [PATCH] drm/amd/display: add parameter backlight_min

2022-11-01 Thread Filip Moc
Hello Alex, thank you for your response. Yes, I have HP ENVY x360 Convertible 13-ay1xxx, and backlight_min=2 seems to work the best in my case. I added a dmi based quirk table. So far with support only for display 0 to make it simple. Support for more displays in quirk table can be added later

Re: [PATCH] drm/amd/display: add parameter backlight_min

2022-11-01 Thread Filip Moc
Hello Harry, thank you for your response. > amdgpu.backlight_min=2:-1 almost :-) Array elements in module parameters are separated by commas not colons. So for cmdline it should look like this: amdgpu.backlight_min=2,-1 Though you can just drop the ,-1 relying on kernel leaving the rest of

Re: [PATCH] drm/amd/display: add parameter backlight_min

2022-10-31 Thread Alex Deucher
On Sun, Oct 30, 2022 at 5:26 AM Filip Moc wrote: > > There are some devices on which amdgpu won't allow user to set brightness > to sufficiently low values even though the hardware would support it just > fine. > > This usually happens in two cases when either configuration of brightness > levels

Re: [PATCH] drm/amd/display: add parameter backlight_min

2022-10-31 Thread Harry Wentland
On 2022-10-29 15:13, Filip Moc wrote: > There are some devices on which amdgpu won't allow user to set brightness > to sufficiently low values even though the hardware would support it just > fine. > > This usually happens in two cases when either configuration of brightness > levels via

[PATCH] drm/amd/display: add parameter backlight_min

2022-10-30 Thread Filip Moc
There are some devices on which amdgpu won't allow user to set brightness to sufficiently low values even though the hardware would support it just fine. This usually happens in two cases when either configuration of brightness levels via ACPI/ATIF is not available and amdgpu falls back to