Hi,
On Mon, Nov 06, 2023 at 09:26:15PM +0800, oushixi...@kylinos.cn wrote:
> I think it will cause memory leaks if too many nonblock commit works return
> -EBUSY.
Do you *think* or are you sure?
If you are sure, then please write down everything I mentioned earlier
in the commit log and resend
Airlie ; Daniel
Vetter ; dri-devel@lists.freedesktop.org;
linux-ker...@vger.kernel.org
主题: Re: [PATCH] drm/atomic-helper: Call stall_checks() before allocate
drm_crtc_commit
Hi,
On Mon, Nov 06, 2023 at 03:37:42PM +0800, oushixiong wrote:
> From: Shixiong Ou
>
> Calling stall_checks
Hi,
On Mon, Nov 06, 2023 at 03:37:42PM +0800, oushixiong wrote:
> From: Shixiong Ou
>
> Calling stall_checks() before allocating drm_crtc_commit not after that.
>
> Signed-off-by: Shixiong Ou
Generally speaking, we need much more context than that.
What bug did you encounter that makes you
From: Shixiong Ou
Calling stall_checks() before allocating drm_crtc_commit not after that.
Signed-off-by: Shixiong Ou
---
drivers/gpu/drm/drm_atomic_helper.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/drm_atomic_helper.c
From: Shixiong Ou
It is wrong to call stall_checks() after allocating memory
for struct drm_crtc_commit as it will cause memory leaks if
too many nonblock commit works return -EBUSY.
So it needs to call stall_checks() before allocate drm_crtc_commit.
Signed-off-by: Shixiong Ou
---
