[PATCH] drm/atomic-helper: implementatations for legacy interfaces

2014-11-06 Thread Sean Paul
On Wed, Nov 5, 2014 at 5:01 PM, Daniel Vetter wrote: > On Wed, Nov 05, 2014 at 02:48:48PM -0500, Sean Paul wrote: >> > + if (!crtc && crtc != set->crtc) >> >> I think this should be an || > > Hm. My idea idea was actually something along the lines of > diff --git

[PATCH] drm/atomic-helper: implementatations for legacy interfaces

2014-11-05 Thread Daniel Vetter
On Wed, Nov 05, 2014 at 02:48:48PM -0500, Sean Paul wrote: > > + if (!crtc && crtc != set->crtc) > > I think this should be an || Hm. My idea idea was actually something along the lines of diff --git a/drivers/gpu/drm/drm_atomic_helper.c b/drivers/gpu/drm/drm_atomic_helper.c index

[PATCH] drm/atomic-helper: implementatations for legacy interfaces

2014-11-05 Thread Sean Paul
On Wed, Nov 05, 2014 at 02:46:10PM +0100, Daniel Vetter wrote: > Well, except page_flip since that requires async commit, which isn't > there yet. > > For the functions which changes planes there's a bit of trickery > involved to keep the fb refcounting working. But otherwise fairly >

[PATCH] drm/atomic-helper: implementatations for legacy interfaces

2014-11-05 Thread Daniel Vetter
Well, except page_flip since that requires async commit, which isn't there yet. For the functions which changes planes there's a bit of trickery involved to keep the fb refcounting working. But otherwise fairly straight-forward atomic updates. The property setting functions are still a bit

[PATCH] drm/atomic-helper: implementatations for legacy interfaces

2014-11-04 Thread Daniel Vetter
Well, except page_flip since that requires async commit, which isn't there yet. For the functions which changes planes there's a bit of trickery involved to keep the fb refcounting working. But otherwise fairly straight-forward atomic updates. The property setting functions are still a bit