Re: [PATCH] drm/bochs: add edid present check

2018-12-19 Thread Oleksandr Andrushchenko
On 12/19/18 5:21 PM, Gerd Hoffmann wrote: Hi, You could probably have a comment here explaining the magic below (just like in the commit message to ease the task of understanding while reading the code why 2 of 8 bytes of the EDID header is checked and why it is all needed). Of course one

Re: [PATCH] drm/bochs: add edid present check

2018-12-19 Thread Gerd Hoffmann
Hi, > You could probably have a comment here explaining the magic below > (just like in the commit message to ease the task of understanding > while reading the code why 2 of 8 bytes of the EDID header is checked > and why it is all needed). Of course one can use git blame... Up to you Makes

Re: [PATCH] drm/bochs: add edid present check

2018-12-19 Thread Oleksandr Andrushchenko
Hello, Gerd! On 12/18/18 9:33 AM, Gerd Hoffmann wrote: Check first two header bytes before trying to read the edid blob, to avoid the log being spammed in case qemu has no edid support (old qemu or edid turned off). Fixes: 01f23459cf drm/bochs: add edid support. Signed-off-by: Gerd Hoffmann

[PATCH] drm/bochs: add edid present check

2018-12-17 Thread Gerd Hoffmann
Check first two header bytes before trying to read the edid blob, to avoid the log being spammed in case qemu has no edid support (old qemu or edid turned off). Fixes: 01f23459cf drm/bochs: add edid support. Signed-off-by: Gerd Hoffmann --- drivers/gpu/drm/bochs/bochs_hw.c | 4 1 file