Re: [PATCH] drm/bridge: ti-sn65dsi86: Properly undo autosuspend

2022-02-28 Thread Doug Anderson
Hi, On Wed, Feb 23, 2022 at 7:55 AM Laurent Pinchart wrote: > > Hi Doug, > > On Wed, Feb 23, 2022 at 07:43:27AM -0800, Doug Anderson wrote: > > On Tue, Feb 22, 2022 at 9:08 PM Laurent Pinchart wrote: > > > On Tue, Feb 22, 2022 at 11:44:54PM +0100, Linus Walleij wrote: > > > > On Tue, Feb 22, 2022

Re: [PATCH] drm/bridge: ti-sn65dsi86: Properly undo autosuspend

2022-02-23 Thread Doug Anderson
Hi, On Wed, Feb 23, 2022 at 7:55 AM Laurent Pinchart wrote: > > > How about a middle ground, though: we could add a devm function that > > does all the magic. Somewhat recently devm_pm_runtime_enable() was > > added. What if we add a variant for those that use autosuspend, like: > > > > devm_pm_r

Re: [PATCH] drm/bridge: ti-sn65dsi86: Properly undo autosuspend

2022-02-23 Thread Laurent Pinchart
Hi Doug, On Wed, Feb 23, 2022 at 07:43:27AM -0800, Doug Anderson wrote: > On Tue, Feb 22, 2022 at 9:08 PM Laurent Pinchart wrote: > > On Tue, Feb 22, 2022 at 11:44:54PM +0100, Linus Walleij wrote: > > > On Tue, Feb 22, 2022 at 11:19 PM Douglas Anderson wrote: > > > > > > > > The PM Runtime docs sa

Re: [PATCH] drm/bridge: ti-sn65dsi86: Properly undo autosuspend

2022-02-23 Thread Doug Anderson
Hi, On Tue, Feb 22, 2022 at 9:08 PM Laurent Pinchart wrote: > > On Tue, Feb 22, 2022 at 11:44:54PM +0100, Linus Walleij wrote: > > On Tue, Feb 22, 2022 at 11:19 PM Douglas Anderson > > wrote: > > > > > > The PM Runtime docs say: > > > Drivers in ->remove() callback should undo the runtime PM

Re: [PATCH] drm/bridge: ti-sn65dsi86: Properly undo autosuspend

2022-02-22 Thread Laurent Pinchart
On Tue, Feb 22, 2022 at 11:44:54PM +0100, Linus Walleij wrote: > On Tue, Feb 22, 2022 at 11:19 PM Douglas Anderson > wrote: > > > > The PM Runtime docs say: > > Drivers in ->remove() callback should undo the runtime PM changes done > > in ->probe(). Usually this means calling pm_runtime_disab

Re: [PATCH] drm/bridge: ti-sn65dsi86: Properly undo autosuspend

2022-02-22 Thread Linus Walleij
On Tue, Feb 22, 2022 at 11:19 PM Douglas Anderson wrote: > > The PM Runtime docs say: > Drivers in ->remove() callback should undo the runtime PM changes done > in ->probe(). Usually this means calling pm_runtime_disable(), > pm_runtime_dont_use_autosuspend() etc. > > We weren't doing that f

[PATCH] drm/bridge: ti-sn65dsi86: Properly undo autosuspend

2022-02-22 Thread Douglas Anderson
The PM Runtime docs say: Drivers in ->remove() callback should undo the runtime PM changes done in ->probe(). Usually this means calling pm_runtime_disable(), pm_runtime_dont_use_autosuspend() etc. We weren't doing that for autosuspend. Let's do it. Fixes: 9bede63127c6 ("drm/bridge: ti-sn65