Re: [PATCH] drm/dbi: Print errors for mipi_dbi_command()

2021-07-02 Thread Sam Ravnborg
Hi Linus, On Fri, Jul 02, 2021 at 11:58:52AM +0200, Linus Walleij wrote: > On Fri, Jul 2, 2021 at 7:45 AM Sam Ravnborg wrote: > > > > - ret = mipi_dbi_command(dbi, MIPI_DCS_SOFT_RESET); > > > + ret = mipi_dbi_command_buf(dbi, MIPI_DCS_SOFT_RESET, NULL, 0); > > > if (ret) { > > >

Re: [PATCH] drm/dbi: Print errors for mipi_dbi_command()

2021-07-02 Thread Linus Walleij
On Fri, Jul 2, 2021 at 7:45 AM Sam Ravnborg wrote: > > - ret = mipi_dbi_command(dbi, MIPI_DCS_SOFT_RESET); > > + ret = mipi_dbi_command_buf(dbi, MIPI_DCS_SOFT_RESET, NULL, 0); > > if (ret) { > > DRM_DEV_ERROR(dev, "Failed to send reset command (%d)\n", > > ret); > >

Re: [PATCH] drm/dbi: Print errors for mipi_dbi_command()

2021-07-01 Thread Sam Ravnborg
Hi Linus, On Fri, Jul 02, 2021 at 12:25:18AM +0200, Linus Walleij wrote: > The macro mipi_dbi_command() does not report errors unless you wrap it > in another macro to do the error reporting. > > Report a rate-limited error so we know what is going on. > > Drop the only user in DRM using

[PATCH] drm/dbi: Print errors for mipi_dbi_command()

2021-07-01 Thread Linus Walleij
The macro mipi_dbi_command() does not report errors unless you wrap it in another macro to do the error reporting. Report a rate-limited error so we know what is going on. Drop the only user in DRM using mipi_dbi_command() and actually checking the error explicitly, let it use