[PATCH] drm/i915/ilk: Wait one vblank before enabling audio

2016-05-24 Thread Jani Nikula
On Mon, 23 May 2016, Lyude Paul wrote: > On Mon, 2016-05-23 at 21:06 +0300, Ville Syrjälä wrote: >> On Fri, May 20, 2016 at 05:36:40PM -0400, Lyude wrote: >> > >> > We no longer call ilk_audio_codec_enable() while we have vblanks >> > disabled. As such, we can finally fix this and stop the occa

[PATCH] drm/i915/ilk: Wait one vblank before enabling audio

2016-05-23 Thread Ville Syrjälä
On Fri, May 20, 2016 at 05:36:40PM -0400, Lyude wrote: > We no longer call ilk_audio_codec_enable() while we have vblanks > disabled. As such, we can finally fix this and stop the occasional pipe > underruns I'm seeing on this Dell OptiPlex 990. Hmm. Are you still getting underruns on -nightly? I

[PATCH] drm/i915/ilk: Wait one vblank before enabling audio

2016-05-23 Thread Lyude Paul
On Mon, 2016-05-23 at 21:06 +0300, Ville Syrjälä wrote: > On Fri, May 20, 2016 at 05:36:40PM -0400, Lyude wrote: > > > > We no longer call ilk_audio_codec_enable() while we have vblanks > > disabled. As such, we can finally fix this and stop the occasional pipe > > underruns I'm seeing on this D

[PATCH] drm/i915/ilk: Wait one vblank before enabling audio

2016-05-23 Thread Jani Nikula
On Sat, 21 May 2016, Lyude wrote: > We no longer call ilk_audio_codec_enable() while we have vblanks > disabled. As such, we can finally fix this and stop the occasional pipe > underruns I'm seeing on this Dell OptiPlex 990. > > Cc: stable at vger.kernel.org Even if this were the right fix now, I

[PATCH] drm/i915/ilk: Wait one vblank before enabling audio

2016-05-20 Thread Lyude
We no longer call ilk_audio_codec_enable() while we have vblanks disabled. As such, we can finally fix this and stop the occasional pipe underruns I'm seeing on this Dell OptiPlex 990. Cc: stable at vger.kernel.org Signed-off-by: Lyude --- drivers/gpu/drm/i915/intel_audio.c | 8 ++-- 1 file