Re: [Intel-gfx] [PATCH] drm/i915: Fix workarounds on Gen2-3

2022-11-21 Thread Tvrtko Ursulin
On 18/11/2022 17:14, Matt Roper wrote: On Fri, Nov 18, 2022 at 11:52:49AM +, Tvrtko Ursulin wrote: From: Tvrtko Ursulin In 3653727560d0 ("drm/i915: Simplify internal helper function signature") I broke the old platforms by not noticing engine workaround init does not initialize the list

Re: [PATCH] drm/i915: Fix workarounds on Gen2-3

2022-11-18 Thread Ville Syrjälä
On Fri, Nov 18, 2022 at 11:52:49AM +, Tvrtko Ursulin wrote: > From: Tvrtko Ursulin > > In 3653727560d0 ("drm/i915: Simplify internal helper function signature") > I broke the old platforms by not noticing engine workaround init does not > initialize the list on old platforms. Fix it by always

Re: [Intel-gfx] [PATCH] drm/i915: Fix workarounds on Gen2-3

2022-11-18 Thread Matt Roper
On Fri, Nov 18, 2022 at 11:52:49AM +, Tvrtko Ursulin wrote: > From: Tvrtko Ursulin > > In 3653727560d0 ("drm/i915: Simplify internal helper function signature") > I broke the old platforms by not noticing engine workaround init does not > initialize the list on old platforms. Fix it by always

[PATCH] drm/i915: Fix workarounds on Gen2-3

2022-11-18 Thread Tvrtko Ursulin
From: Tvrtko Ursulin In 3653727560d0 ("drm/i915: Simplify internal helper function signature") I broke the old platforms by not noticing engine workaround init does not initialize the list on old platforms. Fix it by always initializing which already does the right thing by mostly not doing anyth