Re: [PATCH] drm/i915: prevent generating unusable gvt build which no mpt module is selected

2017-05-28 Thread Du, Changbin
On Fri, May 26, 2017 at 12:58:55PM +0300, Jani Nikula wrote: > On Thu, 25 May 2017, "Du, Changbin" wrote: > >> Note: > >>select should be used with care. select will force > >>a symbol to a value without visiting the dependencies. > >>By abusing select you are

Re: [PATCH] drm/i915: prevent generating unusable gvt build which no mpt module is selected

2017-05-26 Thread Jani Nikula
On Thu, 25 May 2017, "Du, Changbin" wrote: > Hi, Jani, just relized you are in i915 team. :) > >> > +menu "Intel GVT-g graphics virtualization host support" >> > + depends on DRM_I915 >> > + depends on 64BIT >> > + >> > config DRM_I915_GVT >> > -bool "Enable

Re: [PATCH] drm/i915: prevent generating unusable gvt build which no mpt module is selected

2017-05-25 Thread Du, Changbin
Hi, Jani, just relized you are in i915 team. :) > > +menu "Intel GVT-g graphics virtualization host support" > > + depends on DRM_I915 > > + depends on 64BIT > > + > > config DRM_I915_GVT > > -bool "Enable Intel GVT-g graphics virtualization host support" > > -depends on

Re: [PATCH] drm/i915: prevent generating unusable gvt build which no mpt module is selected

2017-05-24 Thread Du, Changbin
On Wed, May 24, 2017 at 10:21:31AM +0100, Chris Wilson wrote: > On Wed, May 24, 2017 at 04:50:39PM +0800, changbin...@intel.com wrote: > > From: Changbin Du > > > > At least we need one MPT module (currently only have one) selected > > to get GVTg functional. When GVTg is

[PATCH] drm/i915: prevent generating unusable gvt build which no mpt module is selected

2017-05-24 Thread changbin . du
From: Changbin Du At least we need one MPT module (currently only have one) selected to get GVTg functional. When GVTg is enabled while no MPT selected, the build just includes useless GVTg code. This doesn't make sense. With this patch, a submenut is created under i915

Re: [PATCH] drm/i915: prevent generating unusable gvt build which no mpt module is selected

2017-05-24 Thread Jani Nikula
On Wed, 24 May 2017, changbin...@intel.com wrote: > From: Changbin Du > > At least we need one MPT module (currently only have one) selected > to get GVTg functional. When GVTg is enabled while no MPT selected, > the build just includes useless GVTg code. This doesn't make

Re: [PATCH] drm/i915: prevent generating unusable gvt build which no mpt module is selected

2017-05-24 Thread Zhenyu Wang
On 2017.05.24 16:50:39 +0800, changbin...@intel.com wrote: > From: Changbin Du > > At least we need one MPT module (currently only have one) selected > to get GVTg functional. When GVTg is enabled while no MPT selected, > the build just includes useless GVTg code. This

Re: [PATCH] drm/i915: prevent generating unusable gvt build which no mpt module is selected

2017-05-24 Thread Chris Wilson
On Wed, May 24, 2017 at 04:50:39PM +0800, changbin...@intel.com wrote: > From: Changbin Du > > At least we need one MPT module (currently only have one) selected > to get GVTg functional. When GVTg is enabled while no MPT selected, > the build just includes useless GVTg