[PATCH] drm/imx: imx-ldb: do not try to dereference crtc->state->state in encoder mode_set

On Mon, Jul 25, 2016 at 12:42:50PM +0200, Philipp Zabel wrote: > Am Freitag, den 22.07.2016, 18:49 +0200 schrieb Daniel Vetter: > > On Fri, Jul 22, 2016 at 12:57:15PM +0200, Philipp Zabel wrote: > > > Am Freitag, den 22.07.2016, 11:35 +0200 schrieb Daniel Vetter: > > > [...] > > > > Proper fix

[PATCH] drm/imx: imx-ldb: do not try to dereference crtc->state->state in encoder mode_set

Am Freitag, den 22.07.2016, 18:49 +0200 schrieb Daniel Vetter: > On Fri, Jul 22, 2016 at 12:57:15PM +0200, Philipp Zabel wrote: > > Am Freitag, den 22.07.2016, 11:35 +0200 schrieb Daniel Vetter: > > [...] > > > Proper fix would be to roll out atomic_ versions of all teh encoder > > > callbacks

[PATCH] drm/imx: imx-ldb: do not try to dereference crtc->state->state in encoder mode_set

On Fri, Jul 22, 2016 at 12:57:15PM +0200, Philipp Zabel wrote: > Am Freitag, den 22.07.2016, 11:35 +0200 schrieb Daniel Vetter: > [...] > > Proper fix would be to roll out atomic_ versions of all teh encoder > > callbacks where we additionally pass both the crtc state and the connector > > state.

[PATCH] drm/imx: imx-ldb: do not try to dereference crtc->state->state in encoder mode_set

Am Freitag, den 22.07.2016, 11:35 +0200 schrieb Daniel Vetter: [...] > Proper fix would be to roll out atomic_ versions of all teh encoder > callbacks where we additionally pass both the crtc state and the connector > state. Then there's no need for walking connector lists like that. And in > the

[PATCH] drm/imx: imx-ldb: do not try to dereference crtc->state->state in encoder mode_set

On Fri, Jul 22, 2016 at 10:59:51AM +0200, Philipp Zabel wrote: > The code in imx_ldb_encoder_mode_set crashes with a NULL pointer > dereference trying to access crtc->state->state, which was previously > cleared by drm_atomic_helper_swap_state: > > Unable to handle kernel NULL pointer

[PATCH] drm/imx: imx-ldb: do not try to dereference crtc->state->state in encoder mode_set

Am Freitag, den 22.07.2016, 10:59 +0200 schrieb Philipp Zabel: > + struct drm_crtc_state *crtc_state = encoder->crtc->state; Sorry, this is superfluous. I'll drop it.

[PATCH] drm/imx: imx-ldb: do not try to dereference crtc->state->state in encoder mode_set

The code in imx_ldb_encoder_mode_set crashes with a NULL pointer dereference trying to access crtc->state->state, which was previously cleared by drm_atomic_helper_swap_state: Unable to handle kernel NULL pointer dereference at virtual address 0010 pgd = ae08c000 [0010]