Re: [PATCH] drm/komeda: Fix off-by-1 when with readback conn due to rounding

2021-03-29 Thread Carsten Haitzler
On 3/12/21 10:55 AM, Brian Starkey wrote: (Adding back James again - did you use get_maintainer.pl?) On Thu, Mar 11, 2021 at 12:08:46PM +, carsten.haitz...@foss.arm.com wrote: From: Carsten Haitzler When setting up a readback connector that writes data back to memory rather than to an

Re: [PATCH] drm/komeda: Fix off-by-1 when with readback conn due to rounding

2021-03-15 Thread James Qian Wang
On Fri, Mar 12, 2021 at 10:55:21AM +, Brian Starkey wrote: > (Adding back James again - did you use get_maintainer.pl?) > > On Thu, Mar 11, 2021 at 12:08:46PM +, carsten.haitz...@foss.arm.com wrote: > > From: Carsten Haitzler > > > > When setting up a readback connector that writes data

Re: [PATCH] drm/komeda: Fix off-by-1 when with readback conn due to rounding

2021-03-12 Thread Brian Starkey
(Adding back James again - did you use get_maintainer.pl?) On Thu, Mar 11, 2021 at 12:08:46PM +, carsten.haitz...@foss.arm.com wrote: > From: Carsten Haitzler > > When setting up a readback connector that writes data back to memory > rather than to an actual output device (HDMI etc.),

[PATCH] drm/komeda: Fix off-by-1 when with readback conn due to rounding

2021-03-11 Thread carsten . haitzler
From: Carsten Haitzler When setting up a readback connector that writes data back to memory rather than to an actual output device (HDMI etc.), rounding was set to round. As the DPU uses a higher internal number of bits when generating a color value, this round-down back to 8bit ended up with

Re: [PATCH] drm/komeda: Fix off-by-1 when with readback conn due to rounding

2021-03-11 Thread Carsten Haitzler
On 3/9/21 11:36 AM, Brian Starkey wrote: Hi Carsten, (+James for komeda) Thanks for typing this up. On Fri, Mar 05, 2021 at 04:38:53PM +, carsten.haitz...@foss.arm.com wrote: From: Carsten Haitzler When setting up a readback conenctor that writes data back to memory s/readback

Re: [PATCH] drm/komeda: Fix off-by-1 when with readback conn due to rounding

2021-03-09 Thread Brian Starkey
Hi Carsten, (+James for komeda) Thanks for typing this up. On Fri, Mar 05, 2021 at 04:38:53PM +, carsten.haitz...@foss.arm.com wrote: > From: Carsten Haitzler > > When setting up a readback conenctor that writes data back to memory s/readback conenctor/writeback connector/ (similar in the

[PATCH] drm/komeda: Fix off-by-1 when with readback conn due to rounding

2021-03-05 Thread carsten . haitzler
From: Carsten Haitzler When setting up a readback conenctor that writes data back to memory rather than to an actual output device (HDMI etc.), rounding was ses to round-down. As the DPU uses a higher internal number of bits when generating a color value, this round-down back to 8bit ended up