Re: [PATCH] drm/mipi-dsi: Fix detach call without attach

2023-12-06 Thread Maxime Ripard
Hi, On Wed, Dec 06, 2023 at 02:48:58PM +0200, Tomi Valkeinen wrote: > Hi mipi dsi maintainers (I'm not sure who that is =), > > On 21/09/2023 13:50, Tomi Valkeinen wrote: > > It's been reported that DSI host driver's detach can be called without > > the attach ever happening: > > > >

Re: [PATCH] drm/mipi-dsi: Fix detach call without attach

2023-12-06 Thread Tomi Valkeinen
Hi mipi dsi maintainers (I'm not sure who that is =), On 21/09/2023 13:50, Tomi Valkeinen wrote: It's been reported that DSI host driver's detach can be called without the attach ever happening: https://lore.kernel.org/all/20230412073954.20601-1-t...@atomide.com/ After reading the code, I

Re: [PATCH] drm/mipi-dsi: Fix detach call without attach

2023-09-22 Thread H. Nikolaus Schaller
Hi, I have tested this on an OMAP5 Pyra. > Am 21.09.2023 um 12:50 schrieb Tomi Valkeinen > : > > It's been reported that DSI host driver's detach can be called without > the attach ever happening: > > https://lore.kernel.org/all/20230412073954.20601-1-t...@atomide.com/ > This patch works

Re: [PATCH] drm/mipi-dsi: Fix detach call without attach

2023-09-21 Thread Sebastian Reichel
Hi, On Thu, Sep 21, 2023 at 01:50:32PM +0300, Tomi Valkeinen wrote: > It's been reported that DSI host driver's detach can be called without > the attach ever happening: > > https://lore.kernel.org/all/20230412073954.20601-1-t...@atomide.com/ > > After reading the code, I think this is what

Re: [PATCH] drm/mipi-dsi: Fix detach call without attach

2023-09-21 Thread Tony Lindgren
* Tomi Valkeinen [230921 10:51]: > mipi_dsi_host_unregister() will call two functions for all its DSI > peripheral devices: mipi_dsi_detach() and mipi_dsi_device_unregister(). > The latter makes sense, as the device exists, but the former may be > wrong as attach has not necessarily been done. >

[PATCH] drm/mipi-dsi: Fix detach call without attach

2023-09-21 Thread Tomi Valkeinen
It's been reported that DSI host driver's detach can be called without the attach ever happening: https://lore.kernel.org/all/20230412073954.20601-1-t...@atomide.com/ After reading the code, I think this is what happens: We have a DSI host defined in the device tree and a DSI peripheral under