Re: [PATCH] drm/mm: fix duplicate 'const' declaration specifier

2017-05-10 Thread Nick Desaulniers
ah seems like there's more of these: drivers/gpu/drm/drm_mm.c:922 surprised compiling drivers/gpu/drm/drm_mm.o did not catch this the first time... ___ dri-devel mailing list dri-devel@lists.freedesktop.org

Re: [PATCH] drm/mm: fix duplicate 'const' declaration specifier

2017-05-10 Thread Nick Desaulniers
Please disregard this patch. I think I may have found a bug in Clang, or at least an incompatibility with GCC 7.1. Clang bug: https://bugs.llvm.org/show_bug.cgi?id=32985 ___ dri-devel mailing list dri-devel@lists.freedesktop.org

[PATCH] drm/mm: fix duplicate 'const' declaration specifier

2017-05-10 Thread Nick Desaulniers
Found with -Wduplicate-decl-specifier, a relatively new compiler flag in GCC7, and Clang. list_for_each_entry() eventually calls container_of(), which marks the loop variable as const. The first argument to list_for_each_entry() is a type, which should not already be marked const, otherwise the