Re: [PATCH] drm/msm/adreno: adreno_gpu: Use suspend() instead of idle() on load error

2023-03-30 Thread Dmitry Baryshkov
On 30/03/2023 17:34, Konrad Dybcio wrote: On 29.03.2023 21:45, Dmitry Baryshkov wrote: On Wed, 29 Mar 2023 at 18:48, Konrad Dybcio wrote: On 29.03.2023 16:37, Johan Hovold wrote: On Wed, Mar 29, 2023 at 04:04:44PM +0200, Konrad Dybcio wrote: If we fail to initialize the GPU for

Re: [PATCH] drm/msm/adreno: adreno_gpu: Use suspend() instead of idle() on load error

2023-03-30 Thread Johan Hovold
On Wed, Mar 29, 2023 at 10:45:52PM +0300, Dmitry Baryshkov wrote: > On Wed, 29 Mar 2023 at 18:48, Konrad Dybcio wrote: > > On 29.03.2023 16:37, Johan Hovold wrote: > > > On Wed, Mar 29, 2023 at 04:04:44PM +0200, Konrad Dybcio wrote: > > >> If we fail to initialize the GPU for whatever reason (say

Re: [PATCH] drm/msm/adreno: adreno_gpu: Use suspend() instead of idle() on load error

2023-03-30 Thread Konrad Dybcio
On 29.03.2023 21:45, Dmitry Baryshkov wrote: > On Wed, 29 Mar 2023 at 18:48, Konrad Dybcio wrote: >> >> >> >> On 29.03.2023 16:37, Johan Hovold wrote: >>> On Wed, Mar 29, 2023 at 04:04:44PM +0200, Konrad Dybcio wrote: If we fail to initialize the GPU for whatever reason (say we don't

Re: [PATCH] drm/msm/adreno: adreno_gpu: Use suspend() instead of idle() on load error

2023-03-29 Thread Dmitry Baryshkov
On Wed, 29 Mar 2023 at 18:48, Konrad Dybcio wrote: > > > > On 29.03.2023 16:37, Johan Hovold wrote: > > On Wed, Mar 29, 2023 at 04:04:44PM +0200, Konrad Dybcio wrote: > >> If we fail to initialize the GPU for whatever reason (say we don't > >> embed the GPU firmware files in the initrd), the

Re: [PATCH] drm/msm/adreno: adreno_gpu: Use suspend() instead of idle() on load error

2023-03-29 Thread Konrad Dybcio
On 29.03.2023 19:30, Rob Clark wrote: > On Wed, Mar 29, 2023 at 8:48 AM Konrad Dybcio > wrote: >> >> >> >> On 29.03.2023 16:37, Johan Hovold wrote: >>> On Wed, Mar 29, 2023 at 04:04:44PM +0200, Konrad Dybcio wrote: If we fail to initialize the GPU for whatever reason (say we don't

Re: [PATCH] drm/msm/adreno: adreno_gpu: Use suspend() instead of idle() on load error

2023-03-29 Thread Rob Clark
On Wed, Mar 29, 2023 at 8:48 AM Konrad Dybcio wrote: > > > > On 29.03.2023 16:37, Johan Hovold wrote: > > On Wed, Mar 29, 2023 at 04:04:44PM +0200, Konrad Dybcio wrote: > >> If we fail to initialize the GPU for whatever reason (say we don't > >> embed the GPU firmware files in the initrd), the

Re: [PATCH] drm/msm/adreno: adreno_gpu: Use suspend() instead of idle() on load error

2023-03-29 Thread Konrad Dybcio
On 29.03.2023 16:37, Johan Hovold wrote: > On Wed, Mar 29, 2023 at 04:04:44PM +0200, Konrad Dybcio wrote: >> If we fail to initialize the GPU for whatever reason (say we don't >> embed the GPU firmware files in the initrd), the error path involves >> pm_runtime_put_sync() which then calls

Re: [PATCH] drm/msm/adreno: adreno_gpu: Use suspend() instead of idle() on load error

2023-03-29 Thread Johan Hovold
On Wed, Mar 29, 2023 at 04:04:44PM +0200, Konrad Dybcio wrote: > If we fail to initialize the GPU for whatever reason (say we don't > embed the GPU firmware files in the initrd), the error path involves > pm_runtime_put_sync() which then calls idle() instead of suspend(). > > This is suboptimal,

[PATCH] drm/msm/adreno: adreno_gpu: Use suspend() instead of idle() on load error

2023-03-29 Thread Konrad Dybcio
If we fail to initialize the GPU for whatever reason (say we don't embed the GPU firmware files in the initrd), the error path involves pm_runtime_put_sync() which then calls idle() instead of suspend(). This is suboptimal, as it means that we're not going through the clean shutdown sequence.