Re: [Freedreno] [PATCH] drm/msm/dp: Fix warnings reported by kbot in DP driver

2021-03-05 Thread abhinavk
Hi Stephen Thanks for the review. I will break this up into patches according to the class of warning to show the warning in the commit text and resend the patches. Abhinav On 2021-03-04 23:23, Dan Carpenter wrote: On Thu, Mar 04, 2021 at 10:55:58PM -0800, Stephen Boyd wrote: > @@ -368,44

Re: [PATCH] drm/msm/dp: Fix warnings reported by kbot in DP driver

2021-03-04 Thread Dan Carpenter
On Thu, Mar 04, 2021 at 10:55:58PM -0800, Stephen Boyd wrote: > > @@ -368,44 +368,21 @@ static int dp_debug_init(struct dp_debug *dp_debug, > > struct drm_minor *minor) > > int rc = 0; > > struct dp_debug_private *debug = container_of(dp_debug, > > struct

Re: [PATCH] drm/msm/dp: Fix warnings reported by kbot in DP driver

2021-03-04 Thread Stephen Boyd
Maybe subject could be "Ignore debugfs failures, fix indentation, fix logical error"? Quoting Abhinav Kumar (2021-03-04 17:31:52) > Fix the warnings reported by kbot across MSM DP driver. Which warnings? Can you include them? Or at least list the three things that are being fixed in this patch?

[PATCH] drm/msm/dp: Fix warnings reported by kbot in DP driver

2021-03-04 Thread Abhinav Kumar
Fix the warnings reported by kbot across MSM DP driver. Reported-by: kernel test robot Reported-by: Dan Carpenter Signed-off-by: Abhinav Kumar --- drivers/gpu/drm/msm/dp/dp_debug.c | 33 + drivers/gpu/drm/msm/dp/dp_hpd.c | 4 ++--