Re: [PATCH] drm/msm/dp: fix build after dp quirk helper change

2021-01-21 Thread Jani Nikula
On Thu, 21 Jan 2021, Fabio Estevam wrote: > On Thu, Jan 21, 2021 at 9:10 AM Jani Nikula wrote: > >> Kinda catch-22 because next has dropped current drm-intel-next because >> it doesn't build because of the issue this patch fixes. ;) > > Ok, so I built drm-intel-next and I was able to reproduce

Re: [PATCH] drm/msm/dp: fix build after dp quirk helper change

2021-01-21 Thread Fabio Estevam
On Thu, Jan 21, 2021 at 9:10 AM Jani Nikula wrote: > Kinda catch-22 because next has dropped current drm-intel-next because > it doesn't build because of the issue this patch fixes. ;) Ok, so I built drm-intel-next and I was able to reproduce the buid error as reported by Stephen. Applied this

Re: [PATCH] drm/msm/dp: fix build after dp quirk helper change

2021-01-21 Thread Jani Nikula
On Thu, 21 Jan 2021, Fabio Estevam wrote: > On Thu, Jan 21, 2021 at 8:41 AM Jani Nikula wrote: > >> On top of what? Current drm-tip? > > It was on top of next-20210121. Kinda catch-22 because next has dropped current drm-intel-next because it doesn't build because of the issue this patch fixes.

Re: [PATCH] drm/msm/dp: fix build after dp quirk helper change

2021-01-21 Thread Fabio Estevam
On Thu, Jan 21, 2021 at 8:41 AM Jani Nikula wrote: > On top of what? Current drm-tip? It was on top of next-20210121. ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH] drm/msm/dp: fix build after dp quirk helper change

2021-01-21 Thread Jani Nikula
On Thu, 21 Jan 2021, Fabio Estevam wrote: > Hi Jani, > > On Thu, Jan 21, 2021 at 8:22 AM Jani Nikula wrote: > >> Sean, Rob, or anyone with an arm toolchain for msm available, could I >> trouble you to build test this please? > > I tried to build after applying your patch: On top of what?

Re: [PATCH] drm/msm/dp: fix build after dp quirk helper change

2021-01-21 Thread Fabio Estevam
Hi Jani, On Thu, Jan 21, 2021 at 8:22 AM Jani Nikula wrote: > Sean, Rob, or anyone with an arm toolchain for msm available, could I > trouble you to build test this please? I tried to build after applying your patch: CC drivers/gpu/drm/msm/dp/dp_ctrl.o drivers/gpu/drm/msm/dp/dp_ctrl.c:

Re: [PATCH] drm/msm/dp: fix build after dp quirk helper change

2021-01-21 Thread Jani Nikula
On Wed, 20 Jan 2021, Lyude Paul wrote: > Reviewed-by: Lyude Paul Thanks for the review. Sean, Rob, or anyone with an arm toolchain for msm available, could I trouble you to build test this please? BR, Jani. > > On Wed, 2021-01-20 at 13:07 +0200, Jani Nikula wrote: >> Commit 7c553f8b5a7d

Re: [PATCH] drm/msm/dp: fix build after dp quirk helper change

2021-01-20 Thread Lyude Paul
Reviewed-by: Lyude Paul On Wed, 2021-01-20 at 13:07 +0200, Jani Nikula wrote: > Commit 7c553f8b5a7d ("drm/dp: Revert "drm/dp: Introduce EDID-based > quirks"") removed drm_dp_get_edid_quirks() and changed the signature of > drm_dp_has_quirk() while they were still being used in msm. Fix the >

[PATCH] drm/msm/dp: fix build after dp quirk helper change

2021-01-20 Thread Jani Nikula
Commit 7c553f8b5a7d ("drm/dp: Revert "drm/dp: Introduce EDID-based quirks"") removed drm_dp_get_edid_quirks() and changed the signature of drm_dp_has_quirk() while they were still being used in msm. Fix the breakage. Functionally, removing the EDID-based quirks has no impact on msm. [The above