Re: [Freedreno] [PATCH] drm/msm/dpu: always program dsc active bits

2023-04-27 Thread Marijn Suijten
On 2023-04-14 16:51:52, Abhinav Kumar wrote: > On 4/14/2023 4:11 PM, Marijn Suijten wrote: > > On 2023-04-14 10:57:45, Abhinav Kumar wrote: > >> On 4/14/2023 10:34 AM, Marijn Suijten wrote: > >>> On 2023-04-14 08:48:43, Abhinav Kumar wrote: > On 4/14/2023 12:35 AM, Marijn Suijten wrote: >

Re: [Freedreno] [PATCH] drm/msm/dpu: always program dsc active bits

2023-04-14 Thread Abhinav Kumar
On 4/14/2023 4:11 PM, Marijn Suijten wrote: On 2023-04-14 10:57:45, Abhinav Kumar wrote: On 4/14/2023 10:34 AM, Marijn Suijten wrote: On 2023-04-14 08:48:43, Abhinav Kumar wrote: On 4/14/2023 12:35 AM, Marijn Suijten wrote: On 2023-04-12 10:33:15, Abhinav Kumar wrote: [..] What happens if

Re: [Freedreno] [PATCH] drm/msm/dpu: always program dsc active bits

2023-04-14 Thread Marijn Suijten
On 2023-04-14 10:57:45, Abhinav Kumar wrote: > On 4/14/2023 10:34 AM, Marijn Suijten wrote: > > On 2023-04-14 08:48:43, Abhinav Kumar wrote: > >> On 4/14/2023 12:35 AM, Marijn Suijten wrote: > >>> On 2023-04-12 10:33:15, Abhinav Kumar wrote: > >>> [..] > > What happens if a device boots without

Re: [Freedreno] [PATCH] drm/msm/dpu: always program dsc active bits

2023-04-14 Thread Abhinav Kumar
On 4/14/2023 10:34 AM, Marijn Suijten wrote: On 2023-04-14 08:48:43, Abhinav Kumar wrote: On 4/14/2023 12:35 AM, Marijn Suijten wrote: On 2023-04-12 10:33:15, Abhinav Kumar wrote: [..] What happens if a device boots without DSC panel connected? Will CTL_DSC_FLUSH be zero and not (unnecess

Re: [PATCH] drm/msm/dpu: always program dsc active bits

2023-04-14 Thread Marijn Suijten
On 2023-04-14 08:48:43, Abhinav Kumar wrote: > > On 4/14/2023 12:35 AM, Marijn Suijten wrote: > > On 2023-04-12 10:33:15, Abhinav Kumar wrote: > > [..] > >>> What happens if a device boots without DSC panel connected? Will > >>> CTL_DSC_FLUSH be zero and not (unnecessarily, I assume) flush any of

Re: [PATCH] drm/msm/dpu: always program dsc active bits

2023-04-14 Thread Abhinav Kumar
On 4/14/2023 12:35 AM, Marijn Suijten wrote: On 2023-04-12 10:33:15, Abhinav Kumar wrote: [..] What happens if a device boots without DSC panel connected? Will CTL_DSC_FLUSH be zero and not (unnecessarily, I assume) flush any of the DSC blocks? Or could this flush uninitialized state to the

Re: [PATCH] drm/msm/dpu: always program dsc active bits

2023-04-14 Thread Marijn Suijten
On 2023-04-12 10:33:15, Abhinav Kumar wrote: [..] > > What happens if a device boots without DSC panel connected? Will > > CTL_DSC_FLUSH be zero and not (unnecessarily, I assume) flush any of the > > DSC blocks? Or could this flush uninitialized state to the block? > > > > If we bootup without

Re: [PATCH] drm/msm/dpu: always program dsc active bits

2023-04-12 Thread Abhinav Kumar
On 4/12/2023 12:24 AM, Marijn Suijten wrote: On 2023-04-11 16:45:34, Abhinav Kumar wrote: [..] Does this flush all DSCs programmed in CTL_DSC_FLUSH as set above? That is currently still in `if (cfg->dsc)` and never overwritten if all DSCs are disabled, should it be taken out of the `if` to m

Re: [PATCH] drm/msm/dpu: always program dsc active bits

2023-04-12 Thread Marijn Suijten
On 2023-04-11 16:45:34, Abhinav Kumar wrote: [..] > > Does this flush all DSCs programmed in CTL_DSC_FLUSH as set above? That > > is currently still in `if (cfg->dsc)` and never overwritten if all DSCs > > are disabled, should it be taken out of the `if` to make sure no DSCs > > are inadvertently

Re: [PATCH] drm/msm/dpu: always program dsc active bits

2023-04-11 Thread Abhinav Kumar
On 4/11/2023 3:14 PM, Marijn Suijten wrote: Full-caps DSC in the title, as discussed previously. On that note, don't forget to CC those who have reviewed your patches previously, as also brought up in earlier review. On 2023-04-11 14:04:55, Kuogee Hsieh wrote: In current code, the dsc activ

Re: [PATCH] drm/msm/dpu: always program dsc active bits

2023-04-11 Thread Dmitry Baryshkov
On 12/04/2023 02:32, Abhinav Kumar wrote: On 4/11/2023 3:17 PM, Dmitry Baryshkov wrote: On 12/04/2023 00:04, Kuogee Hsieh wrote: In current code, the dsc active bits are set only if the cfg->dsc is set. However, for displays which are hot-pluggable, there can be a use-case of disconnecting a

Re: [PATCH] drm/msm/dpu: always program dsc active bits

2023-04-11 Thread Abhinav Kumar
On 4/11/2023 3:17 PM, Dmitry Baryshkov wrote: On 12/04/2023 00:04, Kuogee Hsieh wrote: In current code, the dsc active bits are set only if the cfg->dsc is set. However, for displays which are hot-pluggable, there can be a use-case of disconnecting a DSC supported sink and connecting a non-DS

Re: [PATCH] drm/msm/dpu: always program dsc active bits

2023-04-11 Thread Dmitry Baryshkov
On 12/04/2023 00:04, Kuogee Hsieh wrote: In current code, the dsc active bits are set only if the cfg->dsc is set. However, for displays which are hot-pluggable, there can be a use-case of disconnecting a DSC supported sink and connecting a non-DSC sink. For those cases we need to clear DSC acti

Re: [PATCH] drm/msm/dpu: always program dsc active bits

2023-04-11 Thread Marijn Suijten
Full-caps DSC in the title, as discussed previously. On that note, don't forget to CC those who have reviewed your patches previously, as also brought up in earlier review. On 2023-04-11 14:04:55, Kuogee Hsieh wrote: > In current code, the dsc active bits are set only if the cfg->dsc is set. Som

Re: [PATCH] drm/msm/dpu: always program dsc active bits

2023-04-11 Thread Abhinav Kumar
On 4/11/2023 2:04 PM, Kuogee Hsieh wrote: In current code, the dsc active bits are set only if the cfg->dsc is set. However, for displays which are hot-pluggable, there can be a use-case of disconnecting a DSC supported sink and connecting a non-DSC sink. For those cases we need to clear DSC

[PATCH] drm/msm/dpu: always program dsc active bits

2023-04-11 Thread Kuogee Hsieh
In current code, the dsc active bits are set only if the cfg->dsc is set. However, for displays which are hot-pluggable, there can be a use-case of disconnecting a DSC supported sink and connecting a non-DSC sink. For those cases we need to clear DSC active bits during teardown. Fixes: ede3c6bb00