Re: [PATCH] drm/msm/dpu: protect ctl ops calls with validity checks

2024-06-20 Thread Abhinav Kumar
On 6/20/2024 9:41 AM, Rob Clark wrote: On Thu, Jun 20, 2024 at 6:08 AM Dmitry Baryshkov wrote: On Thu, 20 Jun 2024 at 00:27, Abhinav Kumar wrote: dpu_encoder_helper_phys_cleanup() calls the ctl ops without checking if the ops are assigned causing discrepancy between its callers where the

Re: [PATCH] drm/msm/dpu: protect ctl ops calls with validity checks

2024-06-20 Thread Rob Clark
On Thu, Jun 20, 2024 at 6:08 AM Dmitry Baryshkov wrote: > > On Thu, 20 Jun 2024 at 00:27, Abhinav Kumar wrote: > > > > dpu_encoder_helper_phys_cleanup() calls the ctl ops without checking if > > the ops are assigned causing discrepancy between its callers where the > > checks are performed and th

Re: [PATCH] drm/msm/dpu: protect ctl ops calls with validity checks

2024-06-20 Thread Dmitry Baryshkov
On Thu, 20 Jun 2024 at 00:27, Abhinav Kumar wrote: > > dpu_encoder_helper_phys_cleanup() calls the ctl ops without checking if > the ops are assigned causing discrepancy between its callers where the > checks are performed and the API itself which does not. > > Two approaches can be taken: either

[PATCH] drm/msm/dpu: protect ctl ops calls with validity checks

2024-06-19 Thread Abhinav Kumar
dpu_encoder_helper_phys_cleanup() calls the ctl ops without checking if the ops are assigned causing discrepancy between its callers where the checks are performed and the API itself which does not. Two approaches can be taken: either drop the checks even in the caller OR add the checks even in dp