Re: [PATCH] drm/msm/gem: Drop obj lock in msm_gem_free_object()

On Fri, Jun 24, 2022 at 2:36 PM Daniel Vetter wrote: > > On Fri, Jun 24, 2022 at 02:28:25PM -0700, Rob Clark wrote: > > On Fri, Jun 24, 2022 at 1:58 PM Daniel Vetter wrote: > > > > > > On Thu, Jun 16, 2022 at 06:59:46AM -0700, Rob Clark wrote: > > > > On Thu, Jun 16, 2022 at 1:28 AM Stephen Boyd

Re: [PATCH] drm/msm/gem: Drop obj lock in msm_gem_free_object()

On Fri, Jun 24, 2022 at 02:28:25PM -0700, Rob Clark wrote: > On Fri, Jun 24, 2022 at 1:58 PM Daniel Vetter wrote: > > > > On Thu, Jun 16, 2022 at 06:59:46AM -0700, Rob Clark wrote: > > > On Thu, Jun 16, 2022 at 1:28 AM Stephen Boyd wrote: > > > > > > > > Quoting Rob Clark (2022-06-13 13:50:32) >

Re: [PATCH] drm/msm/gem: Drop obj lock in msm_gem_free_object()

On Fri, Jun 24, 2022 at 1:58 PM Daniel Vetter wrote: > > On Thu, Jun 16, 2022 at 06:59:46AM -0700, Rob Clark wrote: > > On Thu, Jun 16, 2022 at 1:28 AM Stephen Boyd wrote: > > > > > > Quoting Rob Clark (2022-06-13 13:50:32) > > > > diff --git a/drivers/gpu/drm/msm/msm_gem.h > > > > b/drivers/gpu

Re: [PATCH] drm/msm/gem: Drop obj lock in msm_gem_free_object()

On Thu, Jun 16, 2022 at 06:59:46AM -0700, Rob Clark wrote: > On Thu, Jun 16, 2022 at 1:28 AM Stephen Boyd wrote: > > > > Quoting Rob Clark (2022-06-13 13:50:32) > > > diff --git a/drivers/gpu/drm/msm/msm_gem.h b/drivers/gpu/drm/msm/msm_gem.h > > > index d608339c1643..432032ad4aed 100644 > > > ---

Re: [PATCH] drm/msm/gem: Drop obj lock in msm_gem_free_object()

On Thu, Jun 16, 2022 at 1:28 AM Stephen Boyd wrote: > > Quoting Rob Clark (2022-06-13 13:50:32) > > diff --git a/drivers/gpu/drm/msm/msm_gem.h b/drivers/gpu/drm/msm/msm_gem.h > > index d608339c1643..432032ad4aed 100644 > > --- a/drivers/gpu/drm/msm/msm_gem.h > > +++ b/drivers/gpu/drm/msm/msm_gem.h

Re: [PATCH] drm/msm/gem: Drop obj lock in msm_gem_free_object()

Quoting Rob Clark (2022-06-13 13:50:32) > diff --git a/drivers/gpu/drm/msm/msm_gem.h b/drivers/gpu/drm/msm/msm_gem.h > index d608339c1643..432032ad4aed 100644 > --- a/drivers/gpu/drm/msm/msm_gem.h > +++ b/drivers/gpu/drm/msm/msm_gem.h > @@ -229,7 +229,19 @@ msm_gem_unlock(struct drm_gem_object *obj

[PATCH] drm/msm/gem: Drop obj lock in msm_gem_free_object()

From: Rob Clark The only reason we grabbed the lock was to satisfy a bunch of places that WARN_ON() if called without the lock held. But this angers lockdep which doesn't realize no one else can be holding the lock by the time we end up destroying the object (and sees what would otherwise be a l