Re: [Nouveau] [PATCH] drm/nouveau/hwmon: Uninitialized variables in sysfs

2017-12-29 Thread Pierre Moreau
Ping: this can still be an issue today as kstrtol() & co haven’t changed their possible return value since the patch was written. On 2017-07-22 — 14:13, Pierre Moreau wrote: > Reviewed-by: Pierre Moreau > > On 2017-07-17 — 11:17, Dan Carpenter wrote: > > kstrtol() and friends can return -EINVAL

Re: [Nouveau] [PATCH] drm/nouveau/hwmon: Uninitialized variables in sysfs

2017-07-22 Thread Pierre Moreau
Reviewed-by: Pierre Moreau On 2017-07-17 — 11:17, Dan Carpenter wrote: > kstrtol() and friends can return -EINVAL or -ERANGE. We have to test > for both, otherwise the value is possibly uninitialized. Also in some > of these files we accidentally return "count" on error instead of a > negative

[PATCH] drm/nouveau/hwmon: Uninitialized variables in sysfs

2017-07-17 Thread Dan Carpenter
kstrtol() and friends can return -EINVAL or -ERANGE. We have to test for both, otherwise the value is possibly uninitialized. Also in some of these files we accidentally return "count" on error instead of a negative error code. Signed-off-by: Dan Carpenter diff --git a/drivers/gpu/drm/nouveau/