Re: [PATCH] drm/nouveau: don't attempt to schedule hpd_work on headless cards

On Thu, Jun 6, 2024 at 6:37 PM Dave Airlie wrote: > > readding original poster Thanks, Dave! Ben, please keep me on CC, since I'm not subscribed to either nouveau or dri-devel mailing lists. > On Wed, 29 May 2024 at 09:57, Ben Skeggs wrote: > > > diff --git a/drivers/gpu/drm/nouveau/nouveau_c

Re: [PATCH] drm/nouveau: don't attempt to schedule hpd_work on headless cards

readding original poster On Wed, 29 May 2024 at 09:57, Ben Skeggs wrote: > > On 29/5/24 07:52, Vasily Khoruzhick wrote: > > > If the card doesn't have display hardware, hpd_work and hpd_lock are > > left uninitialized which causes BUG when attempting to schedule hpd_work > > on runtime PM resume.

Re: [PATCH] drm/nouveau: don't attempt to schedule hpd_work on headless cards

On 29/5/24 07:52, Vasily Khoruzhick wrote: If the card doesn't have display hardware, hpd_work and hpd_lock are left uninitialized which causes BUG when attempting to schedule hpd_work on runtime PM resume. Hi, Good catch, thank you for looking at this.  A couple of initial comments below:

[PATCH] drm/nouveau: don't attempt to schedule hpd_work on headless cards

If the card doesn't have display hardware, hpd_work and hpd_lock are left uninitialized which causes BUG when attempting to schedule hpd_work on runtime PM resume. Fix it by adding headless flag to DRM and skip any hpd if it's set. Fixes: ae1aadb1eb8d ("nouveau: don't fail driver load if no displ