Re: [PATCH] drm/omap: Fix runtime PM imbalance in dsi_runtime_get

2020-08-22 Thread Laurent Pinchart
Hi Tomi, On Fri, Aug 21, 2020 at 03:06:59PM +0300, Tomi Valkeinen wrote: > On 21/08/2020 10:45, Dinghao Liu wrote: > > pm_runtime_get_sync() increments the runtime PM usage counter > > even when it returns an error code. However, users of > > dsi_runtime_get(), a direct wrapper of pm_runtime_get_s

Re: Re: [PATCH] drm/omap: Fix runtime PM imbalance in dsi_runtime_get

2020-08-22 Thread dinghao . liu
> Hi, > > On 21/08/2020 10:45, Dinghao Liu wrote: > > pm_runtime_get_sync() increments the runtime PM usage counter > > even when it returns an error code. However, users of > > dsi_runtime_get(), a direct wrapper of pm_runtime_get_sync(), > > assume that PM usage counter will not change on error.

[PATCH] drm/omap: Fix runtime PM imbalance in dsi_runtime_get

2020-08-22 Thread Dinghao Liu
pm_runtime_get_sync() increments the runtime PM usage counter even when it returns an error code. However, users of dsi_runtime_get(), a direct wrapper of pm_runtime_get_sync(), assume that PM usage counter will not change on error. Thus a pairing decrement is needed on the error handling path to k

Re: [PATCH] drm/omap: Fix runtime PM imbalance in dsi_runtime_get

2020-08-21 Thread Tomi Valkeinen
Hi, On 21/08/2020 10:45, Dinghao Liu wrote: > pm_runtime_get_sync() increments the runtime PM usage counter > even when it returns an error code. However, users of > dsi_runtime_get(), a direct wrapper of pm_runtime_get_sync(), > assume that PM usage counter will not change on error. Thus a > pair