Re: [PATCH] drm/omap: dsi: Fix missing of_platform_depopulate()

2018-11-12 Thread Tomi Valkeinen
On 06/11/18 17:28, Tony Lindgren wrote: > We're missing a call to of_platform_depopulate() on errors for dsi. > Looks like dss is already doing this. > > Signed-off-by: Tony Lindgren > --- > drivers/gpu/drm/omapdrm/dss/dsi.c | 8 ++-- > 1 file changed, 6 insertions(+), 2 deletions(-) > > di

Re: [PATCH] drm/omap: dsi: Fix missing of_platform_depopulate()

2018-11-09 Thread Tony Lindgren
* Laurent Pinchart [181107 05:30]: > Hi Tony, > > Thank you for the patch. > > On Tuesday, 6 November 2018 17:28:02 EET Tony Lindgren wrote: > > We're missing a call to of_platform_depopulate() on errors for dsi. > > Looks like dss is already doing this. > > > > Signed-off-by: Tony Lindgren >

Re: [PATCH] drm/omap: dsi: Fix missing of_platform_depopulate()

2018-11-08 Thread Sebastian Reichel
Hi, On Tue, Nov 06, 2018 at 07:28:02AM -0800, Tony Lindgren wrote: > We're missing a call to of_platform_depopulate() on errors for dsi. > Looks like dss is already doing this. > > Signed-off-by: Tony Lindgren > --- Reviewed-by: Sebastian Reichel -- Sebastian > drivers/gpu/drm/omapdrm/dss/d

Re: [PATCH] drm/omap: dsi: Fix missing of_platform_depopulate()

2018-11-08 Thread Laurent Pinchart
Hi Tony, On Thursday, 8 November 2018 19:01:45 EET Tony Lindgren wrote: > * Laurent Pinchart [181107 05:30]: > > On Tuesday, 6 November 2018 17:28:02 EET Tony Lindgren wrote: > > > We're missing a call to of_platform_depopulate() on errors for dsi. > > > Looks like dss is already doing this. > >

Re: [PATCH] drm/omap: dsi: Fix missing of_platform_depopulate()

2018-11-07 Thread Laurent Pinchart
Hi Tony, Thank you for the patch. On Tuesday, 6 November 2018 17:28:02 EET Tony Lindgren wrote: > We're missing a call to of_platform_depopulate() on errors for dsi. > Looks like dss is already doing this. > > Signed-off-by: Tony Lindgren This makes sense to me. You may however want to note in

[PATCH] drm/omap: dsi: Fix missing of_platform_depopulate()

2018-11-07 Thread Tony Lindgren
We're missing a call to of_platform_depopulate() on errors for dsi. Looks like dss is already doing this. Signed-off-by: Tony Lindgren --- drivers/gpu/drm/omapdrm/dss/dsi.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/omapdrm/dss/dsi.c b/drivers/gp