Re: [PATCH] drm/panfrost: DMA map all pages shared with the GPU

2019-10-14 Thread Steven Price
On 14/10/2019 16:55, Steven Price wrote: > On 14/10/2019 16:46, Robin Murphy wrote: >> On 14/10/2019 16:16, Steven Price wrote: >>> Pages shared with the GPU are (often) not cache coherent with the CPU so >>> cache maintenance is required to flush the CPU's caches. This was >>> already done when ma

Re: [PATCH] drm/panfrost: DMA map all pages shared with the GPU

2019-10-14 Thread Steven Price
On 14/10/2019 16:46, Robin Murphy wrote: > On 14/10/2019 16:16, Steven Price wrote: >> Pages shared with the GPU are (often) not cache coherent with the CPU so >> cache maintenance is required to flush the CPU's caches. This was >> already done when mapping pages on fault, but wasn't previously don

Re: [PATCH] drm/panfrost: DMA map all pages shared with the GPU

2019-10-14 Thread Robin Murphy
On 14/10/2019 16:16, Steven Price wrote: Pages shared with the GPU are (often) not cache coherent with the CPU so cache maintenance is required to flush the CPU's caches. This was already done when mapping pages on fault, but wasn't previously done when mapping a freshly allocated page. Fix this

[PATCH] drm/panfrost: DMA map all pages shared with the GPU

2019-10-14 Thread Steven Price
Pages shared with the GPU are (often) not cache coherent with the CPU so cache maintenance is required to flush the CPU's caches. This was already done when mapping pages on fault, but wasn't previously done when mapping a freshly allocated page. Fix this by moving the call to dma_map_sg() into mm