Re: [PATCH] drm/panfrost: Really power off GPU cores in panfrost_gpu_power_off()

2023-12-03 Thread Krzysztof Kozlowski
On 22/11/2023 10:29, Krzysztof Kozlowski wrote: > On 22/11/2023 10:06, AngeloGioacchino Del Regno wrote: > >> > > Hey Krzysztof, > > This is interesting. It might be about the cores that are missing from > the partial > core_mask raising interrupts, but an

Re: [PATCH] drm/panfrost: Really power off GPU cores in panfrost_gpu_power_off()

2023-11-27 Thread AngeloGioacchino Del Regno
Il 27/11/23 12:24, Marek Szyprowski ha scritto: On 24.11.2023 13:45, Marek Szyprowski wrote: On 22.11.2023 10:29, Krzysztof Kozlowski wrote: On 22/11/2023 10:06, AngeloGioacchino Del Regno wrote: Hey Krzysztof, This is interesting. It might be about the cores that are missing from the

Re: [PATCH] drm/panfrost: Really power off GPU cores in panfrost_gpu_power_off()

2023-11-27 Thread Marek Szyprowski
On 24.11.2023 13:45, Marek Szyprowski wrote: > On 22.11.2023 10:29, Krzysztof Kozlowski wrote: >> On 22/11/2023 10:06, AngeloGioacchino Del Regno wrote: >> Hey Krzysztof, >> >> This is interesting. It might be about the cores that are missing >> from the partial >> core_mask

Re: [PATCH] drm/panfrost: Really power off GPU cores in panfrost_gpu_power_off()

2023-11-24 Thread Marek Szyprowski
On 22.11.2023 10:29, Krzysztof Kozlowski wrote: > On 22/11/2023 10:06, AngeloGioacchino Del Regno wrote: > Hey Krzysztof, > > This is interesting. It might be about the cores that are missing from > the partial > core_mask raising interrupts, but an external abort on

Re: [PATCH] drm/panfrost: Really power off GPU cores in panfrost_gpu_power_off()

2023-11-24 Thread Marek Szyprowski
On 22.11.2023 10:29, Krzysztof Kozlowski wrote: > On 22/11/2023 10:06, AngeloGioacchino Del Regno wrote: > Hey Krzysztof, > > This is interesting. It might be about the cores that are missing from > the partial > core_mask raising interrupts, but an external abort on

Re: [PATCH] drm/panfrost: Really power off GPU cores in panfrost_gpu_power_off()

2023-11-22 Thread Boris Brezillon
On Wed, 22 Nov 2023 11:23:05 +0100 AngeloGioacchino Del Regno wrote: > Il 22/11/23 10:54, Boris Brezillon ha scritto: > > Hi Angelo, > > > > On Wed, 22 Nov 2023 10:06:19 +0100 > > AngeloGioacchino Del Regno > > wrote: > > > >> Il 21/11/23 18:08, Krzysztof Kozlowski ha scritto: > >>> On

Re: [PATCH] drm/panfrost: Really power off GPU cores in panfrost_gpu_power_off()

2023-11-22 Thread AngeloGioacchino Del Regno
Il 22/11/23 10:48, Steven Price ha scritto: On 22/11/2023 09:06, AngeloGioacchino Del Regno wrote: Il 21/11/23 18:08, Krzysztof Kozlowski ha scritto: On 21/11/2023 17:55, Boris Brezillon wrote: On Tue, 21 Nov 2023 17:11:42 +0100 AngeloGioacchino Del Regno wrote: Il 21/11/23 16:34,

Re: [PATCH] drm/panfrost: Really power off GPU cores in panfrost_gpu_power_off()

2023-11-22 Thread AngeloGioacchino Del Regno
Il 22/11/23 10:54, Boris Brezillon ha scritto: Hi Angelo, On Wed, 22 Nov 2023 10:06:19 +0100 AngeloGioacchino Del Regno wrote: Il 21/11/23 18:08, Krzysztof Kozlowski ha scritto: On 21/11/2023 17:55, Boris Brezillon wrote: On Tue, 21 Nov 2023 17:11:42 +0100 AngeloGioacchino Del Regno

Re: [PATCH] drm/panfrost: Really power off GPU cores in panfrost_gpu_power_off()

2023-11-22 Thread Boris Brezillon
Hi Angelo, On Wed, 22 Nov 2023 10:06:19 +0100 AngeloGioacchino Del Regno wrote: > Il 21/11/23 18:08, Krzysztof Kozlowski ha scritto: > > On 21/11/2023 17:55, Boris Brezillon wrote: > >> On Tue, 21 Nov 2023 17:11:42 +0100 > >> AngeloGioacchino Del Regno > >> wrote: > >> > >>> Il 21/11/23

Re: [PATCH] drm/panfrost: Really power off GPU cores in panfrost_gpu_power_off()

2023-11-22 Thread Steven Price
On 22/11/2023 09:06, AngeloGioacchino Del Regno wrote: > Il 21/11/23 18:08, Krzysztof Kozlowski ha scritto: >> On 21/11/2023 17:55, Boris Brezillon wrote: >>> On Tue, 21 Nov 2023 17:11:42 +0100 >>> AngeloGioacchino Del Regno >>> wrote: >>> Il 21/11/23 16:34, Krzysztof Kozlowski ha scritto:

Re: [PATCH] drm/panfrost: Really power off GPU cores in panfrost_gpu_power_off()

2023-11-22 Thread Krzysztof Kozlowski
On 22/11/2023 10:06, AngeloGioacchino Del Regno wrote: > Hey Krzysztof, This is interesting. It might be about the cores that are missing from the partial core_mask raising interrupts, but an external abort on non-linefetch is strange to see here.

Re: [PATCH] drm/panfrost: Really power off GPU cores in panfrost_gpu_power_off()

2023-11-22 Thread AngeloGioacchino Del Regno
Il 21/11/23 18:08, Krzysztof Kozlowski ha scritto: On 21/11/2023 17:55, Boris Brezillon wrote: On Tue, 21 Nov 2023 17:11:42 +0100 AngeloGioacchino Del Regno wrote: Il 21/11/23 16:34, Krzysztof Kozlowski ha scritto: On 08/11/2023 14:20, Steven Price wrote: On 02/11/2023 14:15,

Re: [PATCH] drm/panfrost: Really power off GPU cores in panfrost_gpu_power_off()

2023-11-22 Thread Boris Brezillon
On Tue, 21 Nov 2023 18:08:44 +0100 Krzysztof Kozlowski wrote: > > non-linefetch access, but it might be caused by a register access after > > the clock or power domain driving the register bank has been disabled. > > The following diff might help validate this theory. If that works, we > >

Re: [PATCH] drm/panfrost: Really power off GPU cores in panfrost_gpu_power_off()

2023-11-21 Thread Krzysztof Kozlowski
On 21/11/2023 17:55, Boris Brezillon wrote: > On Tue, 21 Nov 2023 17:11:42 +0100 > AngeloGioacchino Del Regno > wrote: > >> Il 21/11/23 16:34, Krzysztof Kozlowski ha scritto: >>> On 08/11/2023 14:20, Steven Price wrote: On 02/11/2023 14:15, AngeloGioacchino Del Regno wrote: > The

Re: [PATCH] drm/panfrost: Really power off GPU cores in panfrost_gpu_power_off()

2023-11-21 Thread Boris Brezillon
On Tue, 21 Nov 2023 17:11:42 +0100 AngeloGioacchino Del Regno wrote: > Il 21/11/23 16:34, Krzysztof Kozlowski ha scritto: > > On 08/11/2023 14:20, Steven Price wrote: > >> On 02/11/2023 14:15, AngeloGioacchino Del Regno wrote: > >>> The layout of the registers {TILER,SHADER,L2}_PWROFF_LO,

Re: [PATCH] drm/panfrost: Really power off GPU cores in panfrost_gpu_power_off()

2023-11-21 Thread Krzysztof Kozlowski
On 21/11/2023 17:11, AngeloGioacchino Del Regno wrote: > Il 21/11/23 16:34, Krzysztof Kozlowski ha scritto: >> On 08/11/2023 14:20, Steven Price wrote: >>> On 02/11/2023 14:15, AngeloGioacchino Del Regno wrote: The layout of the registers {TILER,SHADER,L2}_PWROFF_LO, used to request

Re: [PATCH] drm/panfrost: Really power off GPU cores in panfrost_gpu_power_off()

2023-11-21 Thread AngeloGioacchino Del Regno
Il 21/11/23 16:34, Krzysztof Kozlowski ha scritto: On 08/11/2023 14:20, Steven Price wrote: On 02/11/2023 14:15, AngeloGioacchino Del Regno wrote: The layout of the registers {TILER,SHADER,L2}_PWROFF_LO, used to request powering off cores, is the same as the {TILER,SHADER,L2}_PWRON_LO ones:

Re: [PATCH] drm/panfrost: Really power off GPU cores in panfrost_gpu_power_off()

2023-11-21 Thread Krzysztof Kozlowski
On 08/11/2023 14:20, Steven Price wrote: > On 02/11/2023 14:15, AngeloGioacchino Del Regno wrote: >> The layout of the registers {TILER,SHADER,L2}_PWROFF_LO, used to request >> powering off cores, is the same as the {TILER,SHADER,L2}_PWRON_LO ones: >> this means that in order to request poweroff

Re: [PATCH] drm/panfrost: Really power off GPU cores in panfrost_gpu_power_off()

2023-11-08 Thread Steven Price
On 02/11/2023 14:15, AngeloGioacchino Del Regno wrote: > The layout of the registers {TILER,SHADER,L2}_PWROFF_LO, used to request > powering off cores, is the same as the {TILER,SHADER,L2}_PWRON_LO ones: > this means that in order to request poweroff of cores, we are supposed > to write a bitmask

[PATCH] drm/panfrost: Really power off GPU cores in panfrost_gpu_power_off()

2023-11-02 Thread AngeloGioacchino Del Regno
The layout of the registers {TILER,SHADER,L2}_PWROFF_LO, used to request powering off cores, is the same as the {TILER,SHADER,L2}_PWRON_LO ones: this means that in order to request poweroff of cores, we are supposed to write a bitmask of cores that should be powered off! This means that the