Re: [PATCH] drm/panthor: clean up some types in panthor_sched_suspend()

2024-04-17 Thread Boris Brezillon
On Mon, 8 Apr 2024 13:27:17 +0100 Steven Price wrote: > On 08/04/2024 08:36, Dan Carpenter wrote: > > These variables should be u32 instead of u64 because they're only > > storing u32 values. Also static checkers complain when we do: > > > > suspended_slots &= ~upd_ctx.timedout_mask; > >

Re: [PATCH] drm/panthor: clean up some types in panthor_sched_suspend()

2024-04-08 Thread Steven Price
On 08/04/2024 08:36, Dan Carpenter wrote: > These variables should be u32 instead of u64 because they're only > storing u32 values. Also static checkers complain when we do: > > suspended_slots &= ~upd_ctx.timedout_mask; > > In this code "suspended_slots" is a u64 and

[PATCH] drm/panthor: clean up some types in panthor_sched_suspend()

2024-04-08 Thread Dan Carpenter
These variables should be u32 instead of u64 because they're only storing u32 values. Also static checkers complain when we do: suspended_slots &= ~upd_ctx.timedout_mask; In this code "suspended_slots" is a u64 and "upd_ctx.timedout_mask". The mask clears out the top 32 bits which