Re: [PATCH] drm/plane: fix error handling in __drm_universal_plane_init

2023-12-06 Thread Thomas Zimmermann
Hi Am 06.12.23 um 10:09 schrieb Dmitry Baryshkov: On Wed, 6 Dec 2023 at 10:22, Thomas Zimmermann wrote: Hi Am 06.12.23 um 08:27 schrieb Dinghao Liu: __drm_universal_plane_init() frees plane->format_types and plane->modifiers on failure. However, sometimes its callers will free these two

Re: [PATCH] drm/plane: fix error handling in __drm_universal_plane_init

2023-12-06 Thread Dmitry Baryshkov
On Wed, 6 Dec 2023 at 10:22, Thomas Zimmermann wrote: > > Hi > > Am 06.12.23 um 08:27 schrieb Dinghao Liu: > > __drm_universal_plane_init() frees plane->format_types and > > plane->modifiers on failure. However, sometimes its callers > > will free these two pointers again, which may lead to a > >

Re: [PATCH] drm/plane: fix error handling in __drm_universal_plane_init

2023-12-06 Thread Thomas Zimmermann
Hi Am 06.12.23 um 08:27 schrieb Dinghao Liu: __drm_universal_plane_init() frees plane->format_types and plane->modifiers on failure. However, sometimes its callers will free these two pointers again, which may lead to a double-free. One possible call chain is: mdp5_plane_init |->

[PATCH] drm/plane: fix error handling in __drm_universal_plane_init

2023-12-05 Thread Dinghao Liu
__drm_universal_plane_init() frees plane->format_types and plane->modifiers on failure. However, sometimes its callers will free these two pointers again, which may lead to a double-free. One possible call chain is: mdp5_plane_init |-> drm_universal_plane_init | |->